You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2014/06/26 19:19:50 UTC
Review Request 23045: ambari-server may kill INIT and SSHD process (in some
specific scenarios)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23045/
-----------------------------------------------------------
Review request for Ambari and Andrew Onischuk.
Bugs: AMBARI-6288
https://issues.apache.org/jira/browse/AMBARI-6288
Repository: ambari
Description
-------
Format string for our command line for starting java process is outdated and it writes java process exit code to pid file. In most cases our code overrides PID file generated by this command line with a real pid later, but in some cases (e.g. when current dir is not available or maybe when we have no permissions to chdir to it, or maybe in other cases) it fails to do so.
Diffs
-----
ambari-server/src/main/python/ambari-server.py 7987b95
ambari-server/src/main/python/setupAgent.py 1fad46a
Diff: https://reviews.apache.org/r/23045/diff/
Testing
-------
----------------------------------------------------------------------
Ran 215 tests in 2.169s
OK
----------------------------------------------------------------------
Total run:570
Total errors:0
Total failures:0
OK
Thanks,
Dmitro Lisnichenko
Re: Review Request 23045: ambari-server may kill INIT and SSHD process (in
some specific scenarios)
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23045/#review46762
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Onischuk
On June 26, 2014, 5:19 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23045/
> -----------------------------------------------------------
>
> (Updated June 26, 2014, 5:19 p.m.)
>
>
> Review request for Ambari and Andrew Onischuk.
>
>
> Bugs: AMBARI-6288
> https://issues.apache.org/jira/browse/AMBARI-6288
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Format string for our command line for starting java process is outdated and it writes java process exit code to pid file. In most cases our code overrides PID file generated by this command line with a real pid later, but in some cases (e.g. when current dir is not available or maybe when we have no permissions to chdir to it, or maybe in other cases) it fails to do so.
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py 7987b95
> ambari-server/src/main/python/setupAgent.py 1fad46a
>
> Diff: https://reviews.apache.org/r/23045/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 215 tests in 2.169s
>
> OK
> ----------------------------------------------------------------------
> Total run:570
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>