[GitHub] [pinot] xiangfu0 commented on a change in pull request #8030: Adding pinot server grpc metadata acl

[GitBox <gi...@apache.org>]

xiangfu0 commented on a change in pull request #8030:
URL: https://github.com/apache/pinot/pull/8030#discussion_r787388839



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/transport/grpc/GrpcQueryServer.java
##########
@@ -48,11 +51,14 @@
   private final Server _server;
   private final ExecutorService _executorService =
       Executors.newFixedThreadPool(ResourceManager.DEFAULT_QUERY_WORKER_THREADS);
+  private final AccessControl _accessControl;
 
-  public GrpcQueryServer(int port, QueryExecutor queryExecutor, ServerMetrics serverMetrics) {
+  public GrpcQueryServer(int port, QueryExecutor queryExecutor, ServerMetrics serverMetrics,
+      AccessControlFactory accessControlFactory) {
     _queryExecutor = queryExecutor;
     _serverMetrics = serverMetrics;
     _server = ServerBuilder.forPort(port).addService(this).build();
+    _accessControl = accessControlFactory.create();

Review comment:
       Was following the old behavior to pass the Factory, but I think you are right, we should create the ACL in ServerInstance then set it to both nettyTlsQueryServer and grpcQueryServer.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org