You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/23 20:09:24 UTC
[GitHub] [airflow] ashb opened a new pull request #11797: Fix locking issue stopping tasks running with SequentialExecutor
ashb opened a new pull request #11797:
URL: https://github.com/apache/airflow/pull/11797
Missing a commit means that the the row level lock was not released
before `executor.heartbeat()` was called. This was only a problem for
the SequentialExecutor, as all the other executors would continue
running the scheduler code so the lock would be released shortly after
tasks are sent to the executor anyway. (Where as SequentialExecutor
doesn't return control until tasks have run!)
Fixes #11788
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #11797: Fix locking issue stopping tasks running with SequentialExecutor
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #11797:
URL: https://github.com/apache/airflow/pull/11797
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #11797: Fix locking issue stopping tasks running with SequentialExecutor
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #11797:
URL: https://github.com/apache/airflow/pull/11797#issuecomment-715882665
Whoa. One line :) . Thanks @kaxil and @ashb!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11797: Fix locking issue stopping tasks running with SequentialExecutor
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11797:
URL: https://github.com/apache/airflow/pull/11797#issuecomment-715882665
Whoa. One line :) . Thanks @kaxil!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11797: Fix locking issue stopping tasks running with SequentialExecutor
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11797:
URL: https://github.com/apache/airflow/pull/11797#issuecomment-715824117
Cool!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org