You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/05/23 02:01:51 UTC

[GitHub] [rocketmq] zhanghaou opened a new pull request #2029: [ISSUE #1689]add interfaces to remove unused statsItems in BrokerStatsManager

zhanghaou opened a new pull request #2029:
URL: https://github.com/apache/rocketmq/pull/2029

## What is the purpose of the change

Fix ISSUE 1689, remove unused statsItems when topic or group deleted.

## Brief changelog

XX

## Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.

- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] zongtanghu merged pull request #2029: [ISSUE #1689]add interfaces to remove unused statsItems in BrokerStatsManager

Posted by GitBox <gi...@apache.org>.

zongtanghu merged pull request #2029:
URL: https://github.com/apache/rocketmq/pull/2029


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] zhanghaou commented on pull request #2029: [ISSUE #1689]add interfaces to remove unused statsItems in BrokerStatsManager

Posted by GitBox <gi...@apache.org>.

zhanghaou commented on pull request #2029:
URL: https://github.com/apache/rocketmq/pull/2029#issuecomment-632972340


   Link [https://github.com/apache/rocketmq/pull/1786](https://github.com/apache/rocketmq/pull/1786)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on pull request #2029: [ISSUE #1689]add interfaces to remove unused statsItems in BrokerStatsManager

Posted by GitBox <gi...@apache.org>.

RongtongJin commented on pull request #2029:
URL: https://github.com/apache/rocketmq/pull/2029#issuecomment-633479115


   link #1689 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] zongtanghu commented on pull request #2029: [ISSUE #1689]add interfaces to remove unused statsItems in BrokerStatsManager

Posted by GitBox <gi...@apache.org>.

zongtanghu commented on pull request #2029:
URL: https://github.com/apache/rocketmq/pull/2029#issuecomment-632977300


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-commenter commented on pull request #2029: [ISSUE #1689]add interfaces to remove unused statsItems in BrokerStatsManager

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on pull request #2029:
URL: https://github.com/apache/rocketmq/pull/2029#issuecomment-632972085


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2029?src=pr&el=h1) Report
   > Merging [#2029](https://codecov.io/gh/apache/rocketmq/pull/2029?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/rocketmq/commit/23bf87bef6a9fde138353f9cca271b2813ba6b01&el=desc) will **increase** coverage by `0.19%`.
   > The diff coverage is `30.76%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/2029/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv)](https://codecov.io/gh/apache/rocketmq/pull/2029?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #2029      +/-   ##
   =============================================
   + Coverage      45.01%   45.20%   +0.19%     
   - Complexity      4189     4214      +25     
   =============================================
     Files            545      545              
     Lines          35732    35794      +62     
     Branches        4744     4757      +13     
   =============================================
   + Hits           16084    16181      +97     
   + Misses         17607    17568      -39     
   - Partials        2041     2045       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2029?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ocketmq/broker/processor/AdminBrokerProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/2029/diff?src=pr&el=tree#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL0FkbWluQnJva2VyUHJvY2Vzc29yLmphdmE=) | `4.44% <0.00%> (-0.02%)` | `6.00 <0.00> (ø)` | |
   | [...rocketmq/client/impl/factory/MQClientInstance.java](https://codecov.io/gh/apache/rocketmq/pull/2029/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9mYWN0b3J5L01RQ2xpZW50SW5zdGFuY2UuamF2YQ==) | `46.52% <ø> (+0.79%)` | `81.00 <0.00> (+1.00)` | |
   | [...ache/rocketmq/common/stats/MomentStatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/2029/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtU2V0LmphdmE=) | `39.13% <0.00%> (-17.12%)` | `5.00 <0.00> (ø)` | |
   | [...org/apache/rocketmq/common/stats/StatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/2029/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvU3RhdHNJdGVtU2V0LmphdmE=) | `38.09% <0.00%> (-11.41%)` | `12.00 <0.00> (-1.00)` | |
   | [...org/apache/rocketmq/store/DefaultMessageStore.java](https://codecov.io/gh/apache/rocketmq/pull/2029/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0RlZmF1bHRNZXNzYWdlU3RvcmUuamF2YQ==) | `54.75% <0.00%> (-0.12%)` | `106.00 <0.00> (ø)` | |
   | [.../java/org/apache/rocketmq/common/BrokerConfig.java](https://codecov.io/gh/apache/rocketmq/pull/2029/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vQnJva2VyQ29uZmlnLmphdmE=) | `33.22% <100.00%> (+0.86%)` | `18.00 <2.00> (+2.00)` | |
   | [...pache/rocketmq/store/stats/BrokerStatsManager.java](https://codecov.io/gh/apache/rocketmq/pull/2029/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3N0YXRzL0Jyb2tlclN0YXRzTWFuYWdlci5qYXZh) | `74.10% <100.00%> (+40.77%)` | `18.00 <2.00> (+15.00)` | |
   | [...ketmq/client/impl/consumer/PullMessageService.java](https://codecov.io/gh/apache/rocketmq/pull/2029/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9QdWxsTWVzc2FnZVNlcnZpY2UuamF2YQ==) | `71.11% <0.00%> (-4.45%)` | `8.00% <0.00%> (-1.00%)` | |
   | [...pl/consumer/ConsumeMessageConcurrentlyService.java](https://codecov.io/gh/apache/rocketmq/pull/2029/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZUNvbmN1cnJlbnRseVNlcnZpY2UuamF2YQ==) | `42.71% <0.00%> (-0.98%)` | `10.00% <0.00%> (ø%)` | |
   | ... and [16 more](https://codecov.io/gh/apache/rocketmq/pull/2029/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2029?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2029?src=pr&el=footer). Last update [4a9f7a8...e3a0a31](https://codecov.io/gh/apache/rocketmq/pull/2029?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org