You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/08 08:39:44 UTC
[GitHub] [incubator-nuttx] donghengqaz opened a new pull request #2999: xtensa/esp32: Add WPA2 Enterprise and WPA3 support
donghengqaz opened a new pull request #2999:
URL: https://github.com/apache/incubator-nuttx/pull/2999
## Summary
Add WPA2 Enterprise and WPA3 support.
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #2999: xtensa/esp32: Add WPA2 Enterprise and WPA3 support
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #2999:
URL: https://github.com/apache/incubator-nuttx/pull/2999#issuecomment-793223901
how is timeout uint64_t change related to "WPA2 Enterprise and WPA3"? just a curious question.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2999: xtensa/esp32: Add WPA2 Enterprise and WPA3 support
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #2999:
URL: https://github.com/apache/incubator-nuttx/pull/2999#discussion_r589412903
##########
File path: arch/xtensa/src/esp32/esp32_wifi_adapter.c
##########
@@ -4201,8 +4199,6 @@ int32_t esp_timer_start_periodic(esp_timer_handle_t timer, uint64_t period)
{
struct rt_timer_s *rt_timer = (struct rt_timer_s *)timer;
- DEBUGASSERT(period <= UINT32_MAX);
Review comment:
Shouldn't be replaced with UINT64_MAX ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] donghengqaz commented on a change in pull request #2999: xtensa/esp32: Add WPA2 Enterprise and WPA3 support
Posted by GitBox <gi...@apache.org>.
donghengqaz commented on a change in pull request #2999:
URL: https://github.com/apache/incubator-nuttx/pull/2999#discussion_r590023632
##########
File path: arch/xtensa/src/esp32/esp32_wifi_adapter.c
##########
@@ -4201,8 +4199,6 @@ int32_t esp_timer_start_periodic(esp_timer_handle_t timer, uint64_t period)
{
struct rt_timer_s *rt_timer = (struct rt_timer_s *)timer;
- DEBUGASSERT(period <= UINT32_MAX);
Review comment:
period must be <= UINT64_MAX.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #2999: xtensa/esp32: Add WPA2 Enterprise and WPA3 support
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #2999:
URL: https://github.com/apache/incubator-nuttx/pull/2999#discussion_r589860481
##########
File path: arch/xtensa/src/esp32/esp32_wifi_adapter.c
##########
@@ -4201,8 +4199,6 @@ int32_t esp_timer_start_periodic(esp_timer_handle_t timer, uint64_t period)
{
struct rt_timer_s *rt_timer = (struct rt_timer_s *)timer;
- DEBUGASSERT(period <= UINT32_MAX);
Review comment:
@acassis isn't it always true for a uint64_t value?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #2999: xtensa/esp32: Add WPA2 Enterprise and WPA3 support
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #2999:
URL: https://github.com/apache/incubator-nuttx/pull/2999
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2999: xtensa/esp32: Add WPA2 Enterprise and WPA3 support
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #2999:
URL: https://github.com/apache/incubator-nuttx/pull/2999#discussion_r590409605
##########
File path: arch/xtensa/src/esp32/esp32_wifi_adapter.c
##########
@@ -4201,8 +4199,6 @@ int32_t esp_timer_start_periodic(esp_timer_handle_t timer, uint64_t period)
{
struct rt_timer_s *rt_timer = (struct rt_timer_s *)timer;
- DEBUGASSERT(period <= UINT32_MAX);
Review comment:
Yes, you are right, I missed that period is a uint64_t.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] donghengqaz commented on pull request #2999: xtensa/esp32: Add WPA2 Enterprise and WPA3 support
Posted by GitBox <gi...@apache.org>.
donghengqaz commented on pull request #2999:
URL: https://github.com/apache/incubator-nuttx/pull/2999#issuecomment-793488435
> how is timeout uint64_t change related to "WPA2 Enterprise and WPA3"? just a curious question.
Because the WPA supplicant for WPA3 will create a timer and its timeout time is after 100 days = 0x7DB A821 8000 us.
I have adviced my company's WiFi team to think out using OS timer not real-time timer, but it needs some time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org