You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "chelseajonesr (via GitHub)" <gi...@apache.org> on 2023/07/20 19:32:53 UTC
[GitHub] [arrow] chelseajonesr opened a new pull request, #36794: GH-36793: [GO] Allow NewSchemaFromStruct to skip fields if tagged with parquet:"-"
chelseajonesr opened a new pull request, #36794:
URL: https://github.com/apache/arrow/pull/36794
### Rationale for this change
Allow skipping Go struct fields when serializing to Parquet by using a tag `parquet:"-"`, similarly to the standard Go JSON implementation.
### What changes are included in this PR?
Add `Exclude` to the taggedInfo struct, which is used by `typeToNode` to skip the associated struct field.
### Are these changes tested?
Yes, I modified an existing test to add a new excluded field. (I'm also using this change locally to read and write parquet files with existing Go structs.)
### Are there any user-facing changes?
Yes, this modifies usage of the `parquet` tag. I couldn't find any relevant documentation that needs to be updated though; if there is any please let me know and I will do so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36794: GH-36793: [GO] Allow NewSchemaFromStruct to skip fields if tagged with parquet:"-"
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36794:
URL: https://github.com/apache/arrow/pull/36794#issuecomment-1644485039
:warning: GitHub issue #36793 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36794: GH-36793: [Go] Allow NewSchemaFromStruct to skip fields if tagged with parquet:"-"
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36794:
URL: https://github.com/apache/arrow/pull/36794#issuecomment-1657297392
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 6695d18eb2d7b8eada68e80f0fb030c12b70aabb.
There was 1 benchmark result indicating a performance regression:
- Commit Run on `ursa-i9-9960x` at [2023-07-30 21:01:48Z](http://conbench.ursa.dev/compare/runs/b858bc64b996496393a7f8a6c273c21f...95cde444d41b477b98f22e3cd34fa4a7/)
- [engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-07, scale_factor=1](http://conbench.ursa.dev/compare/benchmarks/064c6be18ebf7faf8000b8659ec23612...064c6e9c7c5e76df8000711dbf2bcf2d)
The [full Conbench report](https://github.com/apache/arrow/runs/15467227960) has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade merged pull request #36794: GH-36793: [Go] Allow NewSchemaFromStruct to skip fields if tagged with parquet:"-"
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #36794:
URL: https://github.com/apache/arrow/pull/36794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org