You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2023/01/18 09:21:41 UTC
[GitHub] [hive] SourabhBadhya opened a new pull request, #3964: HIVE-26955: Alter table fails when decimal column data type is change…
SourabhBadhya opened a new pull request, #3964:
URL: https://github.com/apache/hive/pull/3964
…d to string/char/varchar in Parquet
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Alter table fails when decimal column data type is changed to string/char/varchar in Parquet
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To fix the failure induced by alter table when decimal column data type is changed to string/char/varchar in Parquet.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
QTest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] SourabhBadhya commented on a diff in pull request #3964: HIVE-26955: Select query fails when decimal column data type is change…
Posted by GitBox <gi...@apache.org>.
SourabhBadhya commented on code in PR #3964:
URL: https://github.com/apache/hive/pull/3964#discussion_r1073502143
##########
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/ETypeConverter.java:
##########
@@ -676,6 +676,39 @@ private int getScale(PrimitiveType type) {
return logicalType.getScale();
}
};
+ case serdeConstants.VARCHAR_TYPE_NAME:
+ return new BinaryConverter<HiveVarcharWritable>(type, parent, index, hiveTypeInfo) {
+ @Override
+ protected HiveVarcharWritable convert(Binary binary) {
+ DecimalLogicalTypeAnnotation logicalType = (DecimalLogicalTypeAnnotation) type.getLogicalTypeAnnotation();
+ HiveDecimalWritable decimalWritable = HiveDecimalUtils.enforcePrecisionScale(
+ new HiveDecimalWritable(binary.getBytes(), logicalType.getScale()),
+ new DecimalTypeInfo(logicalType.getPrecision(), logicalType.getScale()));
Review Comment:
Nice way to refactor @kasakrisz . Implemented it in a similar way. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #3964: HIVE-26955: Select query fails when decimal column data type is change…
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #3964:
URL: https://github.com/apache/hive/pull/3964#issuecomment-1397005582
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=3964)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3964&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3964&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3964&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3964&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3964&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #3964: HIVE-26955: Select query fails when decimal column data type is change…
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #3964:
URL: https://github.com/apache/hive/pull/3964#issuecomment-1387581260
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=3964)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3964&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3964&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3964&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3964&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3964&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #3964: HIVE-26955: Select query fails when decimal column data type is change…
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #3964:
URL: https://github.com/apache/hive/pull/3964#issuecomment-1386861732
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=3964)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3964&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3964&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3964&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3964&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3964&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] soumyakanti3578 commented on a diff in pull request #3964: HIVE-26955: Select query fails when decimal column data type is change…
Posted by GitBox <gi...@apache.org>.
soumyakanti3578 commented on code in PR #3964:
URL: https://github.com/apache/hive/pull/3964#discussion_r1081802849
##########
ql/src/test/queries/clientpositive/parquet_alter_column_type.q:
##########
@@ -0,0 +1,122 @@
+create table test_parquet_1 (id decimal) stored as parquet;
+insert into test_parquet_1 values (238), (238.12), (-0.123);
+alter table test_parquet_1 change id id string;
+select * from test_parquet_1;
+
+create table test_parquet_2 (id decimal(10,2)) stored as parquet;
+insert into test_parquet_2 values (238), (238.12), (-0.123);
+alter table test_parquet_2 change id id string;
+select * from test_parquet_2;
+
+create table test_parquet_3 (id decimal(4,2)) stored as parquet;
+insert into test_parquet_3 values (238), (238.12), (-0.123);
+alter table test_parquet_3 change id id string;
+select * from test_parquet_3;
+
+create table test_parquet_4 (id decimal(11,5)) stored as parquet;
+insert into test_parquet_4 values (238), (238.12), (-0.123456789);
+alter table test_parquet_4 change id id string;
+select * from test_parquet_4;
+
+create table test_parquet_5 (id decimal(10,2)) stored as parquet;
+insert into test_parquet_5 values (238), (238.12), (-0.123);
+alter table test_parquet_5 change id id string;
+select * from test_parquet_5;
+
+create table test_parquet_6 (id decimal(38,18)) stored as parquet;
+insert into test_parquet_6 values (-12345678901234567890.098765432109876543), (12345678901234567890.098765432109876543), (124567.678950), (0987678904789.567849028679576658);
+alter table test_parquet_6 change id id string;
+select * from test_parquet_6;
+
+drop table test_parquet_1;
+drop table test_parquet_2;
+drop table test_parquet_3;
+drop table test_parquet_4;
+drop table test_parquet_5;
+drop table test_parquet_6;
+
+create table test_parquet_1 (id decimal) stored as parquet;
+insert into test_parquet_1 values (238), (238.12), (-0.123);
+alter table test_parquet_1 change id id varchar(255);
+select * from test_parquet_1;
+
+create table test_parquet_2 (id decimal(10,2)) stored as parquet;
+insert into test_parquet_2 values (238), (238.12), (-0.123);
+alter table test_parquet_2 change id id varchar(255);
+select * from test_parquet_2;
+
+create table test_parquet_3 (id decimal(4,2)) stored as parquet;
+insert into test_parquet_3 values (238), (238.12), (-0.123);
+alter table test_parquet_3 change id id varchar(255);
+select * from test_parquet_3;
+
+create table test_parquet_4 (id decimal(11,5)) stored as parquet;
+insert into test_parquet_4 values (238), (238.12), (-0.123456789);
+alter table test_parquet_4 change id id varchar(255);
+select * from test_parquet_4;
+
+create table test_parquet_5 (id decimal(10,2)) stored as parquet;
+insert into test_parquet_5 values (238), (238.12), (-0.123);
+alter table test_parquet_5 change id id varchar(255);
+select * from test_parquet_5;
+
+create table test_parquet_6 (id decimal(38,18)) stored as parquet;
+insert into test_parquet_6 values (-12345678901234567890.098765432109876543), (12345678901234567890.098765432109876543), (124567.678950), (0987678904789.567849028679576658);
+alter table test_parquet_6 change id id varchar(255);
+select * from test_parquet_6;
+
+create table test_parquet_7 (id decimal(38,18)) stored as parquet;
+insert into test_parquet_7 values (-12345678901234567890.098765432109876543), (12345678901234567890.098765432109876543), (124567.678950), (0987678904789.567849028679576658);
+alter table test_parquet_7 change id id varchar(8);
+select * from test_parquet_7;
+
+drop table test_parquet_1;
+drop table test_parquet_2;
+drop table test_parquet_3;
+drop table test_parquet_4;
+drop table test_parquet_5;
+drop table test_parquet_6;
+drop table test_parquet_7;
+
+create table test_parquet_1 (id decimal) stored as parquet;
+insert into test_parquet_1 values (238), (238.12), (-0.123);
+alter table test_parquet_1 change id id char(255);
+select * from test_parquet_1;
+
+create table test_parquet_2 (id decimal(10,2)) stored as parquet;
+insert into test_parquet_2 values (238), (238.12), (-0.123);
+alter table test_parquet_2 change id id char(255);
+select * from test_parquet_2;
+
+create table test_parquet_3 (id decimal(4,2)) stored as parquet;
+insert into test_parquet_3 values (238), (238.12), (-0.123);
+alter table test_parquet_3 change id id char(255);
+select * from test_parquet_3;
+
+create table test_parquet_4 (id decimal(11,5)) stored as parquet;
+insert into test_parquet_4 values (238), (238.12), (-0.123456789);
+alter table test_parquet_4 change id id char(255);
+select * from test_parquet_4;
+
+create table test_parquet_5 (id decimal(10,2)) stored as parquet;
+insert into test_parquet_5 values (238), (238.12), (-0.123);
+alter table test_parquet_5 change id id char(255);
+select * from test_parquet_5;
+
+create table test_parquet_6 (id decimal(38,18)) stored as parquet;
+insert into test_parquet_6 values (-12345678901234567890.098765432109876543), (12345678901234567890.098765432109876543), (124567.678950), (0987678904789.567849028679576658);
+alter table test_parquet_6 change id id char(255);
+select * from test_parquet_6;
+
+create table test_parquet_7 (id decimal(38,18)) stored as parquet;
+insert into test_parquet_7 values (-12345678901234567890.098765432109876543), (12345678901234567890.098765432109876543), (124567.678950), (0987678904789.567849028679576658);
+alter table test_parquet_7 change id id char(8);
+select * from test_parquet_7;
+
+drop table test_parquet_1;
+drop table test_parquet_2;
+drop table test_parquet_3;
+drop table test_parquet_4;
+drop table test_parquet_5;
+drop table test_parquet_6;
+drop table test_parquet_7;
Review Comment:
Minor nit - Ideally there should be a new line at the end of the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kasakrisz merged pull request #3964: HIVE-26955: Select query fails when decimal column data type is change…
Posted by GitBox <gi...@apache.org>.
kasakrisz merged PR #3964:
URL: https://github.com/apache/hive/pull/3964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kasakrisz commented on a diff in pull request #3964: HIVE-26955: Select query fails when decimal column data type is change…
Posted by GitBox <gi...@apache.org>.
kasakrisz commented on code in PR #3964:
URL: https://github.com/apache/hive/pull/3964#discussion_r1073368036
##########
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/ETypeConverter.java:
##########
@@ -676,6 +676,39 @@ private int getScale(PrimitiveType type) {
return logicalType.getScale();
}
};
+ case serdeConstants.VARCHAR_TYPE_NAME:
+ return new BinaryConverter<HiveVarcharWritable>(type, parent, index, hiveTypeInfo) {
+ @Override
+ protected HiveVarcharWritable convert(Binary binary) {
+ DecimalLogicalTypeAnnotation logicalType = (DecimalLogicalTypeAnnotation) type.getLogicalTypeAnnotation();
+ HiveDecimalWritable decimalWritable = HiveDecimalUtils.enforcePrecisionScale(
+ new HiveDecimalWritable(binary.getBytes(), logicalType.getScale()),
+ new DecimalTypeInfo(logicalType.getPrecision(), logicalType.getScale()));
Review Comment:
These 4 lines are the same in all the new cases. Could you please extract it?
Exmaple
```
abstract class BinaryConverterToCharacterType<T extends Writable> extends BinaryConverter<T> {
protected byte[] convertToBytes(Binary binary) {
DecimalLogicalTypeAnnotation logicalType = (DecimalLogicalTypeAnnotation) type.getLogicalTypeAnnotation();
return HiveDecimalUtils.enforcePrecisionScale(
new HiveDecimalWritable(binary.getBytes(), logicalType.getScale()),
new DecimalTypeInfo(logicalType.getPrecision(), logicalType.getScale())).toString().getBytes();
}
protected abstract T convert(Binary binary);
}
```
and extend it and call `convertToBytes` in `convert`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #3964: HIVE-26955: Select query fails when decimal column data type is change…
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #3964:
URL: https://github.com/apache/hive/pull/3964#issuecomment-1397898038
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=3964)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3964&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3964&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3964&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3964&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3964&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3964&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] SourabhBadhya commented on a diff in pull request #3964: HIVE-26955: Select query fails when decimal column data type is change…
Posted by GitBox <gi...@apache.org>.
SourabhBadhya commented on code in PR #3964:
URL: https://github.com/apache/hive/pull/3964#discussion_r1082076397
##########
ql/src/test/queries/clientpositive/parquet_alter_column_type.q:
##########
@@ -0,0 +1,122 @@
+create table test_parquet_1 (id decimal) stored as parquet;
+insert into test_parquet_1 values (238), (238.12), (-0.123);
+alter table test_parquet_1 change id id string;
+select * from test_parquet_1;
+
+create table test_parquet_2 (id decimal(10,2)) stored as parquet;
+insert into test_parquet_2 values (238), (238.12), (-0.123);
+alter table test_parquet_2 change id id string;
+select * from test_parquet_2;
+
+create table test_parquet_3 (id decimal(4,2)) stored as parquet;
+insert into test_parquet_3 values (238), (238.12), (-0.123);
+alter table test_parquet_3 change id id string;
+select * from test_parquet_3;
+
+create table test_parquet_4 (id decimal(11,5)) stored as parquet;
+insert into test_parquet_4 values (238), (238.12), (-0.123456789);
+alter table test_parquet_4 change id id string;
+select * from test_parquet_4;
+
+create table test_parquet_5 (id decimal(10,2)) stored as parquet;
+insert into test_parquet_5 values (238), (238.12), (-0.123);
+alter table test_parquet_5 change id id string;
+select * from test_parquet_5;
+
+create table test_parquet_6 (id decimal(38,18)) stored as parquet;
+insert into test_parquet_6 values (-12345678901234567890.098765432109876543), (12345678901234567890.098765432109876543), (124567.678950), (0987678904789.567849028679576658);
+alter table test_parquet_6 change id id string;
+select * from test_parquet_6;
+
+drop table test_parquet_1;
+drop table test_parquet_2;
+drop table test_parquet_3;
+drop table test_parquet_4;
+drop table test_parquet_5;
+drop table test_parquet_6;
+
+create table test_parquet_1 (id decimal) stored as parquet;
+insert into test_parquet_1 values (238), (238.12), (-0.123);
+alter table test_parquet_1 change id id varchar(255);
+select * from test_parquet_1;
+
+create table test_parquet_2 (id decimal(10,2)) stored as parquet;
+insert into test_parquet_2 values (238), (238.12), (-0.123);
+alter table test_parquet_2 change id id varchar(255);
+select * from test_parquet_2;
+
+create table test_parquet_3 (id decimal(4,2)) stored as parquet;
+insert into test_parquet_3 values (238), (238.12), (-0.123);
+alter table test_parquet_3 change id id varchar(255);
+select * from test_parquet_3;
+
+create table test_parquet_4 (id decimal(11,5)) stored as parquet;
+insert into test_parquet_4 values (238), (238.12), (-0.123456789);
+alter table test_parquet_4 change id id varchar(255);
+select * from test_parquet_4;
+
+create table test_parquet_5 (id decimal(10,2)) stored as parquet;
+insert into test_parquet_5 values (238), (238.12), (-0.123);
+alter table test_parquet_5 change id id varchar(255);
+select * from test_parquet_5;
+
+create table test_parquet_6 (id decimal(38,18)) stored as parquet;
+insert into test_parquet_6 values (-12345678901234567890.098765432109876543), (12345678901234567890.098765432109876543), (124567.678950), (0987678904789.567849028679576658);
+alter table test_parquet_6 change id id varchar(255);
+select * from test_parquet_6;
+
+create table test_parquet_7 (id decimal(38,18)) stored as parquet;
+insert into test_parquet_7 values (-12345678901234567890.098765432109876543), (12345678901234567890.098765432109876543), (124567.678950), (0987678904789.567849028679576658);
+alter table test_parquet_7 change id id varchar(8);
+select * from test_parquet_7;
+
+drop table test_parquet_1;
+drop table test_parquet_2;
+drop table test_parquet_3;
+drop table test_parquet_4;
+drop table test_parquet_5;
+drop table test_parquet_6;
+drop table test_parquet_7;
+
+create table test_parquet_1 (id decimal) stored as parquet;
+insert into test_parquet_1 values (238), (238.12), (-0.123);
+alter table test_parquet_1 change id id char(255);
+select * from test_parquet_1;
+
+create table test_parquet_2 (id decimal(10,2)) stored as parquet;
+insert into test_parquet_2 values (238), (238.12), (-0.123);
+alter table test_parquet_2 change id id char(255);
+select * from test_parquet_2;
+
+create table test_parquet_3 (id decimal(4,2)) stored as parquet;
+insert into test_parquet_3 values (238), (238.12), (-0.123);
+alter table test_parquet_3 change id id char(255);
+select * from test_parquet_3;
+
+create table test_parquet_4 (id decimal(11,5)) stored as parquet;
+insert into test_parquet_4 values (238), (238.12), (-0.123456789);
+alter table test_parquet_4 change id id char(255);
+select * from test_parquet_4;
+
+create table test_parquet_5 (id decimal(10,2)) stored as parquet;
+insert into test_parquet_5 values (238), (238.12), (-0.123);
+alter table test_parquet_5 change id id char(255);
+select * from test_parquet_5;
+
+create table test_parquet_6 (id decimal(38,18)) stored as parquet;
+insert into test_parquet_6 values (-12345678901234567890.098765432109876543), (12345678901234567890.098765432109876543), (124567.678950), (0987678904789.567849028679576658);
+alter table test_parquet_6 change id id char(255);
+select * from test_parquet_6;
+
+create table test_parquet_7 (id decimal(38,18)) stored as parquet;
+insert into test_parquet_7 values (-12345678901234567890.098765432109876543), (12345678901234567890.098765432109876543), (124567.678950), (0987678904789.567849028679576658);
+alter table test_parquet_7 change id id char(8);
+select * from test_parquet_7;
+
+drop table test_parquet_1;
+drop table test_parquet_2;
+drop table test_parquet_3;
+drop table test_parquet_4;
+drop table test_parquet_5;
+drop table test_parquet_6;
+drop table test_parquet_7;
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org