You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "krishvishal (via GitHub)" <gi...@apache.org> on 2026/09/15 07:30:22 UTC
[PR] feat(simulator): separate a vacuous run and assert through the drain [iggy]
krishvishal opened a new pull request, #4191:
URL: https://github.com/apache/iggy/pull/4191
A campaign cannot triage a failure list where a third of the entries are runs that committed nothing. The five vacuity floors all answer the same question, whether the run proved anything at all, and each answered it by panicking, which exits 101 exactly like a real divergence. They exit 3 under a `vacuous:` line now, so a sweep can report yield apart from its failure rate. The hard asserts are untouched.
The drain and the view settle each step up to 50,000 ticks with nothing asserted, so a wedge forming after the active phase surfaced as nothing more than "did not drain". Both loops assert every tick now. The checker is caller-owned for that reason: a fresh one in the drain starts with an empty commit chain, which is the memory that names a divergence.
Metadata swarm lane, seeds 1..=300: 298 pass and 2 fail before, 297 pass, 1 vacuous and 2 fail after. Seed 210 committed no metadata op at all. Seed 90 is a real wedge the drain was hiding, a Normal primary held at barrier=5 over commit 4..4 for 2000 ticks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(simulator): separate a vacuous run and assert through the drain [iggy]
Posted by "numinnex (via GitHub)" <gi...@apache.org>.
numinnex commented on PR #4191:
URL: https://github.com/apache/iggy/pull/4191#issuecomment-5726105513
/dst
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(simulator): separate a vacuous run and assert through the drain [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4191:
URL: https://github.com/apache/iggy/pull/4191#issuecomment-5676715481
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/4191?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `20.49180%` with `97 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 30.40%. Comparing base ([`9061596`](https://app.codecov.io/gh/apache/iggy/commit/90615962cbf058959c52bada7931411c328272e0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c4c9794`](https://app.codecov.io/gh/apache/iggy/commit/c4c9794ba9b3ed2e37bb7a43321dc06271144edd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/4191?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [core/simulator/src/lib.rs](https://app.codecov.io/gh/apache/iggy/pull/4191?src=pr&el=tree&filepath=core%2Fsimulator%2Fsrc%2Flib.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zaW11bGF0b3Ivc3JjL2xpYi5ycw==) | 22.58% | [48 Missing :warning: ](https://app.codecov.io/gh/apache/iggy/pull/4191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [core/simulator/src/bin/workload-fuzz.rs](https://app.codecov.io/gh/apache/iggy/pull/4191?src=pr&el=tree&filepath=core%2Fsimulator%2Fsrc%2Fbin%2Fworkload-fuzz.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zaW11bGF0b3Ivc3JjL2Jpbi93b3JrbG9hZC1mdXp6LnJz) | 0.00% | [36 Missing :warning: ](https://app.codecov.io/gh/apache/iggy/pull/4191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [core/simulator/src/workload/oracle.rs](https://app.codecov.io/gh/apache/iggy/pull/4191?src=pr&el=tree&filepath=core%2Fsimulator%2Fsrc%2Fworkload%2Foracle.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zaW11bGF0b3Ivc3JjL3dvcmtsb2FkL29yYWNsZS5ycw==) | 53.33% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/iggy/pull/4191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [core/simulator/src/workload/mod.rs](https://app.codecov.io/gh/apache/iggy/pull/4191?src=pr&el=tree&filepath=core%2Fsimulator%2Fsrc%2Fworkload%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zaW11bGF0b3Ivc3JjL3dvcmtsb2FkL21vZC5ycw==) | 33.33% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/iggy/pull/4191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
:x: Your patch check has failed because the patch coverage (20.49%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the [target](https://docs.codecov.com/docs/commit-status#target) coverage.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4191 +/- ##
=============================================
- Coverage 87.42% 30.40% -57.03%
Complexity 1575 1575
=============================================
Files 1280 1277 -3
Lines 222704 180305 -42399
Branches 186067 143668 -42399
=============================================
- Hits 194706 54827 -139879
- Misses 23287 123756 +100469
+ Partials 4711 1722 -2989
```
| [Components](https://app.codecov.io/gh/apache/iggy/pull/4191/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [Rust Core](https://app.codecov.io/gh/apache/iggy/pull/4191/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `15.98% <20.49%> (-72.52%)` | :arrow_down: |
| [Java SDK](https://app.codecov.io/gh/apache/iggy/pull/4191/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `68.68% <ø> (ø)` | |
| [C# SDK](https://app.codecov.io/gh/apache/iggy/pull/4191/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.42% <ø> (ø)` | |
| [Python SDK](https://app.codecov.io/gh/apache/iggy/pull/4191/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.97% <ø> (ø)` | |
| [PHP SDK](https://app.codecov.io/gh/apache/iggy/pull/4191/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `85.67% <ø> (ø)` | |
| [Node SDK](https://app.codecov.io/gh/apache/iggy/pull/4191/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.43% <ø> (ø)` | |
| [Go SDK](https://app.codecov.io/gh/apache/iggy/pull/4191/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.08% <ø> (ø)` | |
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/4191?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [core/simulator/src/workload/mod.rs](https://app.codecov.io/gh/apache/iggy/pull/4191?src=pr&el=tree&filepath=core%2Fsimulator%2Fsrc%2Fworkload%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zaW11bGF0b3Ivc3JjL3dvcmtsb2FkL21vZC5ycw==) | `57.05% <33.33%> (-34.08%)` | :arrow_down: |
| [core/simulator/src/workload/oracle.rs](https://app.codecov.io/gh/apache/iggy/pull/4191?src=pr&el=tree&filepath=core%2Fsimulator%2Fsrc%2Fworkload%2Foracle.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zaW11bGF0b3Ivc3JjL3dvcmtsb2FkL29yYWNsZS5ycw==) | `48.57% <53.33%> (-17.80%)` | :arrow_down: |
| [core/simulator/src/bin/workload-fuzz.rs](https://app.codecov.io/gh/apache/iggy/pull/4191?src=pr&el=tree&filepath=core%2Fsimulator%2Fsrc%2Fbin%2Fworkload-fuzz.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zaW11bGF0b3Ivc3JjL2Jpbi93b3JrbG9hZC1mdXp6LnJz) | `0.00% <0.00%> (ø)` | |
| [core/simulator/src/lib.rs](https://app.codecov.io/gh/apache/iggy/pull/4191?src=pr&el=tree&filepath=core%2Fsimulator%2Fsrc%2Flib.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zaW11bGF0b3Ivc3JjL2xpYi5ycw==) | `40.66% <22.58%> (-55.38%)` | :arrow_down: |
... and [662 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/4191/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(simulator): separate a vacuous run and assert through the drain [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio merged PR #4191:
URL: https://github.com/apache/iggy/pull/4191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org