You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tapestry.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/04/04 16:57:00 UTC

[jira] [Commented] (TAP5-2716) Missing dependency for Google Closure Compiler

    [ https://issues.apache.org/jira/browse/TAP5-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17516950#comment-17516950 ] 

ASF subversion and git services commented on TAP5-2716:
-------------------------------------------------------

Commit d069a3258d413c222b7b4b52ea284daa89ae7b90 in tapestry-5's branch refs/heads/master from Ben Weidig
[ https://gitbox.apache.org/repos/asf?p=tapestry-5.git;h=d069a3258 ]

TAP5-2716: Google Closure Compiler dependency required for webresources

The org.apache.tapestry5.webresources.GoogleClosureMinimizerOptionsProvider was added in 5.7 and requires the dependency if it's overriden, so the dependency needs to be 'api' instead of 'implementation'.

> Missing dependency for Google Closure Compiler
> ----------------------------------------------
>
>                 Key: TAP5-2716
>                 URL: https://issues.apache.org/jira/browse/TAP5-2716
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-webresources
>    Affects Versions: 5.8.1
>            Reporter: Ben Weidig
>            Assignee: Ben Weidig
>            Priority: Major
>
> Commit [https://github.com/apache/tapestry-5/commit/17d58c3956eee98f7684bb803d19f19b74bb22b5] made multiple dependencies "implementation" which were "compile" before.
> The org.apache.tapestry5.webresources.GoogleClosureMinimizerOptionsProvider requires com.google.javascript:closure-compiler-unshaded:v20200504 though, so if the default one is overriden the dependency is missing
> Issue for Options Provider was TAP5-2661



--
This message was sent by Atlassian Jira
(v8.20.1#820001)