[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #6879: Improve Superset logger

[GitBox <gi...@apache.org>]

graceguo-supercat commented on a change in pull request #6879: Improve Superset logger
URL: https://github.com/apache/incubator-superset/pull/6879#discussion_r271079604
 
 

 ##########
 File path: superset/assets/src/chart/ChartRenderer.jsx
 ##########
 @@ -69,18 +70,23 @@ class ChartRenderer extends React.Component {
   }
 
   shouldComponentUpdate(nextProps) {
-    if (
+    const resultsReady =
       nextProps.queryResponse &&
       ['success', 'rendered'].indexOf(nextProps.chartStatus) > -1 &&
       !nextProps.queryResponse.error &&
-      !nextProps.refreshOverlayVisible &&
-      (nextProps.annotationData !== this.props.annotationData ||
-        nextProps.queryResponse !== this.props.queryResponse ||
+      !nextProps.refreshOverlayVisible;
+
+    if (resultsReady) {
+      this.hasQueryResponseChnage =
 
 Review comment:
   sorry i just saw your comment  😓. fixed here: https://github.com/apache/incubator-superset/pull/7197

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org