[GitHub] [geode] bschuchardt opened pull request #4037: GEODE-7175 Convert toData/fromData in other modules to use new serial…

["bschuchardt (GitHub)" <gi...@apache.org>]

…izers

use the serialization context's readObject/writeObject methods instead
of the static methods in DataSerializer.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [x] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/4037 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] bschuchardt commented on issue #4037: GEODE-7175 Convert toData/fromData in other modules to use new serial…

["bschuchardt (GitHub)" <gi...@apache.org>]

@Bill 

[ Full content available at: https://github.com/apache/geode/pull/4037 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] Bill commented on pull request #4037: GEODE-7175 Convert toData/fromData in other modules to use new serial…

["Bill (GitHub)" <gi...@apache.org>]

Cast of return type of `readObject()` is superfluous. There are many, many of these.

This PR didn't introduce these superfluous casts. But many of the green (changed) lines have them.

[ Full content available at: https://github.com/apache/geode/pull/4037 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] bschuchardt closed pull request #4037: GEODE-7175 Convert toData/fromData in other modules to use new serial…

["bschuchardt (GitHub)" <gi...@apache.org>]

[ pull request closed by bschuchardt ]

[ Full content available at: https://github.com/apache/geode/pull/4037 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] Bill commented on pull request #4037: GEODE-7175 Convert toData/fromData in other modules to use new serial…

["Bill (GitHub)" <gi...@apache.org>]

missed one (also, no cast needed here)

[ Full content available at: https://github.com/apache/geode/pull/4037 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org