[GitHub] [kafka] philipnee commented on pull request #13265: Prototype consumer stubs

["philipnee (via GitHub)" <gi...@apache.org>]

philipnee commented on PR #13265:
URL: https://github.com/apache/kafka/pull/13265#issuecomment-1440786040

   I feel the real challenge here is to determine the timing to synchronize the background and client state. I feel we should do that deterministically otherwise, it is hard to provide a contract to the user. Anyways here are a few of my notes:
   
   1. What should the user expect: I think these are a few scenarios
    - `subscribe()` -> `subscriptions()`
    - `assign()` -> `assignments()`
    - `seek()` -> `position()`
    - `seek()` -> poll() (something returned) -> `position()`
   2. Do we all agree to only drain the queue in `poll()` ? There are a few things to consider
    - When and where to throw the CommitFailureException() (I think now it can happen everywhere when user invoke APIs)
    - When and where to invoke the callbacks (commit and rebalance)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org