You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tez.apache.org by rb...@apache.org on 2014/09/12 00:28:46 UTC
[2/2] git commit: TEZ-1543. Shuffle Errors on heavy load (causing
task retries) (Rajesh Balamohan)
TEZ-1543. Shuffle Errors on heavy load (causing task retries) (Rajesh Balamohan)
Project: http://git-wip-us.apache.org/repos/asf/tez/repo
Commit: http://git-wip-us.apache.org/repos/asf/tez/commit/bf6ac4e7
Tree: http://git-wip-us.apache.org/repos/asf/tez/tree/bf6ac4e7
Diff: http://git-wip-us.apache.org/repos/asf/tez/diff/bf6ac4e7
Branch: refs/heads/master
Commit: bf6ac4e7811c2ea5a327cac7d8a109e3c57fd8e7
Parents: 80b5795
Author: Rajesh Balamohan <rb...@apache.org>
Authored: Fri Sep 12 03:57:40 2014 +0530
Committer: Rajesh Balamohan <rb...@apache.org>
Committed: Fri Sep 12 03:57:40 2014 +0530
----------------------------------------------------------------------
.../tez/runtime/library/shuffle/common/HttpConnection.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tez/blob/bf6ac4e7/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/shuffle/common/HttpConnection.java
----------------------------------------------------------------------
diff --git a/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/shuffle/common/HttpConnection.java b/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/shuffle/common/HttpConnection.java
index 7208c16..d664f88 100644
--- a/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/shuffle/common/HttpConnection.java
+++ b/tez-runtime-library/src/main/java/org/apache/tez/runtime/library/shuffle/common/HttpConnection.java
@@ -160,7 +160,7 @@ public class HttpConnection {
break;
} catch (IOException ioe) {
// Don't attempt another connect if already cleanedup.
- if (!cleanup) {
+ if (cleanup) {
LOG.info("Cleanup is set to true. Not attempting to"
+ " connect again. Last exception was: ["
+ ioe.getClass().getName() + ", " + ioe.getMessage() + "]");
@@ -170,7 +170,7 @@ public class HttpConnection {
connectionTimeout -= unit;
// throw an exception if we have waited for timeout amount of time
// note that the updated value if timeout is used here
- if (connectionTimeout == 0) {
+ if (connectionTimeout <= 0) {
throw ioe;
}
// reset the connect timeout for the last try