[GitHub] [helix] pkuwm commented on a change in pull request #1237: Add error message of instance check to stoppable API response

[GitBox <gi...@apache.org>]

pkuwm commented on a change in pull request #1237:
URL: https://github.com/apache/helix/pull/1237#discussion_r475063102



##########
File path: helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java
##########
@@ -261,7 +261,9 @@ public static boolean isInstanceStable(HelixDataAccessor dataAccessor, String in
       throw new HelixException("Missing cluster config!");
     }
     if (!clusterConfig.isPersistIntermediateAssignment()) {
-      throw new HelixException("isInstanceStable needs persist assignment on!");
+      throw new HelixException(String.format(
+          "Instance stability check needs persist assignment cluster config turned on: %s = true",

Review comment:
       Made it clearer.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org