[GitHub] [accumulo] ctubbsii edited a comment on pull request #1860: Use long instead of int for monitor scan rate (#1858)

[GitBox <gi...@apache.org>]

ctubbsii edited a comment on pull request #1860:
URL: https://github.com/apache/accumulo/pull/1860#issuecomment-756402340


   > @ctubbsii, thanks. There was only the 1 commit, so I didn't think a squash merge was necessary. Did I miss anything?
   
   When you merge from the UI with the default merge button, even with only one commit, GitHub creates a merge commit. That's why we tend to select the squash option from the dropdown, even if there's only 1. :smiley_cat: 
   
   > I have a local merge to the main branch. It was a bit more work, since the monitor is split up. However, when testing it, I find that I'm getting a flat line graph at integer max value. I'm digging through that now. I think it may be some issue with the plotting library used.
   
   Okay, that's fine. If you want to merge and deconflict by not making any changes, that will ensure that the branches are ready for others to merge (as needed) while you work through the issues. Then, you can create a new PR (or new commit) that would apply directly to the main branch later.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org