[incubator-openwhisk] branch master updated: reduce fillInStackTrace expenses due to ArgNormalizer (#3225)

[ra...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

rabbah pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-openwhisk.git


The following commit(s) were added to refs/heads/master by this push:
     new dd4b71c  reduce fillInStackTrace expenses due to ArgNormalizer (#3225)
dd4b71c is described below

commit dd4b71ccff890f9a9da339dd93433afcfcd9e007
Author: Nick Mitchell <st...@users.noreply.github.com>
AuthorDate: Mon Jan 29 20:14:25 2018 -0500

    reduce fillInStackTrace expenses due to ArgNormalizer (#3225)
    
    make DocId constructor public
---
 common/scala/src/main/scala/whisk/core/entity/DocInfo.scala             | 2 +-
 .../src/main/scala/whisk/core/entity/FullyQualifiedEntityName.scala     | 2 +-
 .../src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/common/scala/src/main/scala/whisk/core/entity/DocInfo.scala b/common/scala/src/main/scala/whisk/core/entity/DocInfo.scala
index b6e635a..fa107a6 100644
--- a/common/scala/src/main/scala/whisk/core/entity/DocInfo.scala
+++ b/common/scala/src/main/scala/whisk/core/entity/DocInfo.scala
@@ -37,7 +37,7 @@ import whisk.core.entity.ArgNormalizer.trim
  *
  * @param id the document id, required not null
  */
-protected[core] class DocId private (val id: String) extends AnyVal {
+protected[core] class DocId(val id: String) extends AnyVal {
   def asString = id // to make explicit that this is a string conversion
   protected[core] def asDocInfo = DocInfo(this)
   protected[core] def asDocInfo(rev: DocRevision) = DocInfo(this, rev)
diff --git a/common/scala/src/main/scala/whisk/core/entity/FullyQualifiedEntityName.scala b/common/scala/src/main/scala/whisk/core/entity/FullyQualifiedEntityName.scala
index a78045d..c52af75 100644
--- a/common/scala/src/main/scala/whisk/core/entity/FullyQualifiedEntityName.scala
+++ b/common/scala/src/main/scala/whisk/core/entity/FullyQualifiedEntityName.scala
@@ -48,7 +48,7 @@ protected[core] case class FullyQualifiedEntityName(path: EntityPath, name: Enti
    */
   def add(n: EntityName) = FullyQualifiedEntityName(path.addPath(name), n)
 
-  def toDocId = DocId(qualifiedName)
+  def toDocId = new DocId(qualifiedName)
   def namespace: EntityName = path.root
   def qualifiedNameWithLeadingSlash: String = EntityPath.PATHSEP + qualifiedName
   def asString = path.addPath(name) + version.map("@" + _.toString).getOrElse("")
diff --git a/core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala b/core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala
index 9302f4c..2e9d6b0 100644
--- a/core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala
+++ b/core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala
@@ -159,7 +159,7 @@ protected[actions] trait PrimitiveActions {
     // 2. failing active ack (due to active ack timeout), fall over to db polling
     // 3. timeout on db polling => converts activation to non-blocking (returns activation id only)
     // 4. internal error message
-    val docid = DocId(WhiskEntity.qualifiedName(user.namespace.toPath, activationId))
+    val docid = new DocId(WhiskEntity.qualifiedName(user.namespace.toPath, activationId))
     val (promise, finisher) = ActivationFinisher.props({ () =>
       WhiskActivation.get(activationStore, docid)
     })

-- 
To stop receiving notification emails like this one, please contact
rabbah@apache.org.