RE: Introduction and a proprosal to add new functionality to Struts: Automatichighlighting of errored form elements

[DeRose Jonathan <de...@bah.com>]

Thanks,

  I did not see anything in Bugzilla having to do with styles and
validation errors, but it wasn't an exhaustive look and there is a lot
to look through.

  I was going to submit the enhancement ticket but I did not see a way
to attach any of the patch files to it.  (I see the attach link on
existing bugs, but not on the generate screen.)  Am I supposed to create
the ticket first and then come back and add the patch files?

  I am leaving town for the weekend so I will not be able to get back to
this until Sunday evening, but if anyone wants a preview of what will be
in the Bugzilla ticket, I put a link to the files below.  When I do come
back, I need to create new diff reports (I had originally done them in
PVCS) and submit the ticket.

Documentation + struts.jar
http://64.70.191.174/scm/struts/jrd_struts_html_mod.zip 690k

Documentation
http://64.70.191.174/scm/struts/jrd_struts_html_mod_no_jar.zip 250k

Thanks again, it's really exciting to be a part of this process,
Jonathan

-----Original Message-----
From: David Graham [mailto:dgraham1980@hotmail.com]
Sent: Friday, June 06, 2003 4:52 PM
To: struts-dev@jakarta.apache.org
Subject: RE: Introduction and a proprosal to add new functionality to
Struts: Automatichighlighting of errored form elements


This sounds interesting.  You could create an enhancement ticket and attach
patch files to it for us to review.  I seem to remember this topic coming up
before so you should search bugzilla and the list archives for relevant
posts (we shouldn't offend anyone that already created a patch for this).

David

>I am very open to suggestions, but I do feel this change is a better fit
>incorporated into the tag library as opposed to standing on top of it.
>Inclusion requires signifcantly less code since contol of styles is
>localized to the BaseHandlerTag.  Extending the tags is a lot more code
>(the
>same code has to be repeated in each input-type tag) and more complex
>(styles must be set over and over as attributes are set, rather than making
>one adjustment after everything has been set.  This is further complicated
>due to not having control on the order that attributes get set.)
>
>A quick note, when I wrote 'automatic highlighting of errored form
>elements': it is only automatic if a style has been defined to use.
>Example:
>< html:text property="name" styleClass="valid" errorStyleClass="invalid"
>...
>where 'valid' is the css style class to use normally and 'invalid' would be
>used if there was an error.
>if no errorStyleClass was defined, there would be no highlighting.
>
>-Jonathan
>
>
>-----Original Message-----
>From: James Mitchell [mailto:jmitchell@apache.org]
>Sent: Friday, June 06, 2003 4:14 PM
>To: Struts Developers List
>Subject: Re: Introduction and a proprosal to add new functionality to
>Struts: Automatic highlighting of errored form elements
>
>
>Sounds like a nice 3rd party library.  Are you open to suggestions?  I have
>a few ideas about this myself.
>
>
>--
>James Mitchell
>Software Developer/Struts Evangelist
>http://www.struts-atlanta.org
>770-822-3359
>AIM:jmitchtx
>
>
>----- Original Message -----
>From: "DeRose Jonathan" <de...@bah.com>
>To: "Struts Developers List" <st...@jakarta.apache.org>
>Sent: Friday, June 06, 2003 4:05 PM
>Subject: Introduction and a proprosal to add new functionality to Struts:
>Automatic highlighting of errored form elements
>
>
> > Hello,
> >
> >     I have an idea that I would like to propose to the Struts community
> > involving the HTML tag library; automatic highlighting of errored form
> > elements.  I have used Struts for a couple medium sized projects and
>always
> > extended the tags to get this functionality.  After doing this two or
>three
> > times, I thought it would be great if Struts has this functionality
>built
> > in.
> >
> >      I have gone through all the source and feel confident about the
>changes
> > that would need to be made.  I have prepared documentation describing
>all
>of
> > the details, but I wanted to post this first to introduce myself and my
> > idea.  If you guys would like to hear more, I would love to post my
> > documentation for everyone to look at.
> >
> > Thanks,
> > Jonathan R. DeRose
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: struts-dev-help@jakarta.apache.org
>

_________________________________________________________________
STOP MORE SPAM with the new MSN 8 and get 2 months FREE*
http://join.msn.com/?page=features/junkmail


---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org




---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org