[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #1130: refactor(java-client): optimize the code style of PegasusScanner

[GitBox <gi...@apache.org>]

foreverneverer commented on code in PR #1130:
URL: https://github.com/apache/incubator-pegasus/pull/1130#discussion_r951057447


##########
java-client/src/main/java/org/apache/pegasus/client/ClientOptions.java:
##########
@@ -233,7 +233,6 @@ public int hashCode() {
     result = 31 * result + Objects.hashCode(falconPushInterval.toMillis());
     result = 31 * result + (enableWriteLimit ? 1 : 0);
     result = 31 * result + Objects.hashCode(metaQueryTimeout.toMillis());
-    result = 31 * result + authProtocol.hashCode();

Review Comment:
   `authProtocol` is not existed, I'm confused why ci can pass in https://github.com/apache/incubator-pegasus/pull/1087.
   
   do we update action for java client? @acelyc111 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org