You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/19 02:56:56 UTC
[GitHub] [flink] LadyForest opened a new pull request #14687: [FLINK-17868][table-planner-blink] Fix proctime in DDL can not work in batch mode
LadyForest opened a new pull request #14687:
URL: https://github.com/apache/flink/pull/14687
## What is the purpose of the change
* This pull request tries to fix the issue that `PROCTIME` generates null value in batch mode for the blink planner, by introducing `FlinkRelTimeIndicatorProgram ` to `FlinkBatchProgram` (*i.e.* reuse `RelTimeIndicatorConverter`) to rewrite `PROCTIME()` to `PROCTIME_MATERIALIZE(PROCTIME())`, which is consistent with stream mode. More discussion on the implementation details can be founded at [FLINK-17868](https://issues.apache.org/jira/browse/FLINK-17868).
## Brief change log
- *The changes applied to `FlinkBatchProgram`, `FlinkOptimizationContext`, `FlinkRelTimeIndicatorProgram`, `StreamOptimizationContext`, `BatchCommonSubGraphBasedOptimizer` is to reuse `RelTimeIndicatorConverter` under batch mode.*
- *The changes applied to `TableStreamOperator`, `StreamExecCalc`, `StreamExecCorrelate`, `StreamExecDataStreamScan`, `StreamLegacyTableSourceScan` is to merge `AbstractProcessStreamOperator` into `TableStreamOperator`. As a result, `TableStreamOperator` will be the common base class for streaming and batch operators to share.*
- *The changes applied to `BatchLogicalWindowAggregateRule#getOutAggregateGroupExpression` is to avoid `RelOptUtil#verifyTypeEquivalence` failing, because after introducing `RelTimeIndicatorConverter`, the time attribute in window expression is modfied to `TIMESTAMP`.*
## Verifying this change
This change added tests and can be verified as follows:
- *`TableScanTest#testDDLWithProctime` and `TableSourceTest#testSimpleProjectWithProctime` is to verify the optimized plan.*
- *`TableScanITCase#testProctimeTableSource` and `TableSourceITCase#testSimpleProjectWithProcTime` is to verify the execution result.*
- *The changes made to `(Non)BufferDataOverWindowOperatorTest` adapts to the change of `TableStreamOperator`.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] LadyForest commented on pull request #14687: [FLINK-17868][table-planner-blink] Fix proctime in DDL can not work in batch mode
Posted by GitBox <gi...@apache.org>.
LadyForest commented on pull request #14687:
URL: https://github.com/apache/flink/pull/14687#issuecomment-765098887
Hi @wuchong, I addressed the comments as you suggested, and please take a look when you're free.
Thanks for helping polish this PR.
Best, Jane
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #14687: [FLINK-17868][table-planner-blink] Fix proctime in DDL can not work in batch mode
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #14687:
URL: https://github.com/apache/flink/pull/14687
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14687: [FLINK-17868][table-planner-blink] Fix proctime in DDL can not work in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14687:
URL: https://github.com/apache/flink/pull/14687#issuecomment-762573853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd776fae11a260742de0ebdfb7e3931d46d14bb1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12208",
"triggerID" : "cd776fae11a260742de0ebdfb7e3931d46d14bb1",
"triggerType" : "PUSH"
}, {
"hash" : "96eeab66176a18c12c5c7e400ae606823cc51181",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12359",
"triggerID" : "765094370",
"triggerType" : "MANUAL"
}, {
"hash" : "96eeab66176a18c12c5c7e400ae606823cc51181",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12359",
"triggerID" : "96eeab66176a18c12c5c7e400ae606823cc51181",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "765094370",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 96eeab66176a18c12c5c7e400ae606823cc51181 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12359)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] LadyForest commented on a change in pull request #14687: [FLINK-17868][table-planner-blink] Fix proctime in DDL can not work in batch mode
Posted by GitBox <gi...@apache.org>.
LadyForest commented on a change in pull request #14687:
URL: https://github.com/apache/flink/pull/14687#discussion_r562355558
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/optimize/program/FlinkBatchProgram.scala
##########
@@ -73,6 +74,8 @@ object FlinkBatchProgram {
.build(), "convert table references after sub-queries removed")
.build()
)
+ // convert time indicators
+ chainedProgram.addLast(TIME_INDICATOR, new FlinkRelTimeIndicatorProgram)
Review comment:
Good catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] LadyForest commented on pull request #14687: [FLINK-17868][table-planner-blink] Fix proctime in DDL can not work in batch mode
Posted by GitBox <gi...@apache.org>.
LadyForest commented on pull request #14687:
URL: https://github.com/apache/flink/pull/14687#issuecomment-762664434
Hi @wuchong, would you mind helping to review this PR when you're free?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #14687: [FLINK-17868][table-planner-blink] Fix proctime in DDL can not work in batch mode
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #14687:
URL: https://github.com/apache/flink/pull/14687#discussion_r561821288
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/TableStreamOperator.java
##########
@@ -20,18 +20,40 @@
import org.apache.flink.core.memory.ManagedMemoryUseCase;
import org.apache.flink.runtime.execution.Environment;
+import org.apache.flink.streaming.api.TimerService;
import org.apache.flink.streaming.api.operators.AbstractStreamOperator;
import org.apache.flink.streaming.api.operators.ChainingStrategy;
+import org.apache.flink.streaming.api.operators.InternalTimerService;
+import org.apache.flink.streaming.api.watermark.Watermark;
+import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
+import org.apache.flink.streaming.runtime.tasks.ProcessingTimeService;
-/** Table operator to invoke close always. */
+import static org.apache.flink.util.Preconditions.checkNotNull;
+import static org.apache.flink.util.Preconditions.checkState;
+
+/**
+ * Table operator to invoke close always. This is a base class for both batch and stream operators
+ * without key.
+ */
public class TableStreamOperator<OUT> extends AbstractStreamOperator<OUT> {
Review comment:
We can add an `abstract` modifier to the class.
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/TableScanITCase.scala
##########
@@ -54,14 +56,16 @@ class TableScanITCase extends BatchTestBase {
val tableSource = new TestTableSourceWithTime(true, schema, returnType, data, null, "ptime")
tEnv.asInstanceOf[TableEnvironmentInternal].registerTableSourceInternal(tableName, tableSource)
-
+ val expected = LocalDateTime
+ .now(ZoneId.of("UTC"))
+ .format(DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm"))
checkResult(
- s"SELECT name FROM $tableName",
+ s"SELECT name, DATE_FORMAT(ptime, 'yyyy-MM-dd HH:mm') FROM $tableName",
Seq(
- row("Mary"),
- row("Peter"),
- row("Bob"),
- row("Liz"))
+ row("Mary", expected),
+ row("Peter", expected),
+ row("Bob", expected),
+ row("Liz", expected))
Review comment:
This is not a stable test. The results of proctime may span multiple minutes.
We can call `CHAR_LENGTH` on the DATE_FORMAT to have a deterministic result.
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/optimize/program/FlinkBatchProgram.scala
##########
@@ -73,6 +74,8 @@ object FlinkBatchProgram {
.build(), "convert table references after sub-queries removed")
.build()
)
+ // convert time indicators
+ chainedProgram.addLast(TIME_INDICATOR, new FlinkRelTimeIndicatorProgram)
Review comment:
We put TIME_INDICATOR phase under decorrelate in streaming programs, I think we should keep the same order in batch program to put the phase after decorrelate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14687: [FLINK-17868][table-planner-blink] Fix proctime in DDL can not work in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14687:
URL: https://github.com/apache/flink/pull/14687#issuecomment-762573853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd776fae11a260742de0ebdfb7e3931d46d14bb1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12208",
"triggerID" : "cd776fae11a260742de0ebdfb7e3931d46d14bb1",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "765094370",
"triggerType" : "MANUAL"
}, {
"hash" : "96eeab66176a18c12c5c7e400ae606823cc51181",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12359",
"triggerID" : "765094370",
"triggerType" : "MANUAL"
}, {
"hash" : "96eeab66176a18c12c5c7e400ae606823cc51181",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12359",
"triggerID" : "96eeab66176a18c12c5c7e400ae606823cc51181",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 96eeab66176a18c12c5c7e400ae606823cc51181 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12359)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14687: [FLINK-17868][table-planner-blink] Fix proctime in DDL can not work in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14687:
URL: https://github.com/apache/flink/pull/14687#issuecomment-762569978
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 96eeab66176a18c12c5c7e400ae606823cc51181 (Fri May 28 07:12:24 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14687: [FLINK-17868][table-planner-blink] Fix proctime in DDL can not work in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14687:
URL: https://github.com/apache/flink/pull/14687#issuecomment-762569978
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit cd776fae11a260742de0ebdfb7e3931d46d14bb1 (Tue Jan 19 02:59:35 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #14687: [FLINK-17868][table-planner-blink] Fix proctime in DDL can not work in batch mode
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #14687:
URL: https://github.com/apache/flink/pull/14687#discussion_r561821288
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/TableStreamOperator.java
##########
@@ -20,18 +20,40 @@
import org.apache.flink.core.memory.ManagedMemoryUseCase;
import org.apache.flink.runtime.execution.Environment;
+import org.apache.flink.streaming.api.TimerService;
import org.apache.flink.streaming.api.operators.AbstractStreamOperator;
import org.apache.flink.streaming.api.operators.ChainingStrategy;
+import org.apache.flink.streaming.api.operators.InternalTimerService;
+import org.apache.flink.streaming.api.watermark.Watermark;
+import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
+import org.apache.flink.streaming.runtime.tasks.ProcessingTimeService;
-/** Table operator to invoke close always. */
+import static org.apache.flink.util.Preconditions.checkNotNull;
+import static org.apache.flink.util.Preconditions.checkState;
+
+/**
+ * Table operator to invoke close always. This is a base class for both batch and stream operators
+ * without key.
+ */
public class TableStreamOperator<OUT> extends AbstractStreamOperator<OUT> {
Review comment:
We can add an `abstract` modifier to the class.
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/TableScanITCase.scala
##########
@@ -54,14 +56,16 @@ class TableScanITCase extends BatchTestBase {
val tableSource = new TestTableSourceWithTime(true, schema, returnType, data, null, "ptime")
tEnv.asInstanceOf[TableEnvironmentInternal].registerTableSourceInternal(tableName, tableSource)
-
+ val expected = LocalDateTime
+ .now(ZoneId.of("UTC"))
+ .format(DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm"))
checkResult(
- s"SELECT name FROM $tableName",
+ s"SELECT name, DATE_FORMAT(ptime, 'yyyy-MM-dd HH:mm') FROM $tableName",
Seq(
- row("Mary"),
- row("Peter"),
- row("Bob"),
- row("Liz"))
+ row("Mary", expected),
+ row("Peter", expected),
+ row("Bob", expected),
+ row("Liz", expected))
Review comment:
This is not a stable test. The results of proctime may span multiple minutes.
We can call `CHAR_LENGTH` on the DATE_FORMAT to have a deterministic result.
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/optimize/program/FlinkBatchProgram.scala
##########
@@ -73,6 +74,8 @@ object FlinkBatchProgram {
.build(), "convert table references after sub-queries removed")
.build()
)
+ // convert time indicators
+ chainedProgram.addLast(TIME_INDICATOR, new FlinkRelTimeIndicatorProgram)
Review comment:
We put TIME_INDICATOR phase under decorrelate in streaming programs, I think we should keep the same order in batch program to put the phase after decorrelate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14687: [FLINK-17868][table-planner-blink] Fix proctime in DDL can not work in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14687:
URL: https://github.com/apache/flink/pull/14687#issuecomment-762573853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd776fae11a260742de0ebdfb7e3931d46d14bb1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12208",
"triggerID" : "cd776fae11a260742de0ebdfb7e3931d46d14bb1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cd776fae11a260742de0ebdfb7e3931d46d14bb1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12208)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14687: [FLINK-17868][table-planner-blink] Fix proctime in DDL can not work in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14687:
URL: https://github.com/apache/flink/pull/14687#issuecomment-762573853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd776fae11a260742de0ebdfb7e3931d46d14bb1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12208",
"triggerID" : "cd776fae11a260742de0ebdfb7e3931d46d14bb1",
"triggerType" : "PUSH"
}, {
"hash" : "96eeab66176a18c12c5c7e400ae606823cc51181",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "765094370",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "765094370",
"triggerType" : "MANUAL"
}, {
"hash" : "96eeab66176a18c12c5c7e400ae606823cc51181",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "96eeab66176a18c12c5c7e400ae606823cc51181",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 96eeab66176a18c12c5c7e400ae606823cc51181 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14687: [FLINK-17868][table-planner-blink] Fix proctime in DDL can not work in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14687:
URL: https://github.com/apache/flink/pull/14687#issuecomment-762573853
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] LadyForest commented on pull request #14687: [FLINK-17868][table-planner-blink] Fix proctime in DDL can not work in batch mode
Posted by GitBox <gi...@apache.org>.
LadyForest commented on pull request #14687:
URL: https://github.com/apache/flink/pull/14687#issuecomment-765094370
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14687: [FLINK-17868][table-planner-blink] Fix proctime in DDL can not work in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14687:
URL: https://github.com/apache/flink/pull/14687#issuecomment-762573853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd776fae11a260742de0ebdfb7e3931d46d14bb1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12208",
"triggerID" : "cd776fae11a260742de0ebdfb7e3931d46d14bb1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cd776fae11a260742de0ebdfb7e3931d46d14bb1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12208)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] LadyForest commented on pull request #14687: [FLINK-17868][table-planner-blink] Fix proctime in DDL can not work in batch mode
Posted by GitBox <gi...@apache.org>.
LadyForest commented on pull request #14687:
URL: https://github.com/apache/flink/pull/14687#issuecomment-765094370
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14687: [FLINK-17868][table-planner-blink] Fix proctime in DDL can not work in batch mode
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14687:
URL: https://github.com/apache/flink/pull/14687#issuecomment-762573853
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cd776fae11a260742de0ebdfb7e3931d46d14bb1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cd776fae11a260742de0ebdfb7e3931d46d14bb1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cd776fae11a260742de0ebdfb7e3931d46d14bb1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] LadyForest commented on a change in pull request #14687: [FLINK-17868][table-planner-blink] Fix proctime in DDL can not work in batch mode
Posted by GitBox <gi...@apache.org>.
LadyForest commented on a change in pull request #14687:
URL: https://github.com/apache/flink/pull/14687#discussion_r562355558
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/optimize/program/FlinkBatchProgram.scala
##########
@@ -73,6 +74,8 @@ object FlinkBatchProgram {
.build(), "convert table references after sub-queries removed")
.build()
)
+ // convert time indicators
+ chainedProgram.addLast(TIME_INDICATOR, new FlinkRelTimeIndicatorProgram)
Review comment:
Good catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org