You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2016/04/08 10:41:14 UTC

Review Request 45921: Not all log and PID dirs have "hadoop" group

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45921/
-----------------------------------------------------------

Review request for Ambari and Myroslav Papirkovskyy.


Bugs: AMBARI-15776
    https://issues.apache.org/jira/browse/AMBARI-15776


Repository: ambari


Description
-------

Was deployed cluster with set custom log and pid directories. After deploy
almost all log and pid dirs have "hadoop" as group in credentials, but hdfs,
yarn and flume have "root".  
"The only thing group influences is that group users would be able to read the
logs, contracting to 'others' when umask 027 is set. Maybe that would make
sense to give all 'hadoop' users to read pids/logs, but that is not a big of
deal IMO."


Diffs
-----

  ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py db52431 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py f9ee40d 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 82f8de4 
  ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 5ee1fd9 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py f939eed 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 4d91897 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 9ece2a3 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py ed03ae1 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 9e66e51 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 72728a3 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 19253b2 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py de7d641 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py e1036c5 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py e372667 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 9f7770c 
  ambari-server/src/test/python/stacks/2.0.6/configs/flume_only.json 1e39008 
  ambari-server/src/test/python/stacks/2.0.6/configs/flume_target.json 8648395 
  ambari-server/src/test/python/stacks/2.1/YARN/test_apptimelineserver.py d05c9fc 
  ambari-server/src/test/python/stacks/2.3/YARN/test_ats_1_5.py a274d45 

Diff: https://reviews.apache.org/r/45921/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 45921: Not all log and PID dirs have "hadoop" group

Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45921/#review127750
-----------------------------------------------------------


Ship it!




Ship It!

- Myroslav Papirkovskyy


On Квітень 8, 2016, 11:41 до полудня, Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45921/
> -----------------------------------------------------------
> 
> (Updated Квітень 8, 2016, 11:41 до полудня)
> 
> 
> Review request for Ambari and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-15776
>     https://issues.apache.org/jira/browse/AMBARI-15776
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Was deployed cluster with set custom log and pid directories. After deploy
> almost all log and pid dirs have "hadoop" as group in credentials, but hdfs,
> yarn and flume have "root".  
> "The only thing group influences is that group users would be able to read the
> logs, contracting to 'others' when umask 027 is set. Maybe that would make
> sense to give all 'hadoop' users to read pids/logs, but that is not a big of
> deal IMO."
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py db52431 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py f9ee40d 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py 82f8de4 
>   ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 5ee1fd9 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py f939eed 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 4d91897 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 9ece2a3 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py ed03ae1 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 9e66e51 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 72728a3 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 19253b2 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py de7d641 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py e1036c5 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py e372667 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 9f7770c 
>   ambari-server/src/test/python/stacks/2.0.6/configs/flume_only.json 1e39008 
>   ambari-server/src/test/python/stacks/2.0.6/configs/flume_target.json 8648395 
>   ambari-server/src/test/python/stacks/2.1/YARN/test_apptimelineserver.py d05c9fc 
>   ambari-server/src/test/python/stacks/2.3/YARN/test_ats_1_5.py a274d45 
> 
> Diff: https://reviews.apache.org/r/45921/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>