You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2022/08/29 20:51:22 UTC
[GitHub] [datasketches-cpp] jmalkin opened a new pull request, #301: avoid needless call to memcpy with an empty entries_ array
jmalkin opened a new pull request, #301:
URL: https://github.com/apache/datasketches-cpp/pull/301
Based on #300 , we should avoid calling memcpy() when entries_ is empty to keep -fsanitize=undefiend happy. The sanitizer (reasonably) detected a copy of 0 bytes from nullptr. And while that should be completely harmless in this case, it's cleaner to avoid entirely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] jmalkin merged pull request #301: avoid needless call to memcpy with an empty entries_ array
Posted by GitBox <gi...@apache.org>.
jmalkin merged PR #301:
URL: https://github.com/apache/datasketches-cpp/pull/301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] coveralls commented on pull request #301: avoid needless call to memcpy with an empty entries_ array
Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #301:
URL: https://github.com/apache/datasketches-cpp/pull/301#issuecomment-1230854802
## Pull Request Test Coverage Report for [Build 2951678780](https://coveralls.io/builds/52040276)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **92.347%**
---
| Totals | [](https://coveralls.io/builds/52040276) |
| :-- | --: |
| Change from base [Build 2885525020](https://coveralls.io/builds/51779172): | 0.0% |
| Covered Lines: | 2196 |
| Relevant Lines: | 2378 |
---
##### 💛 - [Coveralls](https://coveralls.io)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] AlexanderSaydakov commented on pull request #301: avoid needless call to memcpy with an empty entries_ array
Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov commented on PR #301:
URL: https://github.com/apache/datasketches-cpp/pull/301#issuecomment-1230887385
fixes #300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org