You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/02/02 23:13:04 UTC

[GitHub] [tvm] codeislife99 opened a new pull request #7396: Fix bug in resize3d

codeislife99 opened a new pull request #7396:
URL: https://github.com/apache/tvm/pull/7396


   No arguments for resize_3d fixed. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tkonolige commented on a change in pull request #7396: Fix bug in resize3d

Posted by GitBox <gi...@apache.org>.
tkonolige commented on a change in pull request #7396:
URL: https://github.com/apache/tvm/pull/7396#discussion_r569002900



##########
File path: tests/python/relay/test_op_level5.py
##########
@@ -98,7 +98,7 @@ def test_resize3d_infer_type():
 
 
 @tvm.testing.parametrize_targets
-def test_resize3d(target, ctx):

Review comment:
       This is the correct usage of `@tvm.testing.parametrize_targets`. This test also run successfully on my local machine. Could you explain what the bug is?

##########
File path: tests/python/relay/test_op_level5.py
##########
@@ -98,7 +98,7 @@ def test_resize3d_infer_type():
 
 
 @tvm.testing.parametrize_targets
-def test_resize3d(target, ctx):

Review comment:
       This is the correct usage of `@tvm.testing.parametrize_targets`. This test also runs successfully on my local machine. Could you explain what the bug is?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tkonolige commented on a change in pull request #7396: Fix bug in resize3d

Posted by GitBox <gi...@apache.org>.
tkonolige commented on a change in pull request #7396:
URL: https://github.com/apache/tvm/pull/7396#discussion_r569002900



##########
File path: tests/python/relay/test_op_level5.py
##########
@@ -98,7 +98,7 @@ def test_resize3d_infer_type():
 
 
 @tvm.testing.parametrize_targets
-def test_resize3d(target, ctx):

Review comment:
       This is the correct usage of `@tvm.testing.parametrize_targets`. This test also run successfully on my local machine. Could you explain what the bug is?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] codeislife99 commented on pull request #7396: Fix bug in resize3d

Posted by GitBox <gi...@apache.org>.
codeislife99 commented on pull request #7396:
URL: https://github.com/apache/tvm/pull/7396#issuecomment-772079829


   @anijain2305 @trevor-m . 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] codeislife99 commented on a change in pull request #7396: Fix bug in resize3d

Posted by GitBox <gi...@apache.org>.
codeislife99 commented on a change in pull request #7396:
URL: https://github.com/apache/tvm/pull/7396#discussion_r569006121



##########
File path: tests/python/relay/test_op_level5.py
##########
@@ -98,7 +98,7 @@ def test_resize3d_infer_type():
 
 
 @tvm.testing.parametrize_targets
-def test_resize3d(target, ctx):

Review comment:
       Ah, there must be something wrong with the env on my machine then. I will close this PR. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] codeislife99 commented on a change in pull request #7396: Fix bug in resize3d

Posted by GitBox <gi...@apache.org>.
codeislife99 commented on a change in pull request #7396:
URL: https://github.com/apache/tvm/pull/7396#discussion_r569006121



##########
File path: tests/python/relay/test_op_level5.py
##########
@@ -98,7 +98,7 @@ def test_resize3d_infer_type():
 
 
 @tvm.testing.parametrize_targets
-def test_resize3d(target, ctx):

Review comment:
       Ah, there must be something wrong with the env on my machine then. I will close this PR. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] codeislife99 commented on pull request #7396: Fix bug in resize3d

Posted by GitBox <gi...@apache.org>.
codeislife99 commented on pull request #7396:
URL: https://github.com/apache/tvm/pull/7396#issuecomment-772079829


   @anijain2305 @trevor-m . 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tkonolige commented on a change in pull request #7396: Fix bug in resize3d

Posted by GitBox <gi...@apache.org>.
tkonolige commented on a change in pull request #7396:
URL: https://github.com/apache/tvm/pull/7396#discussion_r569002900



##########
File path: tests/python/relay/test_op_level5.py
##########
@@ -98,7 +98,7 @@ def test_resize3d_infer_type():
 
 
 @tvm.testing.parametrize_targets
-def test_resize3d(target, ctx):

Review comment:
       This is the correct usage of `@tvm.testing.parametrize_targets`. This test also runs successfully on my local machine. Could you explain what the bug is?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] codeislife99 removed a comment on pull request #7396: Fix bug in resize3d

Posted by GitBox <gi...@apache.org>.
codeislife99 removed a comment on pull request #7396:
URL: https://github.com/apache/tvm/pull/7396#issuecomment-772079829


   @anijain2305 @trevor-m PTAL
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] codeislife99 closed pull request #7396: Fix bug in resize3d

Posted by GitBox <gi...@apache.org>.
codeislife99 closed pull request #7396:
URL: https://github.com/apache/tvm/pull/7396


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] codeislife99 closed pull request #7396: Fix bug in resize3d

Posted by GitBox <gi...@apache.org>.
codeislife99 closed pull request #7396:
URL: https://github.com/apache/tvm/pull/7396


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] codeislife99 removed a comment on pull request #7396: Fix bug in resize3d

Posted by GitBox <gi...@apache.org>.
codeislife99 removed a comment on pull request #7396:
URL: https://github.com/apache/tvm/pull/7396#issuecomment-772079829


   @anijain2305 @trevor-m PTAL
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] codeislife99 edited a comment on pull request #7396: Fix bug in resize3d

Posted by GitBox <gi...@apache.org>.
codeislife99 edited a comment on pull request #7396:
URL: https://github.com/apache/tvm/pull/7396#issuecomment-772079829


   @anijain2305 @trevor-m PTAL
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] codeislife99 edited a comment on pull request #7396: Fix bug in resize3d

Posted by GitBox <gi...@apache.org>.
codeislife99 edited a comment on pull request #7396:
URL: https://github.com/apache/tvm/pull/7396#issuecomment-772079829


   @anijain2305 @trevor-m PTAL
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org