You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/27 08:50:37 UTC

[GitHub] [airflow] vemikhaylov commented on pull request #14501: Fix set task instance form test

vemikhaylov commented on pull request #14501:
URL: https://github.com/apache/airflow/pull/14501#issuecomment-787038751


   Besides using the correct schema in the test, I removed the test for a bool value provided as a string. It had been failing as by default `marshmallow` successfully deserializes bool strings and numbers as well:
   
   https://github.com/marshmallow-code/marshmallow/blob/7b5a78d77bc23ace331482817d3177147f4b0521/src/marshmallow/fields.py#L1080
   
   If we like to be more rigid about that, we should change this behaviour for all the boolean fields in the API to be more consistent, I guess.
   
   @mik-laj What do you think? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org