You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/09/11 09:51:10 UTC

[GitHub] [commons-net] j-verse opened a new pull request #59: NET-687: Removed creation of SSL socket when opening data connection …

j-verse opened a new pull request #59:
URL: https://github.com/apache/commons-net/pull/59


   …since this is already handled by the socket factory
   
   See Jira ticket for full explanation:
   [https://issues.apache.org/jira/browse/NET-687](https://issues.apache.org/jira/browse/NET-687)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-net] garydgregory commented on pull request #59: NET-687: Removed creation of SSL socket when opening data connection …

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #59:
URL: https://github.com/apache/commons-net/pull/59#issuecomment-695821996


   Fixed in git master along with a new test.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-net] garydgregory commented on pull request #59: NET-687: Removed creation of SSL socket when opening data connection …

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #59:
URL: https://github.com/apache/commons-net/pull/59#issuecomment-694228149


   We need a test that shows the failure without the main patch. I have part of test I'll commit ASAP...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-net] kopavel commented on pull request #59: NET-687: Removed creation of SSL socket when opening data connection …

Posted by GitBox <gi...@apache.org>.
kopavel commented on pull request #59:
URL: https://github.com/apache/commons-net/pull/59#issuecomment-694136758


   Up-vote. 
   Have the same problem "Unsupported or unrecognized SSL message" using FTPSClient for getting folder content using listFiles method.
    


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-net] garydgregory commented on pull request #59: NET-687: Removed creation of SSL socket when opening data connection …

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #59:
URL: https://github.com/apache/commons-net/pull/59#issuecomment-703357910


   This fix is now available in the  3.7.1 release.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-net] garydgregory closed pull request #59: NET-687: Removed creation of SSL socket when opening data connection …

Posted by GitBox <gi...@apache.org>.
garydgregory closed pull request #59:
URL: https://github.com/apache/commons-net/pull/59


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-net] garydgregory commented on pull request #59: NET-687: Removed creation of SSL socket when opening data connection …

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #59:
URL: https://github.com/apache/commons-net/pull/59#issuecomment-695498584


   @j-verse May you please rebase on master and add a test to `FTPSClientTest` that shows this failure when the `main` part of the PR in not applied?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-net] garydgregory commented on pull request #59: NET-687: Removed creation of SSL socket when opening data connection …

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #59:
URL: https://github.com/apache/commons-net/pull/59#issuecomment-694354535


   I can confirm that this PR https://github.com/apache/commons-net/pull/59 fixes the regressing bug in Apache Commons VFS master tests in **org.apache.commons.vfs2.provider.ftps.test** which was introduced by Commons Net 3.7.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-net] garydgregory closed pull request #59: NET-687: Removed creation of SSL socket when opening data connection …

Posted by GitBox <gi...@apache.org>.
garydgregory closed pull request #59:
URL: https://github.com/apache/commons-net/pull/59


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-net] garydgregory commented on pull request #59: NET-687: Removed creation of SSL socket when opening data connection …

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #59:
URL: https://github.com/apache/commons-net/pull/59#issuecomment-695821996


   Fixed in git master along with a new test.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-net] garydgregory commented on pull request #59: NET-687: Removed creation of SSL socket when opening data connection …

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #59:
URL: https://github.com/apache/commons-net/pull/59#issuecomment-694338799


   I added a bare-bones class called **org.apache.commons.net.ftp.FTPSClientTest**, feel-free to clone/expand to reproduce your error so that anyone can reproduce it.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org