You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by "yx9o (via GitHub)" <gi...@apache.org> on 2026/07/25 05:18:02 UTC

[I] [Studio] Reject invalid alert rule updates [rocketmq-dashboard]

yx9o opened a new issue, #574:
URL: https://github.com/apache/rocketmq-dashboard/issues/574

   ## Problem
   
   `POST /api/alert-rules/update` saves requests without checking whether the required `id` is present or belongs to an existing rule.
   
   A missing `id` results in HTTP 500, while a blank or unknown `id` is inserted as a new rule and the update returns success.
   
   ## Expected behavior
   
   - Reject null or blank rule IDs with HTTP 400.
   - Reject unknown rule IDs with HTTP 404.
   - Prevent invalid updates from creating new rules.
   - Preserve normal updates for existing rules.
   
   ## Proposed fix
   
   Validate the rule ID before modifying the repository, atomically replace only existing entries, and add service and repository regression tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Studio] Reject invalid alert rule updates [rocketmq-dashboard]

Posted by "yx9o (via GitHub)" <gi...@apache.org>.

yx9o closed issue #574: [Studio] Reject invalid alert rule updates
URL: https://github.com/apache/rocketmq-dashboard/issues/574


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Studio] Reject invalid alert rule updates [rocketmq-dashboard]

Posted by "yx9o (via GitHub)" <gi...@apache.org>.

yx9o commented on issue #574:
URL: https://github.com/apache/rocketmq-dashboard/issues/574#issuecomment-5111475341

   Fixed by #575 .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org