You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "rmdmattingly (via GitHub)" <gi...@apache.org> on 2024/12/13 23:28:17 UTC
[PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
rmdmattingly opened a new pull request, #6543:
URL: https://github.com/apache/hbase/pull/6543
See my design doc [here](https://docs.google.com/document/d/1jA8Ghs86v7b-53j5DcsdbPnOXxbHjewkIBFi1E4S1pY/edit?usp=sharing)
To sum it up, the current load balancer isn't great for what it's supposed to do now, and it won't support all of the things that we'd like it to do in a perfect world.
Right now: primary replica balancing squashes all other considerations. The default weight for one of the several cost functions that factor into primary replica balancing is 100,000. Meanwhile the default read request cost is 5. The result is that the load balancer, OOTB, basically doesn't care about balancing actual load. To solve this, you can either set primary replica balancing costs to zero, which is fine if you don't use read replicas, or — if you do use read replicas — maybe you can produce a magic incantation of configurations that work _just_ right, until your needs change.
In the future: we'd like a lot more out of the balancer. System table isolation, meta table isolation, colocation of regions based on start key prefix similarity (this is a very rough idea atm, and not touched in the scope of this PR). And to support all of these features with either cost functions or RS groups would be a real burden. I think what I'm proposing here will be a much, much easier path for HBase operators.
cc @ndimiduk @charlesconnell @ksravista @aalhour
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2564072245
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 28s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 36s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 38s | | master passed |
| +1 :green_heart: | compile | 3m 33s | | master passed |
| +1 :green_heart: | checkstyle | 0m 44s | | master passed |
| +1 :green_heart: | spotbugs | 2m 0s | | master passed |
| +1 :green_heart: | spotless | 0m 45s | | branch has no errors when running spotless:check. |
| -0 :warning: | patch | 0m 57s | | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 1m 18s | [/patch-mvninstall-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/10/artifact/yetus-general-check/output/patch-mvninstall-root.txt) | root in the patch failed. |
| -1 :x: | compile | 0m 8s | [/patch-compile-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/10/artifact/yetus-general-check/output/patch-compile-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -1 :x: | compile | 1m 44s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/10/artifact/yetus-general-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 8s | [/patch-compile-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/10/artifact/yetus-general-check/output/patch-compile-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -0 :warning: | javac | 1m 44s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/10/artifact/yetus-general-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 0m 8s | [/results-checkstyle-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/10/artifact/yetus-general-check/output/results-checkstyle-hbase-balancer.txt) | hbase-balancer: The patch generated 16 new + 3 unchanged - 0 fixed = 19 total (was 3) |
| -1 :x: | spotbugs | 0m 8s | [/patch-spotbugs-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/10/artifact/yetus-general-check/output/patch-spotbugs-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -1 :x: | spotbugs | 0m 35s | [/patch-spotbugs-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/10/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt) | hbase-server in the patch failed. |
| -1 :x: | hadoopcheck | 1m 8s | | The patch causes 10 errors with Hadoop v3.3.6. |
| -1 :x: | hadoopcheck | 2m 18s | | The patch causes 10 errors with Hadoop v3.4.0. |
| +1 :green_heart: | spotless | 0m 45s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 15s | | The patch does not generate ASF License warnings. |
| | | 21m 30s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/10/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux ee48bdaac7b2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / e5ab24cdcefe2438c8d2b957595683c24ca1683b |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/10/artifact/yetus-general-check/output/patch-javac-3.3.6.txt |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/10/artifact/yetus-general-check/output/patch-javac-3.4.0.txt |
| Max. process+thread count | 84 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/10/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2543327282
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 33s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 14s | | master passed |
| +1 :green_heart: | compile | 3m 27s | | master passed |
| +1 :green_heart: | checkstyle | 0m 44s | | master passed |
| +1 :green_heart: | spotbugs | 1m 55s | | master passed |
| +1 :green_heart: | spotless | 0m 43s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 59s | | the patch passed |
| +1 :green_heart: | compile | 3m 21s | | the patch passed |
| -0 :warning: | javac | 0m 23s | [/results-compile-javac-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/4/artifact/yetus-general-check/output/results-compile-javac-hbase-balancer.txt) | hbase-balancer generated 7 new + 70 unchanged - 0 fixed = 77 total (was 70) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 0m 8s | [/results-checkstyle-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/4/artifact/yetus-general-check/output/results-checkstyle-hbase-balancer.txt) | hbase-balancer: The patch generated 6 new + 1 unchanged - 0 fixed = 7 total (was 1) |
| -0 :warning: | checkstyle | 0m 35s | [/results-checkstyle-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/4/artifact/yetus-general-check/output/results-checkstyle-hbase-server.txt) | hbase-server: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) |
| -1 :x: | spotbugs | 0m 31s | [/new-spotbugs-hbase-balancer.html](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/4/artifact/yetus-general-check/output/new-spotbugs-hbase-balancer.html) | hbase-balancer generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) |
| +1 :green_heart: | hadoopcheck | 11m 31s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 42s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 17s | | The patch does not generate ASF License warnings. |
| | | 40m 14s | | |
| Reason | Tests |
|-------:|:------|
| SpotBugs | module:hbase-balancer |
| | org.apache.hadoop.hbase.master.balancer.BalancerConditionals.INSTANCE isn't final but should be At BalancerConditionals.java:be At BalancerConditionals.java:[line 52] |
| | org.apache.hadoop.hbase.master.balancer.DistributeReplicasConditional.TEST_MODE_ENABLED isn't final but should be At DistributeReplicasConditional.java:be At DistributeReplicasConditional.java:[line 41] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/4/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 39bf7873f82a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / ea9992e3224608fad1091a02409743261bebcc5a |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 84 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/4/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2544001337
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 38s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 51s | | master passed |
| +1 :green_heart: | compile | 3m 0s | | master passed |
| +1 :green_heart: | checkstyle | 0m 45s | | master passed |
| +1 :green_heart: | spotbugs | 1m 57s | | master passed |
| +1 :green_heart: | spotless | 0m 42s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 38s | | the patch passed |
| +1 :green_heart: | compile | 2m 55s | | the patch passed |
| -0 :warning: | javac | 0m 25s | [/results-compile-javac-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/5/artifact/yetus-general-check/output/results-compile-javac-hbase-balancer.txt) | hbase-balancer generated 7 new + 70 unchanged - 0 fixed = 77 total (was 70) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 0m 10s | [/results-checkstyle-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/5/artifact/yetus-general-check/output/results-checkstyle-hbase-balancer.txt) | hbase-balancer: The patch generated 6 new + 1 unchanged - 0 fixed = 7 total (was 1) |
| -0 :warning: | checkstyle | 0m 33s | [/results-checkstyle-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/5/artifact/yetus-general-check/output/results-checkstyle-hbase-server.txt) | hbase-server: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) |
| -1 :x: | spotbugs | 0m 31s | [/new-spotbugs-hbase-balancer.html](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/5/artifact/yetus-general-check/output/new-spotbugs-hbase-balancer.html) | hbase-balancer generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) |
| +1 :green_heart: | hadoopcheck | 9m 27s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 39s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 20s | | The patch does not generate ASF License warnings. |
| | | 35m 9s | | |
| Reason | Tests |
|-------:|:------|
| SpotBugs | module:hbase-balancer |
| | org.apache.hadoop.hbase.master.balancer.BalancerConditionals.INSTANCE isn't final but should be At BalancerConditionals.java:be At BalancerConditionals.java:[line 52] |
| | org.apache.hadoop.hbase.master.balancer.DistributeReplicasConditional.TEST_MODE_ENABLED isn't final but should be At DistributeReplicasConditional.java:be At DistributeReplicasConditional.java:[line 41] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/5/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux c49346276029 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 3bd96be985e7f8525b3d3f39743af62e8a6dc2f0 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 84 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/5/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2543172907
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 42s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 50s | | master passed |
| +1 :green_heart: | compile | 1m 8s | | master passed |
| +1 :green_heart: | javadoc | 0m 40s | | master passed |
| +1 :green_heart: | shadedjars | 4m 49s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 1m 12s | [/patch-mvninstall-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/3/artifact/yetus-jdk17-hadoop3-check/output/patch-mvninstall-root.txt) | root in the patch failed. |
| -1 :x: | compile | 0m 41s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/3/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 41s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/3/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| +1 :green_heart: | javadoc | 0m 40s | | the patch passed |
| -1 :x: | shadedjars | 3m 3s | | patch has 11 errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 0m 17s | [/patch-unit-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/3/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -1 :x: | unit | 0m 42s | [/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/3/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt) | hbase-server in the patch failed. |
| | | 18m 28s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 6fd699020f09 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / e4e6bb5af591986ab426ee1368afbddd6bcd1ce1 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/3/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/3/testReport/ |
| Max. process+thread count | 75 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/3/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2564143425
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 28s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 1s | | master passed |
| +1 :green_heart: | compile | 3m 28s | | master passed |
| +1 :green_heart: | checkstyle | 0m 42s | | master passed |
| +1 :green_heart: | spotbugs | 1m 55s | | master passed |
| +1 :green_heart: | spotless | 0m 43s | | branch has no errors when running spotless:check. |
| -0 :warning: | patch | 0m 56s | | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 1m 19s | [/patch-mvninstall-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/12/artifact/yetus-general-check/output/patch-mvninstall-root.txt) | root in the patch failed. |
| -1 :x: | compile | 0m 17s | [/patch-compile-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/12/artifact/yetus-general-check/output/patch-compile-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -1 :x: | compile | 1m 41s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/12/artifact/yetus-general-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 17s | [/patch-compile-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/12/artifact/yetus-general-check/output/patch-compile-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -0 :warning: | javac | 1m 41s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/12/artifact/yetus-general-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 0m 7s | [/results-checkstyle-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/12/artifact/yetus-general-check/output/results-checkstyle-hbase-balancer.txt) | hbase-balancer: The patch generated 2 new + 3 unchanged - 0 fixed = 5 total (was 3) |
| -1 :x: | spotbugs | 0m 34s | [/patch-spotbugs-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/12/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt) | hbase-server in the patch failed. |
| -1 :x: | hadoopcheck | 1m 9s | | The patch causes 11 errors with Hadoop v3.3.6. |
| -1 :x: | hadoopcheck | 2m 20s | | The patch causes 11 errors with Hadoop v3.4.0. |
| +1 :green_heart: | spotless | 0m 42s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 15s | | The patch does not generate ASF License warnings. |
| | | 20m 49s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/12/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 489309e44eb3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 7d18dc9f4a3273721a8bb8ee5f99717504be95a5 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/12/artifact/yetus-general-check/output/patch-javac-3.3.6.txt |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/12/artifact/yetus-general-check/output/patch-javac-3.4.0.txt |
| Max. process+thread count | 83 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/12/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2544969876
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 39s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 35s | | master passed |
| +1 :green_heart: | compile | 1m 7s | | master passed |
| +1 :green_heart: | javadoc | 0m 39s | | master passed |
| +1 :green_heart: | shadedjars | 4m 50s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 39s | | the patch passed |
| +1 :green_heart: | compile | 1m 8s | | the patch passed |
| +1 :green_heart: | javac | 1m 8s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 40s | | the patch passed |
| +1 :green_heart: | shadedjars | 4m 55s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 13m 17s | [/patch-unit-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/8/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -1 :x: | unit | 191m 29s | [/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/8/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt) | hbase-server in the patch failed. |
| | | 228m 44s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/8/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 2669c2ea333c 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d1622d1b4b70c3fe7f0ee7c99aa90d0217b826ec |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/8/testReport/ |
| Max. process+thread count | 5083 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/8/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2568368372
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 39s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 32s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 17s | | master passed |
| +1 :green_heart: | compile | 3m 35s | | master passed |
| +1 :green_heart: | checkstyle | 0m 47s | | master passed |
| +1 :green_heart: | spotbugs | 1m 59s | | master passed |
| +1 :green_heart: | spotless | 0m 49s | | branch has no errors when running spotless:check. |
| -0 :warning: | patch | 1m 2s | | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 1m 23s | [/patch-mvninstall-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/17/artifact/yetus-general-check/output/patch-mvninstall-root.txt) | root in the patch failed. |
| -1 :x: | compile | 0m 8s | [/patch-compile-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/17/artifact/yetus-general-check/output/patch-compile-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -1 :x: | compile | 1m 41s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/17/artifact/yetus-general-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 8s | [/patch-compile-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/17/artifact/yetus-general-check/output/patch-compile-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -0 :warning: | javac | 1m 41s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/17/artifact/yetus-general-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 0m 8s | [/results-checkstyle-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/17/artifact/yetus-general-check/output/results-checkstyle-hbase-balancer.txt) | hbase-balancer: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3) |
| -1 :x: | spotbugs | 0m 8s | [/patch-spotbugs-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/17/artifact/yetus-general-check/output/patch-spotbugs-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -1 :x: | spotbugs | 0m 44s | [/patch-spotbugs-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/17/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt) | hbase-server in the patch failed. |
| -1 :x: | hadoopcheck | 1m 5s | | The patch causes 10 errors with Hadoop v3.3.6. |
| -1 :x: | hadoopcheck | 2m 9s | | The patch causes 10 errors with Hadoop v3.4.0. |
| +1 :green_heart: | spotless | 0m 42s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 15s | | The patch does not generate ASF License warnings. |
| | | 21m 11s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/17/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 297895f57cfb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 757173f546f62a38a19a5e7bcc26371a6c7ba725 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/17/artifact/yetus-general-check/output/patch-javac-3.3.6.txt |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/17/artifact/yetus-general-check/output/patch-javac-3.4.0.txt |
| Max. process+thread count | 86 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/17/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2544651992
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 27s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 59s | | master passed |
| +1 :green_heart: | compile | 3m 25s | | master passed |
| +1 :green_heart: | checkstyle | 0m 44s | | master passed |
| +1 :green_heart: | spotbugs | 1m 53s | | master passed |
| +1 :green_heart: | spotless | 0m 43s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 3s | | the patch passed |
| +1 :green_heart: | compile | 3m 26s | | the patch passed |
| -0 :warning: | javac | 0m 24s | [/results-compile-javac-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/8/artifact/yetus-general-check/output/results-compile-javac-hbase-balancer.txt) | hbase-balancer generated 8 new + 70 unchanged - 0 fixed = 78 total (was 70) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 0m 35s | [/results-checkstyle-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/8/artifact/yetus-general-check/output/results-checkstyle-hbase-server.txt) | hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| +1 :green_heart: | spotbugs | 2m 7s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 11m 25s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. |
| -1 :x: | spotless | 0m 18s | | patch has 26 errors when running spotless:check, run spotless:apply to fix. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 16s | | The patch does not generate ASF License warnings. |
| | | 39m 18s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/8/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 9e8b65f1f14b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / d1622d1b4b70c3fe7f0ee7c99aa90d0217b826ec |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/8/artifact/yetus-general-check/output/patch-spotless.txt |
| Max. process+thread count | 85 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/8/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2571601690
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 41s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 7s | | master passed |
| +1 :green_heart: | compile | 1m 30s | | master passed |
| +1 :green_heart: | javadoc | 0m 45s | | master passed |
| +1 :green_heart: | shadedjars | 7m 1s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 56s | | the patch passed |
| +1 :green_heart: | compile | 1m 25s | | the patch passed |
| +1 :green_heart: | javac | 1m 25s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 42s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 38s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 14m 52s | | hbase-balancer in the patch passed. |
| +1 :green_heart: | unit | 185m 39s | | hbase-server in the patch passed. |
| | | 232m 50s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/21/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 9816d81d30da 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / a689f06a6e80e5466b35b497784aee5ab3ce2a7f |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/21/testReport/ |
| Max. process+thread count | 5313 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/21/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2570016842
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 30s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 2s | | master passed |
| +1 :green_heart: | compile | 3m 27s | | master passed |
| +1 :green_heart: | checkstyle | 0m 45s | | master passed |
| +1 :green_heart: | spotbugs | 2m 2s | | master passed |
| +1 :green_heart: | spotless | 0m 44s | | branch has no errors when running spotless:check. |
| -0 :warning: | patch | 0m 56s | | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 49s | | the patch passed |
| +1 :green_heart: | compile | 3m 17s | | the patch passed |
| +1 :green_heart: | javac | 0m 23s | | hbase-balancer generated 0 new + 65 unchanged - 5 fixed = 65 total (was 70) |
| +1 :green_heart: | javac | 2m 54s | | hbase-server in the patch passed. |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 43s | | the patch passed |
| +1 :green_heart: | spotbugs | 2m 1s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 10m 38s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 42s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 17s | | The patch does not generate ASF License warnings. |
| | | 38m 18s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/19/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux e6913034e020 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / e94ba85b305d08fbd6deacf79911d582435a17a1 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 84 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/19/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2570227710
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 34s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 25s | | master passed |
| +1 :green_heart: | compile | 1m 30s | | master passed |
| +1 :green_heart: | javadoc | 0m 57s | | master passed |
| +1 :green_heart: | shadedjars | 6m 22s | | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | patch | 6m 37s | | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 8s | | the patch passed |
| +1 :green_heart: | compile | 1m 14s | | the patch passed |
| +1 :green_heart: | javac | 1m 14s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 39s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 7s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 14m 47s | | hbase-balancer in the patch passed. |
| +1 :green_heart: | unit | 189m 13s | | hbase-server in the patch passed. |
| | | 233m 14s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/19/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 15e04dc8abc5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / e94ba85b305d08fbd6deacf79911d582435a17a1 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/19/testReport/ |
| Max. process+thread count | 4931 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/19/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "rmdmattingly (via GitHub)" <gi...@apache.org>.
rmdmattingly commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2544022404
This is working really well in my testing, and I'm not convinced that it's necessary to add a replica distribution candidate generator. This is because, typically, each region replica has so many acceptable destinations (n-r+1), where n is the number of servers and r is the number of replicas), and so many acceptable swap candidates (any region who does not represent the same data). This is different from, say, a table isolation conditional where we really want to drain many virtually all regions from a single RegionServer, and no swaps are appropriate
This is probably work for a separate PR, but I think it would be nice to support pluggable candidate generators to pair with any custom conditionals that users write
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "rmdmattingly (via GitHub)" <gi...@apache.org>.
rmdmattingly commented on code in PR #6543:
URL: https://github.com/apache/hbase/pull/6543#discussion_r1898731798
##########
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/BalancerClusterState.java:
##########
@@ -705,7 +709,41 @@ enum LocalityType {
RACK
}
- public void doAction(BalanceAction action) {
+ public List<RegionPlan> convertActionToPlans(BalanceAction action) {
Review Comment:
RegionPlans are a more straightforward interface than BalanceActions, because you don't have to do all of this switch nonsense. So the new RegionPlanConditional interface isn't concerned with BalanceActions — it's just working with RegionInfo and RegionPlan objects, for example:
`isViolatingServer(RegionPlan regionPlan, Set<RegionInfo> destinationRegions)`
All this to say, this was a nice method to introduce so that we could convert BalanceActions to RegionPlans as necessary for conditional evaluations, and without altering the current BalancerClusterState in-place via `doAction`
##########
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/CandidateGenerator.java:
##########
@@ -28,6 +28,8 @@
@InterfaceAudience.Private
abstract class CandidateGenerator {
+ static double MAX_WEIGHT = 100_000;
Review Comment:
I thought it would make sense to have a universal ceiling for candidate generator weights, rather than them just being arbitrary doubles on any scale
##########
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/BalanceAction.java:
##########
@@ -28,6 +28,8 @@ enum Type {
ASSIGN_REGION,
MOVE_REGION,
SWAP_REGIONS,
+ ISOLATE_TABLE,
+ MOVE_BATCH,
Review Comment:
Our conditional candidate generators can frequently see pretty far into the future if they've gone to the trouble of deriving one very opinionated move anyway. So this is a nice way to represent multiple regions moves triggered by one candidate generation iteration
##########
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/CacheAwareLoadBalancer.java:
##########
@@ -68,12 +68,13 @@ public synchronized void loadConf(Configuration configuration) {
}
@Override
- protected List<CandidateGenerator> createCandidateGenerators() {
- List<CandidateGenerator> candidateGenerators = new ArrayList<>(2);
- candidateGenerators.add(GeneratorFunctionType.LOAD.ordinal(),
+ protected Map<Class<? extends CandidateGenerator>, CandidateGenerator>
+ createCandidateGenerators() {
Review Comment:
The list/ordinal management in balancers was pretty ugly imo. Instead, this should be a mapping of class to generator obj
##########
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/BalancerConditionals.java:
##########
@@ -0,0 +1,219 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.balancer;
+
+import java.lang.reflect.Constructor;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Objects;
+import java.util.Optional;
+import java.util.Set;
+import java.util.stream.Collectors;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.master.RegionPlan;
+import org.apache.hadoop.hbase.util.ReflectionUtils;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hbase.thirdparty.com.google.common.collect.ImmutableSet;
+
+/**
+ * Balancer conditionals supplement cost functions in the {@link StochasticLoadBalancer}. Cost
+ * functions are insufficient and difficult to work with when making discrete decisions; this is
+ * because they operate on a continuous scale, and each cost function's multiplier affects the
+ * relative importance of every other cost function. So it is difficult to meaningfully and clearly
+ * value many aspects of your region distribution via cost functions alone. Conditionals allow you
+ * to very clearly define discrete rules that your balancer would ideally follow. To clarify, a
+ * conditional violation will not block a region assignment because we would prefer to have uptime
+ * than have perfectly intentional balance. But conditionals allow you to, for example, define that
+ * a region's primary and secondary should not live on the same rack. Another example, conditionals
+ * make it easy to define that system tables will ideally be isolated on their own RegionServer.
+ */
+@InterfaceAudience.Private
+public final class BalancerConditionals {
Review Comment:
This class basically acts as a simplifying wrapper around our conditional implementations. Often we'll want to infer something, like "is this class instantiated?" or we'll want to do something against every conditional — like re-weight them, or validate a move against them. This class gives us an easy place to make these things easier
##########
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:
##########
@@ -157,15 +157,20 @@ public class StochasticLoadBalancer extends BaseLoadBalancer {
private RegionReplicaHostCostFunction regionReplicaHostCostFunction;
private RegionReplicaRackCostFunction regionReplicaRackCostFunction;
- protected List<CandidateGenerator> candidateGenerators;
+ protected Map<Class<? extends CandidateGenerator>, CandidateGenerator> candidateGenerators;
+ private Map<Class<? extends CandidateGenerator>, Double> weightsOfGenerators;
Review Comment:
Just to reiterate, I think maps were a better idea here
##########
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/BalancerClusterState.java:
##########
@@ -899,6 +958,48 @@ int[] addRegion(int[] regions, int regionIndex) {
return newRegions;
}
+ int[] removeRegions(int[] regions, Set<Integer> regionIndicesToRemove) {
+ // Calculate the size of the new regions array
+ int newSize = regions.length - regionIndicesToRemove.size();
+ if (newSize < 0) {
+ throw new IllegalStateException(
+ "Region indices mismatch: more regions to remove than in the regions array");
+ }
Review Comment:
These methods make it easier to add/remove many indices from the BCS. This is nice for the MOVE_BATCH balance action, that I've justified for candidate generation performance reasons in another comment here.
Also, the nicer error messaging here is a good win imo. Previously you'd just hit ArrayIndexOutOfBoundExceptions, or worse — erroneous moves — when you fumbled the state management of your mutable BalancerClusterState. This should help anyone down the road if they're debugging a custom conditional implementation
##########
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:
##########
@@ -372,29 +389,37 @@ boolean needsBalance(TableName tableName, BalancerClusterState cluster) {
return true;
}
- if (sloppyRegionServerExist(cs)) {
+ if (!balancerConditionals.shouldSkipSloppyServerEvaluation() && sloppyRegionServerExist(cs)) {
Review Comment:
If we should figure out how to have these more nicely coexist, then I'm open to that feedback. In my opinion, based on my experience with the balancer, this is a fine tradeoff
##########
hbase-balancer/src/test/java/org/apache/hadoop/hbase/master/balancer/TestLargeClusterBalancingMetaTableIsolation.java:
##########
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.balancer;
+
+import static org.apache.hadoop.hbase.master.balancer.CandidateGeneratorTestUtil.isTableIsolated;
+import static org.apache.hadoop.hbase.master.balancer.CandidateGeneratorTestUtil.runBalancerToExhaustion;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.ServerName;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.client.RegionInfoBuilder;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Category(MediumTests.class)
+public class TestLargeClusterBalancingMetaTableIsolation {
Review Comment:
These tests are really solid imo. They make it easy to setup balancer scenarios with 10s of thousands of regions and thousands of servers, and ensure that the balancer can find its way out of the situation in a reasonable amount of time. These tests all pass reliably in 30s-3min on my local machine, often on the faster end, though it's a little dependent on luck — ie, how hairy are the edge cases that we randomly find ourselves in
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/balancer/TestReplicaDistributionBalancerConditional.java:
##########
@@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.balancer;
+
+import static org.apache.hadoop.hbase.balancer.BalancerConditionalsTestUtil.validateAssertionsWithRetries;
+
+import java.util.List;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
+import org.apache.hadoop.hbase.client.Connection;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
+import org.apache.hadoop.hbase.master.balancer.BalancerConditionals;
+import org.apache.hadoop.hbase.master.balancer.DistributeReplicasConditional;
+import org.apache.hadoop.hbase.testclassification.LargeTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.hbase.util.ServerRegionReplicaUtil;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Category(LargeTests.class)
+public class TestReplicaDistributionBalancerConditional {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestReplicaDistributionBalancerConditional.class);
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(TestReplicaDistributionBalancerConditional.class);
+ private static final HBaseTestingUtil TEST_UTIL = new HBaseTestingUtil();
+ private static final int REPLICAS = 3;
+ private static final int NUM_SERVERS = REPLICAS;
+ private static final int REGIONS_PER_SERVER = 5;
+
+ @Before
+ public void setUp() throws Exception {
+ TEST_UTIL.getConfiguration()
+ .setBoolean(BalancerConditionals.DISTRIBUTE_REPLICAS_CONDITIONALS_KEY, true);
+ TEST_UTIL.getConfiguration().setBoolean(DistributeReplicasConditional.TEST_MODE_ENABLED_KEY,
+ true);
+ TEST_UTIL.getConfiguration()
+ .setBoolean(ServerRegionReplicaUtil.REGION_REPLICA_REPLICATION_CONF_KEY, true);
+ TEST_UTIL.getConfiguration().setLong(HConstants.HBASE_BALANCER_PERIOD, 1000L);
+ TEST_UTIL.getConfiguration().setBoolean("hbase.master.balancer.stochastic.runMaxSteps", true);
+
+ // turn off replica cost functions
+ TEST_UTIL.getConfiguration()
+ .setLong("hbase.master.balancer.stochastic.regionReplicaRackCostKey", 0);
+ TEST_UTIL.getConfiguration()
+ .setLong("hbase.master.balancer.stochastic.regionReplicaHostCostKey", 0);
+
+ TEST_UTIL.startMiniCluster(NUM_SERVERS);
Review Comment:
In addition to the StochasticLoadBalancer tests in hbase-balancer that can test huge scales of conditional balancing, I wrote these mini cluster tests to smoke test that the balancer changes work in a "real" environment. This is also nice for testing the edge cases on smaller scales — eg, "I have 3 replicas and 3 servers, please distribute them!"
##########
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:
##########
@@ -408,34 +433,53 @@ boolean needsBalance(TableName tableName, BalancerClusterState cluster) {
@RestrictedApi(explanation = "Should only be called in tests", link = "",
allowedOnPath = ".*(/src/test/.*|StochasticLoadBalancer).java")
- BalanceAction nextAction(BalancerClusterState cluster) {
- return getRandomGenerator().generate(cluster);
+ Pair<CandidateGenerator, BalanceAction> nextAction(BalancerClusterState cluster) {
+ CandidateGenerator generator = getRandomGenerator(cluster);
+ return Pair.newPair(generator, generator.generate(cluster));
}
/**
* Select the candidate generator to use based on the cost of cost functions. The chance of
* selecting a candidate generator is propotional to the share of cost of all cost functions among
* all cost functions that benefit from it.
*/
- protected CandidateGenerator getRandomGenerator() {
+ protected CandidateGenerator getRandomGenerator(BalancerClusterState cluster) {
double sum = 0;
- for (int i = 0; i < weightsOfGenerators.length; i++) {
- sum += weightsOfGenerators[i];
- weightsOfGenerators[i] = sum;
+ for (Class<? extends CandidateGenerator> clazz : candidateGenerators.keySet()) {
+ sum += weightsOfGenerators.getOrDefault(clazz, 0.0);
}
if (sum == 0) {
- return candidateGenerators.get(0);
+ return candidateGenerators.values().stream().findAny().orElseThrow();
+ }
+
+ for (Class<? extends CandidateGenerator> clazz : candidateGenerators.keySet()) {
+ weightsOfGenerators.put(clazz,
+ Math.min(CandidateGenerator.MAX_WEIGHT, weightsOfGenerators.get(clazz) / sum));
}
- for (int i = 0; i < weightsOfGenerators.length; i++) {
- weightsOfGenerators[i] /= sum;
+
+ for (RegionPlanConditional conditional : balancerConditionals.getConditionals()) {
+ Optional<RegionPlanConditionalCandidateGenerator> generator =
+ conditional.getCandidateGenerator();
+ if (generator.isPresent() && generator.get().getWeight(cluster) > 0) {
+ return generator.get();
+ }
}
+
double rand = ThreadLocalRandom.current().nextDouble();
- for (int i = 0; i < weightsOfGenerators.length; i++) {
- if (rand <= weightsOfGenerators[i]) {
- return candidateGenerators.get(i);
+ Class<? extends CandidateGenerator> greatestWeightClazz = null;
+ double greatestWeight = 0;
+ for (Class<? extends CandidateGenerator> clazz : candidateGenerators.keySet()) {
+ double generatorWeight = weightsOfGenerators.get(clazz);
+ if (generatorWeight > greatestWeight) {
+ greatestWeight = generatorWeight;
+ greatestWeightClazz = clazz;
+ }
+ if (rand <= generatorWeight) {
+ return candidateGenerators.get(clazz);
}
}
- return candidateGenerators.get(candidateGenerators.size() - 1);
Review Comment:
Previously, this method would often just return the last candidate generator in the list. This refactored implementation does a few things differently:
1. It prioritizes conditional candidate generators over all others
2. In the non-conditional case, it prioritizes the generator with the highest weight instead of the last one in the (no longer existent) list
##########
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/SystemTableIsolationConditional.java:
##########
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.balancer;
+
+import java.util.Optional;
+import java.util.Set;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.master.RegionPlan;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * If enabled, this class will help the balancer ensure that system tables live on their own
+ * RegionServer. System tables will share one RegionServer! This conditional can be used in tandem
+ * with {@link MetaTableIsolationConditional} to add a second RegionServer specifically for meta
+ * table hosting. Configure this via {@link BalancerConditionals#ISOLATE_SYSTEM_TABLES_KEY}
+ */
+@InterfaceAudience.Private
+class SystemTableIsolationConditional extends RegionPlanConditional {
+
+ public SystemTableIsolationConditional(Configuration conf, BalancerClusterState cluster) {
+ super(conf, cluster);
+ boolean isolateMeta = conf.getBoolean(BalancerConditionals.ISOLATE_META_TABLE_KEY, false);
+ SystemTableIsolationCandidateGenerator.INSTANCE.setIsolateMeta(isolateMeta);
+ }
+
+ @Override
+ Optional<RegionPlanConditionalCandidateGenerator> getCandidateGenerator() {
+ return Optional.of(SystemTableIsolationCandidateGenerator.INSTANCE);
+ }
+
+ @Override
+ public boolean isViolatingServer(RegionPlan regionPlan, Set<RegionInfo> serverRegions) {
+ RegionInfo regionBeingMoved = regionPlan.getRegionInfo();
+ boolean shouldIsolateMovingRegion = isRegionToIsolate(regionBeingMoved);
+ for (RegionInfo destinationRegion : serverRegions) {
+ if (destinationRegion.getEncodedName().equals(regionBeingMoved.getEncodedName())) {
+ // Skip the region being moved
+ continue;
+ }
+ if (shouldIsolateMovingRegion && !isRegionToIsolate(destinationRegion)) {
+ // Ensure every destination region is also a region to isolate
+ return true;
+ } else if (!shouldIsolateMovingRegion && isRegionToIsolate(destinationRegion)) {
+ // Ensure no destination region is a region to isolate
+ return true;
+ }
+ }
+ return false;
Review Comment:
I can dedupe a lot of this logic with the MetaTable conditional, will do sometime soon
##########
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/TableIsolationCandidateGenerator.java:
##########
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.balancer;
+
+import java.util.ArrayList;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@InterfaceAudience.Private
+public abstract class TableIsolationCandidateGenerator
+ extends RegionPlanConditionalCandidateGenerator {
+
+ private static final Logger LOG = LoggerFactory.getLogger(TableIsolationCandidateGenerator.class);
+
+ abstract boolean shouldBeIsolated(RegionInfo regionInfo);
+
+ @Override
+ BalanceAction generate(BalancerClusterState cluster) {
+ return generateCandidate(cluster, false);
+ }
+
+ BalanceAction generateCandidate(BalancerClusterState cluster, boolean isWeighing) {
+ if (
+ !BalancerConditionals.INSTANCE.isSystemTableIsolationEnabled()
+ && !BalancerConditionals.INSTANCE.isMetaTableIsolationEnabled()
+ ) {
+ return BalanceAction.NULL_ACTION;
+ }
+
+ List<MoveRegionAction> moves = new ArrayList<>();
+ for (int serverIdx = 0; serverIdx < cluster.numServers; serverIdx++) {
+ boolean hasRegionsToIsolate = false;
+ Set<Integer> regionsToMove = new HashSet<>();
+
+ // Check all regions on the server
+ for (int regionIdx : cluster.regionsPerServer[serverIdx]) {
+ RegionInfo regionInfo = cluster.regions[regionIdx];
+ if (shouldBeIsolated(regionInfo)) {
+ hasRegionsToIsolate = true;
+ } else {
+ regionsToMove.add(regionIdx);
+ }
+ }
+
+ // Generate non-system regions to move, if applicable
+ if (hasRegionsToIsolate && !regionsToMove.isEmpty()) {
+ for (int regionToMove : regionsToMove) {
+ for (int i = 0; i < cluster.numServers; i++) {
+ int targetServer = pickOtherRandomServer(cluster, serverIdx);
+ MoveRegionAction possibleMove =
+ new MoveRegionAction(regionToMove, serverIdx, targetServer);
+ if (!BalancerConditionals.INSTANCE.isViolating(cluster, possibleMove)) {
+ if (isWeighing) {
+ return possibleMove;
+ }
+ moves.add(possibleMove);
+ break;
+ }
+ }
+ }
+ }
+
+ // todo should there be logic to consolidate isolated regions on as few servers as
+ // conditionals allow? This gets complicated with replicas, etc
Review Comment:
I think we will want to do this in the v1 balancer conditionals impl, so I will do so shortly. But this current build is working very well, so I wanted to push
##########
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java:
##########
@@ -521,21 +568,52 @@ protected List<RegionPlan> balanceTable(TableName tableName,
// Perform a stochastic walk to see if we can get a good fit.
long step;
+ boolean improvedConditionals = false;
+ Map<Class<? extends CandidateGenerator>, Long> generatorToStepCount = new HashMap<>();
+ Map<Class<? extends CandidateGenerator>, Long> generatorToApprovedActionCount = new HashMap<>();
Review Comment:
These aren't really necessary, but make debugging easier because you can understand which candidate generators lead to the given balancer plan. If we had this logging, I think we would've realized the flaws in getRandomGenerator earlier (it being prone to just picking the last generator in the list)
##########
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/CandidateGenerator.java:
##########
@@ -28,6 +28,8 @@
@InterfaceAudience.Private
abstract class CandidateGenerator {
+ static double MAX_WEIGHT = 100_000;
Review Comment:
Admittedly, we could rip this out now that I've made the decision to just let conditional candidate generators work first, if they want to
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2571552061
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 37s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 4s | | master passed |
| +1 :green_heart: | compile | 4m 19s | | master passed |
| +1 :green_heart: | checkstyle | 0m 57s | | master passed |
| +1 :green_heart: | spotbugs | 2m 16s | | master passed |
| +1 :green_heart: | spotless | 0m 56s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 52s | | the patch passed |
| +1 :green_heart: | compile | 4m 13s | | the patch passed |
| +1 :green_heart: | javac | 0m 29s | | hbase-balancer generated 0 new + 66 unchanged - 4 fixed = 66 total (was 70) |
| +1 :green_heart: | javac | 3m 44s | | hbase-server in the patch passed. |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 57s | | the patch passed |
| +1 :green_heart: | spotbugs | 2m 30s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 13m 40s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 1m 14s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 35s | | The patch does not generate ASF License warnings. |
| | | 49m 17s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/21/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 80abf62311b3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / a689f06a6e80e5466b35b497784aee5ab3ce2a7f |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 84 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/21/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2568185425
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 34s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 2s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 15s | | master passed |
| +1 :green_heart: | compile | 1m 12s | | master passed |
| +1 :green_heart: | javadoc | 0m 41s | | master passed |
| +1 :green_heart: | shadedjars | 5m 58s | | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | patch | 6m 14s | | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 7s | | the patch passed |
| +1 :green_heart: | compile | 1m 12s | | the patch passed |
| +1 :green_heart: | javac | 1m 12s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 39s | | the patch passed |
| +1 :green_heart: | shadedjars | 5m 55s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 19m 34s | [/patch-unit-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/16/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -1 :x: | unit | 193m 46s | [/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/16/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt) | hbase-server in the patch failed. |
| | | 240m 41s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/16/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 1dad25463a2d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b9c9c5aa7bf9e3f27436b77715371532c2de63ac |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/16/testReport/ |
| Max. process+thread count | 5552 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/16/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "rmdmattingly (via GitHub)" <gi...@apache.org>.
rmdmattingly commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2571353985
Build looks good here, and all of the balancer tests reliably pass on my machine within about 30min. I've improved the runtime of several tests too, because we made a lot of quick assumptions about runtime being 30s here, 60s there, and those really add up when running the full test suite repeatedly.
I've also setup a large cluster test for conditional replica balancing, at an identical scale to the existing large cluster test for legacy replica balancing. It demonstrates a _significant_ improvement in balancer latency when dealing with 1k servers, 20k regions, 3 replicas per region, and 100 tables:
<img width="515" alt="Screenshot 2025-01-04 at 11 48 55 AM" src="https://github.com/user-attachments/assets/15049da7-1e24-46af-971d-c22d2e07b8c5" />
Because this PR is huge, and there is a lot of iteration along the way, I'm tempted to close this and reopen a clean PR with a passing build. I'll do that either this weekend, or early next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2542594880
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 42s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 42s | | master passed |
| +1 :green_heart: | compile | 2m 9s | | master passed |
| +1 :green_heart: | javadoc | 1m 29s | | master passed |
| +1 :green_heart: | shadedjars | 4m 50s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 1m 13s | [/patch-mvninstall-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/1/artifact/yetus-jdk17-hadoop3-check/output/patch-mvninstall-root.txt) | root in the patch failed. |
| -1 :x: | compile | 0m 19s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/1/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 19s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/1/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| +1 :green_heart: | javadoc | 1m 27s | | the patch passed |
| -1 :x: | shadedjars | 3m 4s | | patch has 16 errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 17s | | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 1m 27s | | hbase-client in the patch passed. |
| -1 :x: | unit | 0m 16s | [/patch-unit-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/1/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -1 :x: | unit | 0m 21s | [/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/1/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt) | hbase-server in the patch failed. |
| -1 :x: | unit | 46m 23s | [/patch-unit-hbase-mapreduce.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/1/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-mapreduce.txt) | hbase-mapreduce in the patch failed. |
| | | 72m 20s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux ad7852a9fcb6 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 9086155ca2b35ffe1aef431c9e0cb3c1ff43af60 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/1/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/1/testReport/ |
| Max. process+thread count | 3662 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-client hbase-balancer hbase-server hbase-mapreduce U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/1/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2542566168
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 32s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 4s | | master passed |
| +1 :green_heart: | compile | 5m 25s | | master passed |
| +1 :green_heart: | checkstyle | 1m 24s | | master passed |
| +1 :green_heart: | spotbugs | 3m 32s | | master passed |
| +1 :green_heart: | spotless | 0m 44s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 1m 15s | [/patch-mvninstall-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt) | root in the patch failed. |
| -1 :x: | compile | 0m 23s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 30s | [/results-compile-javac-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/1/artifact/yetus-general-check/output/results-compile-javac-hbase-balancer.txt) | hbase-balancer generated 7 new + 70 unchanged - 0 fixed = 77 total (was 70) |
| -0 :warning: | javac | 0m 23s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 0m 8s | [/results-checkstyle-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/1/artifact/yetus-general-check/output/results-checkstyle-hbase-balancer.txt) | hbase-balancer: The patch generated 6 new + 1 unchanged - 0 fixed = 7 total (was 1) |
| -0 :warning: | checkstyle | 0m 34s | [/results-checkstyle-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/1/artifact/yetus-general-check/output/results-checkstyle-hbase-server.txt) | hbase-server: The patch generated 3 new + 2 unchanged - 0 fixed = 5 total (was 2) |
| -1 :x: | spotbugs | 0m 30s | [/new-spotbugs-hbase-balancer.html](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/1/artifact/yetus-general-check/output/new-spotbugs-hbase-balancer.html) | hbase-balancer generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) |
| -1 :x: | spotbugs | 0m 20s | [/patch-spotbugs-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt) | hbase-server in the patch failed. |
| -1 :x: | hadoopcheck | 1m 5s | | The patch causes 16 errors with Hadoop v3.3.6. |
| -1 :x: | hadoopcheck | 2m 11s | | The patch causes 16 errors with Hadoop v3.4.0. |
| +1 :green_heart: | spotless | 0m 41s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 36s | | The patch does not generate ASF License warnings. |
| | | 28m 55s | | |
| Reason | Tests |
|-------:|:------|
| SpotBugs | module:hbase-balancer |
| | org.apache.hadoop.hbase.master.balancer.BalancerConditionals.INSTANCE isn't final but should be At BalancerConditionals.java:be At BalancerConditionals.java:[line 50] |
| | org.apache.hadoop.hbase.master.balancer.DistributeReplicasConditional.TEST_MODE_ENABLED isn't final but should be At DistributeReplicasConditional.java:be At DistributeReplicasConditional.java:[line 39] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 886a43ab9796 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 9086155ca2b35ffe1aef431c9e0cb3c1ff43af60 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/1/artifact/yetus-general-check/output/patch-javac-3.3.6.txt |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/1/artifact/yetus-general-check/output/patch-javac-3.4.0.txt |
| Max. process+thread count | 87 (vs. ulimit of 30000) |
| modules | C: hbase-common hbase-client hbase-balancer hbase-server hbase-mapreduce U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/1/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2543173482
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 29s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 1s | | master passed |
| +1 :green_heart: | compile | 3m 26s | | master passed |
| +1 :green_heart: | checkstyle | 0m 44s | | master passed |
| +1 :green_heart: | spotbugs | 1m 53s | | master passed |
| +1 :green_heart: | spotless | 0m 44s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 1m 14s | [/patch-mvninstall-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/3/artifact/yetus-general-check/output/patch-mvninstall-root.txt) | root in the patch failed. |
| -1 :x: | compile | 1m 37s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/3/artifact/yetus-general-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 21s | [/results-compile-javac-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/3/artifact/yetus-general-check/output/results-compile-javac-hbase-balancer.txt) | hbase-balancer generated 7 new + 70 unchanged - 0 fixed = 77 total (was 70) |
| -0 :warning: | javac | 1m 37s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/3/artifact/yetus-general-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 0m 7s | [/results-checkstyle-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/3/artifact/yetus-general-check/output/results-checkstyle-hbase-balancer.txt) | hbase-balancer: The patch generated 6 new + 1 unchanged - 0 fixed = 7 total (was 1) |
| -0 :warning: | checkstyle | 0m 34s | [/results-checkstyle-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/3/artifact/yetus-general-check/output/results-checkstyle-hbase-server.txt) | hbase-server: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) |
| -1 :x: | spotbugs | 0m 30s | [/new-spotbugs-hbase-balancer.html](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/3/artifact/yetus-general-check/output/new-spotbugs-hbase-balancer.html) | hbase-balancer generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) |
| -1 :x: | spotbugs | 0m 31s | [/patch-spotbugs-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/3/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt) | hbase-server in the patch failed. |
| -1 :x: | hadoopcheck | 1m 5s | | The patch causes 11 errors with Hadoop v3.3.6. |
| -1 :x: | hadoopcheck | 2m 13s | | The patch causes 11 errors with Hadoop v3.4.0. |
| +1 :green_heart: | spotless | 0m 42s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 16s | | The patch does not generate ASF License warnings. |
| | | 20m 20s | | |
| Reason | Tests |
|-------:|:------|
| SpotBugs | module:hbase-balancer |
| | org.apache.hadoop.hbase.master.balancer.BalancerConditionals.INSTANCE isn't final but should be At BalancerConditionals.java:be At BalancerConditionals.java:[line 52] |
| | org.apache.hadoop.hbase.master.balancer.DistributeReplicasConditional.TEST_MODE_ENABLED isn't final but should be At DistributeReplicasConditional.java:be At DistributeReplicasConditional.java:[line 41] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 2b69ae540c78 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / e4e6bb5af591986ab426ee1368afbddd6bcd1ce1 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/3/artifact/yetus-general-check/output/patch-javac-3.3.6.txt |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/3/artifact/yetus-general-check/output/patch-javac-3.4.0.txt |
| Max. process+thread count | 84 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/3/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2544006633
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 52s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 54s | | master passed |
| +1 :green_heart: | compile | 1m 10s | | master passed |
| +1 :green_heart: | javadoc | 0m 41s | | master passed |
| +1 :green_heart: | shadedjars | 5m 7s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 55s | | the patch passed |
| +1 :green_heart: | compile | 1m 13s | | the patch passed |
| +1 :green_heart: | javac | 1m 13s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 41s | | the patch passed |
| +1 :green_heart: | shadedjars | 4m 55s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 14m 56s | [/patch-unit-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/5/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -1 :x: | unit | 12m 49s | [/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/5/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt) | hbase-server in the patch failed. |
| | | 50m 36s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux b6fd49421364 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 3bd96be985e7f8525b3d3f39743af62e8a6dc2f0 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/5/testReport/ |
| Max. process+thread count | 1814 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/5/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2544037313
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 30s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 31s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 12s | | master passed |
| +1 :green_heart: | compile | 3m 26s | | master passed |
| +1 :green_heart: | checkstyle | 0m 47s | | master passed |
| +1 :green_heart: | spotbugs | 1m 52s | | master passed |
| +1 :green_heart: | spotless | 0m 43s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 55s | | the patch passed |
| +1 :green_heart: | compile | 3m 31s | | the patch passed |
| -0 :warning: | javac | 0m 27s | [/results-compile-javac-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/6/artifact/yetus-general-check/output/results-compile-javac-hbase-balancer.txt) | hbase-balancer generated 8 new + 70 unchanged - 0 fixed = 78 total (was 70) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 0m 9s | [/results-checkstyle-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/6/artifact/yetus-general-check/output/results-checkstyle-hbase-balancer.txt) | hbase-balancer: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) |
| -0 :warning: | checkstyle | 0m 37s | [/results-checkstyle-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/6/artifact/yetus-general-check/output/results-checkstyle-hbase-server.txt) | hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| -1 :x: | spotbugs | 0m 34s | [/new-spotbugs-hbase-balancer.html](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/6/artifact/yetus-general-check/output/new-spotbugs-hbase-balancer.html) | hbase-balancer generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| +1 :green_heart: | hadoopcheck | 11m 25s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 43s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 17s | | The patch does not generate ASF License warnings. |
| | | 40m 17s | | |
| Reason | Tests |
|-------:|:------|
| SpotBugs | module:hbase-balancer |
| | org.apache.hadoop.hbase.master.balancer.DistributeReplicasConditional.TEST_MODE_ENABLED_KEY isn't final but should be At DistributeReplicasConditional.java:be At DistributeReplicasConditional.java:[line 41] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/6/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 3e19b125211e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 860d8b71de00cd9c75192ebbd9c31c12a201df7b |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 83 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/6/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2544604042
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 39s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 34s | | master passed |
| +1 :green_heart: | compile | 1m 7s | | master passed |
| +1 :green_heart: | javadoc | 0m 39s | | master passed |
| +1 :green_heart: | shadedjars | 4m 53s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 39s | | the patch passed |
| +1 :green_heart: | compile | 1m 9s | | the patch passed |
| +1 :green_heart: | javac | 1m 9s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 39s | | the patch passed |
| +1 :green_heart: | shadedjars | 4m 48s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 13m 13s | [/patch-unit-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/7/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -1 :x: | unit | 190m 32s | [/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/7/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt) | hbase-server in the patch failed. |
| | | 227m 46s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/7/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux cfecee48beb1 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / a89d1740a402555c15b75d102d8e04b66aea8e36 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/7/testReport/ |
| Max. process+thread count | 4526 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/7/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2542604855
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 51s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 53s | | master passed |
| +1 :green_heart: | compile | 1m 7s | | master passed |
| +1 :green_heart: | javadoc | 0m 42s | | master passed |
| +1 :green_heart: | shadedjars | 4m 58s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 1m 19s | [/patch-mvninstall-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/2/artifact/yetus-jdk17-hadoop3-check/output/patch-mvninstall-root.txt) | root in the patch failed. |
| -1 :x: | compile | 0m 20s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/2/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 20s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/2/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| +1 :green_heart: | javadoc | 0m 42s | | the patch passed |
| -1 :x: | shadedjars | 3m 11s | | patch has 16 errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 0m 16s | [/patch-unit-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/2/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -1 :x: | unit | 0m 20s | [/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/2/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt) | hbase-server in the patch failed. |
| | | 18m 25s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 47f0b6f8f440 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 517c43bf8b32c5abcad326a06cbc2b07a38bcb8f |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/2/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/2/testReport/ |
| Max. process+thread count | 84 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/2/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "rmdmattingly (via GitHub)" <gi...@apache.org>.
rmdmattingly commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2580969987
Closing this in favor of a new, clean PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2544167794
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 48s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 39s | | master passed |
| +1 :green_heart: | compile | 1m 8s | | master passed |
| +1 :green_heart: | javadoc | 0m 40s | | master passed |
| +1 :green_heart: | shadedjars | 4m 48s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 37s | | the patch passed |
| +1 :green_heart: | compile | 1m 8s | | the patch passed |
| +1 :green_heart: | javac | 1m 8s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 39s | | the patch passed |
| +1 :green_heart: | shadedjars | 4m 49s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 13m 12s | [/patch-unit-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/6/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -1 :x: | unit | 190m 16s | [/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/6/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt) | hbase-server in the patch failed. |
| | | 227m 51s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 68e4cd460ce9 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 860d8b71de00cd9c75192ebbd9c31c12a201df7b |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/6/testReport/ |
| Max. process+thread count | 4616 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/6/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2568368926
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 30s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 21s | | master passed |
| +1 :green_heart: | compile | 1m 37s | | master passed |
| +1 :green_heart: | javadoc | 0m 45s | | master passed |
| +1 :green_heart: | shadedjars | 6m 7s | | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | patch | 6m 22s | | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 1m 24s | [/patch-mvninstall-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/17/artifact/yetus-jdk17-hadoop3-check/output/patch-mvninstall-root.txt) | root in the patch failed. |
| -1 :x: | compile | 0m 9s | [/patch-compile-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/17/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -1 :x: | compile | 1m 0s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/17/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 9s | [/patch-compile-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/17/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -0 :warning: | javac | 1m 0s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/17/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| +1 :green_heart: | javadoc | 0m 41s | | the patch passed |
| -1 :x: | shadedjars | 3m 36s | | patch has 10 errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 0m 9s | [/patch-unit-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/17/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -1 :x: | unit | 0m 57s | [/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/17/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt) | hbase-server in the patch failed. |
| | | 21m 43s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/17/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux ec260601f580 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 757173f546f62a38a19a5e7bcc26371a6c7ba725 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/17/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/17/testReport/ |
| Max. process+thread count | 82 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/17/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2568497080
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 29s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 55s | | master passed |
| +1 :green_heart: | compile | 3m 33s | | master passed |
| +1 :green_heart: | checkstyle | 0m 44s | | master passed |
| +1 :green_heart: | spotbugs | 2m 5s | | master passed |
| +1 :green_heart: | spotless | 0m 48s | | branch has no errors when running spotless:check. |
| -0 :warning: | patch | 1m 1s | | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 57s | | the patch passed |
| +1 :green_heart: | compile | 3m 30s | | the patch passed |
| +1 :green_heart: | javac | 0m 24s | | hbase-balancer generated 0 new + 65 unchanged - 5 fixed = 65 total (was 70) |
| +1 :green_heart: | javac | 3m 6s | | hbase-server in the patch passed. |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 43s | | the patch passed |
| +1 :green_heart: | spotbugs | 2m 9s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 11m 8s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 43s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 16s | | The patch does not generate ASF License warnings. |
| | | 39m 42s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/18/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 816c4a266183 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / e7135512ba2c111874705b53aa72b7a28f38530e |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 84 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/18/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2566499977
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 54s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 54s | | master passed |
| +1 :green_heart: | compile | 1m 11s | | master passed |
| +1 :green_heart: | javadoc | 0m 41s | | master passed |
| +1 :green_heart: | shadedjars | 4m 58s | | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | patch | 5m 15s | | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 1m 18s | [/patch-mvninstall-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/13/artifact/yetus-jdk17-hadoop3-check/output/patch-mvninstall-root.txt) | root in the patch failed. |
| -1 :x: | compile | 0m 54s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/13/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 54s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/13/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| +1 :green_heart: | javadoc | 0m 42s | | the patch passed |
| -1 :x: | shadedjars | 3m 7s | | patch has 11 errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 0m 17s | [/patch-unit-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/13/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -1 :x: | unit | 0m 52s | [/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/13/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt) | hbase-server in the patch failed. |
| | | 19m 32s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/13/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux d42cf81a423b 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b85d6900c512f1e86094b1d0ba0c2e65f7635171 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/13/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/13/testReport/ |
| Max. process+thread count | 76 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/13/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "rmdmattingly (via GitHub)" <gi...@apache.org>.
rmdmattingly closed pull request #6543: HBASE-28513 The StochasticLoadBalancer should support discrete evaluations
URL: https://github.com/apache/hbase/pull/6543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2564071540
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 51s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 59s | | master passed |
| +1 :green_heart: | compile | 1m 15s | | master passed |
| +1 :green_heart: | javadoc | 0m 42s | | master passed |
| +1 :green_heart: | shadedjars | 5m 8s | | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | patch | 5m 25s | | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 1m 17s | [/patch-mvninstall-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/10/artifact/yetus-jdk17-hadoop3-check/output/patch-mvninstall-root.txt) | root in the patch failed. |
| -1 :x: | compile | 0m 11s | [/patch-compile-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/10/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -1 :x: | compile | 0m 42s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/10/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 11s | [/patch-compile-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/10/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -0 :warning: | javac | 0m 42s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/10/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| +1 :green_heart: | javadoc | 0m 46s | | the patch passed |
| -1 :x: | shadedjars | 3m 3s | | patch has 10 errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 0m 10s | [/patch-unit-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/10/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -1 :x: | unit | 0m 42s | [/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/10/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt) | hbase-server in the patch failed. |
| | | 19m 23s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/10/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux a840e6ecc61b 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / e5ab24cdcefe2438c8d2b957595683c24ca1683b |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/10/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/10/testReport/ |
| Max. process+thread count | 83 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/10/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "charlesconnell (via GitHub)" <gi...@apache.org>.
charlesconnell commented on code in PR #6543:
URL: https://github.com/apache/hbase/pull/6543#discussion_r1899138346
##########
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/BalancerConditionals.java:
##########
@@ -0,0 +1,219 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.balancer;
+
+import java.lang.reflect.Constructor;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Objects;
+import java.util.Optional;
+import java.util.Set;
+import java.util.stream.Collectors;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.master.RegionPlan;
+import org.apache.hadoop.hbase.util.ReflectionUtils;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hbase.thirdparty.com.google.common.collect.ImmutableSet;
+
+/**
+ * Balancer conditionals supplement cost functions in the {@link StochasticLoadBalancer}. Cost
+ * functions are insufficient and difficult to work with when making discrete decisions; this is
+ * because they operate on a continuous scale, and each cost function's multiplier affects the
+ * relative importance of every other cost function. So it is difficult to meaningfully and clearly
+ * value many aspects of your region distribution via cost functions alone. Conditionals allow you
+ * to very clearly define discrete rules that your balancer would ideally follow. To clarify, a
+ * conditional violation will not block a region assignment because we would prefer to have uptime
+ * than have perfectly intentional balance. But conditionals allow you to, for example, define that
+ * a region's primary and secondary should not live on the same rack. Another example, conditionals
+ * make it easy to define that system tables will ideally be isolated on their own RegionServer.
+ */
+@InterfaceAudience.Private
+public final class BalancerConditionals {
+
+ private static final Logger LOG = LoggerFactory.getLogger(BalancerConditionals.class);
+
+ static final BalancerConditionals INSTANCE = new BalancerConditionals();
+ public static final String ISOLATE_SYSTEM_TABLES_KEY =
+ "hbase.master.balancer.stochastic.conditionals.isolateSystemTables";
+ public static final boolean ISOLATE_SYSTEM_TABLES_DEFAULT = false;
+
+ public static final String ISOLATE_META_TABLE_KEY =
+ "hbase.master.balancer.stochastic.conditionals.isolateMetaTable";
+ public static final boolean ISOLATE_META_TABLE_DEFAULT = false;
+
+ public static final String DISTRIBUTE_REPLICAS_CONDITIONALS_KEY =
+ "hbase.master.balancer.stochastic.conditionals.distributeReplicas";
+ public static final boolean DISTRIBUTE_REPLICAS_CONDITIONALS_DEFAULT = false;
+
+ public static final String ADDITIONAL_CONDITIONALS_KEY =
+ "hbase.master.balancer.stochastic.additionalConditionals";
+
+ private Set<Class<? extends RegionPlanConditional>> conditionalClasses = Collections.emptySet();
+ private Set<RegionPlanConditional> conditionals = Collections.emptySet();
+ private Configuration conf;
+
+ private BalancerConditionals() {
+ }
+
+ boolean shouldRunBalancer(BalancerClusterState cluster) {
+ return isConditionalBalancingEnabled() && conditionals.stream()
+ .map(RegionPlanConditional::getCandidateGenerator).flatMap(Optional::stream)
+ .map(generator -> generator.getWeight(cluster)).anyMatch(weight -> weight > 0);
+ }
+
+ Set<Class<? extends RegionPlanConditional>> getConditionalClasses() {
+ return Set.copyOf(conditionalClasses);
+ }
+
+ Collection<RegionPlanConditional> getConditionals() {
+ return conditionals;
+ }
+
+ boolean isMetaTableIsolationEnabled() {
+ return conditionalClasses.contains(MetaTableIsolationConditional.class);
+ }
+
+ boolean isSystemTableIsolationEnabled() {
+ return conditionalClasses.contains(SystemTableIsolationConditional.class);
+ }
+
+ boolean isReplicaDistributionEnabled() {
+ return conditionalClasses.contains(DistributeReplicasConditional.class);
+ }
+
+ boolean shouldSkipSloppyServerEvaluation() {
+ return isConditionalBalancingEnabled();
+ }
+
+ void clearConditionalWeightCaches() {
+ conditionals.stream().map(RegionPlanConditional::getCandidateGenerator)
+ .flatMap(Optional::stream).forEach(RegionPlanConditionalCandidateGenerator::clearWeightCache);
+ }
+
+ void loadConf(Configuration conf) {
Review Comment:
You can have BalancerConditionals implement Configurable or BaseConfigurable to do this in a more consistent way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2564143142
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 51s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 41s | | master passed |
| +1 :green_heart: | compile | 1m 15s | | master passed |
| +1 :green_heart: | javadoc | 0m 40s | | master passed |
| +1 :green_heart: | shadedjars | 5m 17s | | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | patch | 5m 35s | | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 1m 16s | [/patch-mvninstall-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/12/artifact/yetus-jdk17-hadoop3-check/output/patch-mvninstall-root.txt) | root in the patch failed. |
| -1 :x: | compile | 0m 42s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/12/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 42s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/12/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| +1 :green_heart: | javadoc | 0m 40s | | the patch passed |
| -1 :x: | shadedjars | 3m 2s | | patch has 11 errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 0m 16s | [/patch-unit-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/12/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -1 :x: | unit | 0m 44s | [/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/12/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt) | hbase-server in the patch failed. |
| | | 19m 16s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/12/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 03005280fe47 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 7d18dc9f4a3273721a8bb8ee5f99717504be95a5 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/12/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/12/testReport/ |
| Max. process+thread count | 83 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/12/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2564092819
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 52s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 43s | | master passed |
| +1 :green_heart: | compile | 1m 14s | | master passed |
| +1 :green_heart: | javadoc | 0m 41s | | master passed |
| +1 :green_heart: | shadedjars | 4m 56s | | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | patch | 5m 14s | | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 1m 18s | [/patch-mvninstall-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-jdk17-hadoop3-check/output/patch-mvninstall-root.txt) | root in the patch failed. |
| -1 :x: | compile | 0m 43s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 43s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| +1 :green_heart: | javadoc | 0m 38s | | the patch passed |
| -1 :x: | shadedjars | 3m 5s | | patch has 11 errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 0m 18s | [/patch-unit-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -1 :x: | unit | 0m 46s | [/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt) | hbase-server in the patch failed. |
| | | 18m 56s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux e2bf10999a13 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / ee8c5521c435829869bf20f5692b2f550190f495 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/testReport/ |
| Max. process+thread count | 79 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2566501629
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 29s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 37s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 32s | | master passed |
| +1 :green_heart: | compile | 3m 35s | | master passed |
| +1 :green_heart: | checkstyle | 0m 46s | | master passed |
| +1 :green_heart: | spotbugs | 2m 0s | | master passed |
| +1 :green_heart: | spotless | 0m 46s | | branch has no errors when running spotless:check. |
| -0 :warning: | patch | 0m 58s | | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 1m 18s | [/patch-mvninstall-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/13/artifact/yetus-general-check/output/patch-mvninstall-root.txt) | root in the patch failed. |
| -1 :x: | compile | 0m 17s | [/patch-compile-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/13/artifact/yetus-general-check/output/patch-compile-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -1 :x: | compile | 1m 41s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/13/artifact/yetus-general-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 17s | [/patch-compile-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/13/artifact/yetus-general-check/output/patch-compile-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -0 :warning: | javac | 1m 41s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/13/artifact/yetus-general-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 0m 8s | [/results-checkstyle-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/13/artifact/yetus-general-check/output/results-checkstyle-hbase-balancer.txt) | hbase-balancer: The patch generated 2 new + 3 unchanged - 0 fixed = 5 total (was 3) |
| -1 :x: | spotbugs | 0m 44s | [/patch-spotbugs-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/13/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt) | hbase-server in the patch failed. |
| -1 :x: | hadoopcheck | 1m 8s | | The patch causes 11 errors with Hadoop v3.3.6. |
| -1 :x: | hadoopcheck | 2m 16s | | The patch causes 11 errors with Hadoop v3.4.0. |
| +1 :green_heart: | spotless | 0m 43s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 15s | | The patch does not generate ASF License warnings. |
| | | 21m 56s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/13/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 919d7fc687ae 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b85d6900c512f1e86094b1d0ba0c2e65f7635171 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/13/artifact/yetus-general-check/output/patch-javac-3.3.6.txt |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/13/artifact/yetus-general-check/output/patch-javac-3.4.0.txt |
| Max. process+thread count | 84 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/13/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2567909373
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 35s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 38s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 27s | | master passed |
| +1 :green_heart: | compile | 3m 41s | | master passed |
| +1 :green_heart: | checkstyle | 0m 49s | | master passed |
| +1 :green_heart: | spotbugs | 2m 4s | | master passed |
| +1 :green_heart: | spotless | 0m 53s | | branch has no errors when running spotless:check. |
| -0 :warning: | patch | 1m 6s | | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 2s | | the patch passed |
| +1 :green_heart: | compile | 3m 31s | | the patch passed |
| +1 :green_heart: | javac | 0m 24s | | hbase-balancer generated 0 new + 65 unchanged - 5 fixed = 65 total (was 70) |
| +1 :green_heart: | javac | 3m 7s | | hbase-server in the patch passed. |
| +1 :green_heart: | blanks | 0m 1s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 45s | | the patch passed |
| +1 :green_heart: | spotbugs | 2m 10s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 11m 24s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 47s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 19s | | The patch does not generate ASF License warnings. |
| | | 41m 34s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/16/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 58b106256bf6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b9c9c5aa7bf9e3f27436b77715371532c2de63ac |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 83 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/16/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2547365928
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 30s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 37s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 3s | | master passed |
| +1 :green_heart: | compile | 1m 23s | | master passed |
| +1 :green_heart: | javadoc | 0m 47s | | master passed |
| +1 :green_heart: | shadedjars | 6m 59s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 52s | | the patch passed |
| +1 :green_heart: | compile | 1m 37s | | the patch passed |
| +1 :green_heart: | javac | 1m 37s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 47s | | the patch passed |
| +1 :green_heart: | shadedjars | 7m 4s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 9m 22s | | hbase-balancer in the patch passed. |
| -1 :x: | unit | 196m 10s | [/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/9/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt) | hbase-server in the patch failed. |
| | | 238m 9s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/9/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux bb428bf34b8f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / f643db90597b8cc6623629cf656fa7f7a54c3e9d |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/9/testReport/ |
| Max. process+thread count | 6409 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/9/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "rmdmattingly (via GitHub)" <gi...@apache.org>.
rmdmattingly commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2543331850
Still cleaning this up with the help of the build logs. Will mark as a draft for now. I believe the code is working quite well though, so please feel free to review the proposal and meat of the changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2542605108
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 29s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 54s | | master passed |
| +1 :green_heart: | compile | 3m 39s | | master passed |
| +1 :green_heart: | checkstyle | 0m 44s | | master passed |
| +1 :green_heart: | spotbugs | 1m 53s | | master passed |
| +1 :green_heart: | spotless | 0m 43s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 1m 16s | [/patch-mvninstall-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt) | root in the patch failed. |
| -1 :x: | compile | 0m 20s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 22s | [/results-compile-javac-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/2/artifact/yetus-general-check/output/results-compile-javac-hbase-balancer.txt) | hbase-balancer generated 7 new + 70 unchanged - 0 fixed = 77 total (was 70) |
| -0 :warning: | javac | 0m 20s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 0m 7s | [/results-checkstyle-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/2/artifact/yetus-general-check/output/results-checkstyle-hbase-balancer.txt) | hbase-balancer: The patch generated 6 new + 1 unchanged - 0 fixed = 7 total (was 1) |
| -0 :warning: | checkstyle | 0m 34s | [/results-checkstyle-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/2/artifact/yetus-general-check/output/results-checkstyle-hbase-server.txt) | hbase-server: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) |
| -1 :x: | spotbugs | 0m 30s | [/new-spotbugs-hbase-balancer.html](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/2/artifact/yetus-general-check/output/new-spotbugs-hbase-balancer.html) | hbase-balancer generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) |
| -1 :x: | spotbugs | 0m 20s | [/patch-spotbugs-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/2/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt) | hbase-server in the patch failed. |
| -1 :x: | hadoopcheck | 1m 4s | | The patch causes 16 errors with Hadoop v3.3.6. |
| -1 :x: | hadoopcheck | 2m 9s | | The patch causes 16 errors with Hadoop v3.4.0. |
| +1 :green_heart: | spotless | 0m 41s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 14s | | The patch does not generate ASF License warnings. |
| | | 19m 0s | | |
| Reason | Tests |
|-------:|:------|
| SpotBugs | module:hbase-balancer |
| | org.apache.hadoop.hbase.master.balancer.BalancerConditionals.INSTANCE isn't final but should be At BalancerConditionals.java:be At BalancerConditionals.java:[line 50] |
| | org.apache.hadoop.hbase.master.balancer.DistributeReplicasConditional.TEST_MODE_ENABLED isn't final but should be At DistributeReplicasConditional.java:be At DistributeReplicasConditional.java:[line 39] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 08894e1b3153 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 517c43bf8b32c5abcad326a06cbc2b07a38bcb8f |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/2/artifact/yetus-general-check/output/patch-javac-3.3.6.txt |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/2/artifact/yetus-general-check/output/patch-javac-3.4.0.txt |
| Max. process+thread count | 83 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/2/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2568608562
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 31s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 17s | | master passed |
| +1 :green_heart: | compile | 1m 12s | | master passed |
| +1 :green_heart: | javadoc | 0m 40s | | master passed |
| +1 :green_heart: | shadedjars | 6m 8s | | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | patch | 6m 24s | | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 6s | | the patch passed |
| +1 :green_heart: | compile | 1m 11s | | the patch passed |
| +1 :green_heart: | javac | 1m 11s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 39s | | the patch passed |
| +1 :green_heart: | shadedjars | 5m 56s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 10m 39s | [/patch-unit-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/18/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| +1 :green_heart: | unit | 186m 18s | | hbase-server in the patch passed. |
| | | 224m 11s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/18/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 58ed600a1b89 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / e7135512ba2c111874705b53aa72b7a28f38530e |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/18/testReport/ |
| Max. process+thread count | 5230 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/18/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2564093375
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 28s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 2s | | master passed |
| +1 :green_heart: | compile | 3m 33s | | master passed |
| +1 :green_heart: | checkstyle | 0m 44s | | master passed |
| +1 :green_heart: | spotbugs | 1m 53s | | master passed |
| +1 :green_heart: | spotless | 0m 43s | | branch has no errors when running spotless:check. |
| -0 :warning: | patch | 0m 55s | | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 1m 19s | [/patch-mvninstall-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-general-check/output/patch-mvninstall-root.txt) | root in the patch failed. |
| -1 :x: | compile | 0m 16s | [/patch-compile-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-general-check/output/patch-compile-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -1 :x: | compile | 1m 45s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-general-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| -0 :warning: | javac | 0m 16s | [/patch-compile-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-general-check/output/patch-compile-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -0 :warning: | javac | 1m 45s | [/patch-compile-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-general-check/output/patch-compile-hbase-server.txt) | hbase-server in the patch failed. |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 0m 8s | [/results-checkstyle-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-general-check/output/results-checkstyle-hbase-balancer.txt) | hbase-balancer: The patch generated 2 new + 3 unchanged - 0 fixed = 5 total (was 3) |
| -1 :x: | spotbugs | 0m 34s | [/new-spotbugs-hbase-balancer.html](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-general-check/output/new-spotbugs-hbase-balancer.html) | hbase-balancer generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) |
| -1 :x: | spotbugs | 0m 33s | [/patch-spotbugs-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt) | hbase-server in the patch failed. |
| -1 :x: | hadoopcheck | 1m 5s | | The patch causes 11 errors with Hadoop v3.3.6. |
| -1 :x: | hadoopcheck | 2m 10s | | The patch causes 11 errors with Hadoop v3.4.0. |
| +1 :green_heart: | spotless | 0m 46s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 15s | | The patch does not generate ASF License warnings. |
| | | 20m 46s | | |
| Reason | Tests |
|-------:|:------|
| SpotBugs | module:hbase-balancer |
| | Return value of addRegions(int[], Set) ignored, but method has no side effect At BalancerClusterState.java:ignored, but method has no side effect At BalancerClusterState.java:[line 785] |
| | Integer is incompatible with expected argument type Class<? extends org.apache.hadoop.hbase.master.balancer.CandidateGenerator> in org.apache.hadoop.hbase.master.balancer.FavoredStochasticBalancer.getRandomGenerator(BalancerClusterState) At FavoredStochasticBalancer.java:argument type Class<? extends org.apache.hadoop.hbase.master.balancer.CandidateGenerator> in org.apache.hadoop.hbase.master.balancer.FavoredStochasticBalancer.getRandomGenerator(BalancerClusterState) At FavoredStochasticBalancer.java:[line 94] |
| | Format string should use %n rather than n in org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer.lambda$balanceTable$4(Map, StringBuilder, Class, Long) At StochasticLoadBalancer.java:rather than n in org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer.lambda$balanceTable$4(Map, StringBuilder, Class, Long) At StochasticLoadBalancer.java:[line 631] |
| | org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer.getRandomGenerator(BalancerClusterState) makes inefficient use of keySet iterator instead of entrySet iterator At StochasticLoadBalancer.java:keySet iterator instead of entrySet iterator At StochasticLoadBalancer.java:[line 469] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 25eead892fcc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / ee8c5521c435829869bf20f5692b2f550190f495 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-general-check/output/patch-javac-3.3.6.txt |
| hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/artifact/yetus-general-check/output/patch-javac-3.4.0.txt |
| Max. process+thread count | 85 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/11/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2543327401
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 49s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
|||| _ Prechecks _ |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 50s | | master passed |
| +1 :green_heart: | compile | 1m 22s | | master passed |
| +1 :green_heart: | javadoc | 0m 52s | | master passed |
| +1 :green_heart: | shadedjars | 5m 25s | | branch has no errors when building our shaded downstream artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 43s | | the patch passed |
| +1 :green_heart: | compile | 1m 8s | | the patch passed |
| +1 :green_heart: | javac | 1m 8s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 40s | | the patch passed |
| +1 :green_heart: | shadedjars | 4m 58s | | patch has no errors when building our shaded downstream artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 0m 31s | [/patch-unit-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/4/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -1 :x: | unit | 17m 10s | [/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/4/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt) | hbase-server in the patch failed. |
| | | 40m 47s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 13b5c930751a 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / ea9992e3224608fad1091a02409743261bebcc5a |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/4/testReport/ |
| Max. process+thread count | 1781 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/4/console |
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2544323444
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 29s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 41s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 37s | | master passed |
| +1 :green_heart: | compile | 3m 27s | | master passed |
| +1 :green_heart: | checkstyle | 0m 45s | | master passed |
| +1 :green_heart: | spotbugs | 1m 59s | | master passed |
| +1 :green_heart: | spotless | 0m 45s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 1s | | the patch passed |
| +1 :green_heart: | compile | 3m 23s | | the patch passed |
| -0 :warning: | javac | 0m 23s | [/results-compile-javac-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/7/artifact/yetus-general-check/output/results-compile-javac-hbase-balancer.txt) | hbase-balancer generated 8 new + 70 unchanged - 0 fixed = 78 total (was 70) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 0m 8s | [/results-checkstyle-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/7/artifact/yetus-general-check/output/results-checkstyle-hbase-balancer.txt) | hbase-balancer: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) |
| -0 :warning: | checkstyle | 0m 35s | [/results-checkstyle-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/7/artifact/yetus-general-check/output/results-checkstyle-hbase-server.txt) | hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| -1 :x: | spotbugs | 0m 31s | [/new-spotbugs-hbase-balancer.html](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/7/artifact/yetus-general-check/output/new-spotbugs-hbase-balancer.html) | hbase-balancer generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| +1 :green_heart: | hadoopcheck | 11m 39s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 43s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 17s | | The patch does not generate ASF License warnings. |
| | | 41m 21s | | |
| Reason | Tests |
|-------:|:------|
| SpotBugs | module:hbase-balancer |
| | org.apache.hadoop.hbase.master.balancer.DistributeReplicasConditional.TEST_MODE_ENABLED_KEY isn't final but should be At DistributeReplicasConditional.java:be At DistributeReplicasConditional.java:[line 41] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/7/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 8daf596026aa 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / a89d1740a402555c15b75d102d8e04b66aea8e36 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 85 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/7/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2547072410
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 34s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 42s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 31s | | master passed |
| +1 :green_heart: | compile | 3m 37s | | master passed |
| +1 :green_heart: | checkstyle | 0m 45s | | master passed |
| +1 :green_heart: | spotbugs | 1m 57s | | master passed |
| +1 :green_heart: | spotless | 0m 46s | | branch has no errors when running spotless:check. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 52s | | the patch passed |
| +1 :green_heart: | compile | 3m 27s | | the patch passed |
| -0 :warning: | javac | 0m 23s | [/results-compile-javac-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/9/artifact/yetus-general-check/output/results-compile-javac-hbase-balancer.txt) | hbase-balancer generated 7 new + 70 unchanged - 0 fixed = 77 total (was 70) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 0m 36s | [/results-checkstyle-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/9/artifact/yetus-general-check/output/results-checkstyle-hbase-server.txt) | hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| +1 :green_heart: | spotbugs | 2m 8s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 11m 9s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 42s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 17s | | The patch does not generate ASF License warnings. |
| | | 40m 34s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/9/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 967c130a72f5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / f643db90597b8cc6623629cf656fa7f7a54c3e9d |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 84 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/9/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "rmdmattingly (via GitHub)" <gi...@apache.org>.
rmdmattingly commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2564080995
Gonna be a ton of build issues to work through I'm sure, will tackle those
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-28513 The StochasticLoadBalancer should support discrete evaluations [hbase]
Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6543:
URL: https://github.com/apache/hbase/pull/6543#issuecomment-2566554612
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 26s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any anti-patterns. |
|||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 15s | | master passed |
| +1 :green_heart: | compile | 3m 30s | | master passed |
| +1 :green_heart: | checkstyle | 0m 46s | | master passed |
| +1 :green_heart: | spotbugs | 1m 55s | | master passed |
| +1 :green_heart: | spotless | 0m 45s | | branch has no errors when running spotless:check. |
| -0 :warning: | patch | 0m 57s | | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 4s | | the patch passed |
| -1 :x: | compile | 0m 18s | [/patch-compile-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/14/artifact/yetus-general-check/output/patch-compile-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| -0 :warning: | javac | 0m 18s | [/patch-compile-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/14/artifact/yetus-general-check/output/patch-compile-hbase-balancer.txt) | hbase-balancer in the patch failed. |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 0m 8s | [/results-checkstyle-hbase-balancer.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/14/artifact/yetus-general-check/output/results-checkstyle-hbase-balancer.txt) | hbase-balancer: The patch generated 2 new + 3 unchanged - 0 fixed = 5 total (was 3) |
| +1 :green_heart: | spotbugs | 2m 11s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 11m 41s | | Patch does not cause any errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 45s | | patch has no errors when running spotless:check. |
|||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 17s | | The patch does not generate ASF License warnings. |
| | | 40m 31s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/14/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/6543 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 9c33e8c81b44 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 8ac0c7acb9ad63808b3381a90eee64617202a037 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 84 (vs. ulimit of 30000) |
| modules | C: hbase-balancer hbase-server U: . |
| Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6543/14/console |
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org