You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/11/02 09:13:52 UTC
[GitHub] [incubator-doris] chovy-3012 opened a new pull request #6994: [Revert] Revert RestService.java
chovy-3012 opened a new pull request #6994:
URL: https://github.com/apache/incubator-doris/pull/6994
## Proposed changes
Revert RestService.java to last version (#6761 8d471007a62ffbd1d628620c4f0c44b8b6e94a8a)
```shell
git diff 8d471007a62ffbd1d628620c4f0c44b8b6e94a8a 52235a4c45757fde960d3506d85b56c25f9953bc ./extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java
```
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [ ] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] chovy-3012 commented on a change in pull request #6994: [Revert] Revert RestService.java
Posted by GitBox <gi...@apache.org>.
chovy-3012 commented on a change in pull request #6994:
URL: https://github.com/apache/incubator-doris/pull/6994#discussion_r740996030
##########
File path: extension/spark-doris-connector/src/test/java/org/apache/doris/spark/rest/TestRestService.java
##########
@@ -293,4 +294,11 @@ public void testTabletsMapToPartition() throws Exception {
Assert.assertEquals(expected, actual);
}
+
+ @Test
+ public void testParseBackend() throws Exception {
+ String response = "{\"href_columns\":[\"BackendId\"],\"parent_url\":\"/rest/v1/system?path=/\",\"column_names\":[\"BackendId\",\"Cluster\",\"IP\",\"HostName\",\"HeartbeatPort\",\"BePort\",\"HttpPort\",\"BrpcPort\",\"LastStartTime\",\"LastHeartbeat\",\"Alive\",\"SystemDecommissioned\",\"ClusterDecommissioned\",\"TabletNum\",\"DataUsedCapacity\",\"AvailCapacity\",\"TotalCapacity\",\"UsedPct\",\"MaxDiskUsedPct\",\"Tag\",\"ErrMsg\",\"Version\",\"Status\"],\"rows\":[{\"HttpPort\":\"8040\",\"Status\":\"{\\\"lastSuccessReportTabletsTime\\\":\\\"N/A\\\",\\\"lastStreamLoadTime\\\":-1}\",\"SystemDecommissioned\":\"false\",\"LastHeartbeat\":\"\\\\N\",\"DataUsedCapacity\":\"0.000 \",\"ErrMsg\":\"\",\"IP\":\"127.0.0.1\",\"UsedPct\":\"0.00 %\",\"__hrefPaths\":[\"/rest/v1/system?path=//backends/10002\"],\"Cluster\":\"default_cluster\",\"Alive\":\"true\",\"MaxDiskUsedPct\":\"0.00 %\",\"BrpcPort\":\"-1\",\"BePort\":\"-1\",\"ClusterDecommissioned\":\"false\",\"AvailCapacity\":\"1.000 B\",\"Ve
rsion\":\"\",\"BackendId\":\"10002\",\"HeartbeatPort\":\"9050\",\"LastStartTime\":\"\\\\N\",\"TabletNum\":\"0\",\"TotalCapacity\":\"0.000 \",\"Tag\":\"{\\\"location\\\" : \\\"default\\\"}\",\"HostName\":\"localhost\"}]}";
Review comment:
Add parseBackend unit test
##########
File path: extension/spark-doris-connector/src/test/java/org/apache/doris/spark/rest/TestRestService.java
##########
@@ -293,4 +294,11 @@ public void testTabletsMapToPartition() throws Exception {
Assert.assertEquals(expected, actual);
}
+
+ @Test
+ public void testParseBackend() throws Exception {
+ String response = "{\"href_columns\":[\"BackendId\"],\"parent_url\":\"/rest/v1/system?path=/\",\"column_names\":[\"BackendId\",\"Cluster\",\"IP\",\"HostName\",\"HeartbeatPort\",\"BePort\",\"HttpPort\",\"BrpcPort\",\"LastStartTime\",\"LastHeartbeat\",\"Alive\",\"SystemDecommissioned\",\"ClusterDecommissioned\",\"TabletNum\",\"DataUsedCapacity\",\"AvailCapacity\",\"TotalCapacity\",\"UsedPct\",\"MaxDiskUsedPct\",\"Tag\",\"ErrMsg\",\"Version\",\"Status\"],\"rows\":[{\"HttpPort\":\"8040\",\"Status\":\"{\\\"lastSuccessReportTabletsTime\\\":\\\"N/A\\\",\\\"lastStreamLoadTime\\\":-1}\",\"SystemDecommissioned\":\"false\",\"LastHeartbeat\":\"\\\\N\",\"DataUsedCapacity\":\"0.000 \",\"ErrMsg\":\"\",\"IP\":\"127.0.0.1\",\"UsedPct\":\"0.00 %\",\"__hrefPaths\":[\"/rest/v1/system?path=//backends/10002\"],\"Cluster\":\"default_cluster\",\"Alive\":\"true\",\"MaxDiskUsedPct\":\"0.00 %\",\"BrpcPort\":\"-1\",\"BePort\":\"-1\",\"ClusterDecommissioned\":\"false\",\"AvailCapacity\":\"1.000 B\",\"Ve
rsion\":\"\",\"BackendId\":\"10002\",\"HeartbeatPort\":\"9050\",\"LastStartTime\":\"\\\\N\",\"TabletNum\":\"0\",\"TotalCapacity\":\"0.000 \",\"Tag\":\"{\\\"location\\\" : \\\"default\\\"}\",\"HostName\":\"localhost\"}]}";
Review comment:
Add a `parseBackend` method unit test
##########
File path: extension/spark-doris-connector/src/test/java/org/apache/doris/spark/rest/TestRestService.java
##########
@@ -293,4 +294,11 @@ public void testTabletsMapToPartition() throws Exception {
Assert.assertEquals(expected, actual);
}
+
+ @Test
+ public void testParseBackend() throws Exception {
+ String response = "{\"href_columns\":[\"BackendId\"],\"parent_url\":\"/rest/v1/system?path=/\",\"column_names\":[\"BackendId\",\"Cluster\",\"IP\",\"HostName\",\"HeartbeatPort\",\"BePort\",\"HttpPort\",\"BrpcPort\",\"LastStartTime\",\"LastHeartbeat\",\"Alive\",\"SystemDecommissioned\",\"ClusterDecommissioned\",\"TabletNum\",\"DataUsedCapacity\",\"AvailCapacity\",\"TotalCapacity\",\"UsedPct\",\"MaxDiskUsedPct\",\"Tag\",\"ErrMsg\",\"Version\",\"Status\"],\"rows\":[{\"HttpPort\":\"8040\",\"Status\":\"{\\\"lastSuccessReportTabletsTime\\\":\\\"N/A\\\",\\\"lastStreamLoadTime\\\":-1}\",\"SystemDecommissioned\":\"false\",\"LastHeartbeat\":\"\\\\N\",\"DataUsedCapacity\":\"0.000 \",\"ErrMsg\":\"\",\"IP\":\"127.0.0.1\",\"UsedPct\":\"0.00 %\",\"__hrefPaths\":[\"/rest/v1/system?path=//backends/10002\"],\"Cluster\":\"default_cluster\",\"Alive\":\"true\",\"MaxDiskUsedPct\":\"0.00 %\",\"BrpcPort\":\"-1\",\"BePort\":\"-1\",\"ClusterDecommissioned\":\"false\",\"AvailCapacity\":\"1.000 B\",\"Ve
rsion\":\"\",\"BackendId\":\"10002\",\"HeartbeatPort\":\"9050\",\"LastStartTime\":\"\\\\N\",\"TabletNum\":\"0\",\"TotalCapacity\":\"0.000 \",\"Tag\":\"{\\\"location\\\" : \\\"default\\\"}\",\"HostName\":\"localhost\"}]}";
Review comment:
Add a `parseBackend` method unit test
##########
File path: extension/spark-doris-connector/src/test/java/org/apache/doris/spark/rest/TestRestService.java
##########
@@ -293,4 +294,23 @@ public void testTabletsMapToPartition() throws Exception {
Assert.assertEquals(expected, actual);
}
+
+ @Test
+ public void testParseBackend() throws Exception {
+ String response = "{\"href_columns\":[\"BackendId\"],\"parent_url\":\"/rest/v1/system?path=/\"," +
Review comment:
Add a parseBackend method unit test
##########
File path: extension/spark-doris-connector/src/test/java/org/apache/doris/spark/rest/TestRestService.java
##########
@@ -293,4 +294,23 @@ public void testTabletsMapToPartition() throws Exception {
Assert.assertEquals(expected, actual);
}
+
+ @Test
+ public void testParseBackend() throws Exception {
+ String response = "{\"href_columns\":[\"BackendId\"],\"parent_url\":\"/rest/v1/system?path=/\"," +
Review comment:
Add a `parseBackend` method unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] chovy-3012 commented on a change in pull request #6994: [Revert] Revert RestService.java
Posted by GitBox <gi...@apache.org>.
chovy-3012 commented on a change in pull request #6994:
URL: https://github.com/apache/incubator-doris/pull/6994#discussion_r741003996
##########
File path: extension/spark-doris-connector/src/test/java/org/apache/doris/spark/rest/TestRestService.java
##########
@@ -293,4 +294,23 @@ public void testTabletsMapToPartition() throws Exception {
Assert.assertEquals(expected, actual);
}
+
+ @Test
+ public void testParseBackend() throws Exception {
+ String response = "{\"href_columns\":[\"BackendId\"],\"parent_url\":\"/rest/v1/system?path=/\"," +
Review comment:
Add a `parseBackend` method unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #6994: [Revert] Revert RestService.java
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #6994:
URL: https://github.com/apache/incubator-doris/pull/6994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Gabriel39 commented on pull request #6994: [Revert] Revert RestService.java
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on pull request #6994:
URL: https://github.com/apache/incubator-doris/pull/6994#issuecomment-958598951
cc @morningman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] chovy-3012 commented on a change in pull request #6994: [Revert] Revert RestService.java
Posted by GitBox <gi...@apache.org>.
chovy-3012 commented on a change in pull request #6994:
URL: https://github.com/apache/incubator-doris/pull/6994#discussion_r740996030
##########
File path: extension/spark-doris-connector/src/test/java/org/apache/doris/spark/rest/TestRestService.java
##########
@@ -293,4 +294,11 @@ public void testTabletsMapToPartition() throws Exception {
Assert.assertEquals(expected, actual);
}
+
+ @Test
+ public void testParseBackend() throws Exception {
+ String response = "{\"href_columns\":[\"BackendId\"],\"parent_url\":\"/rest/v1/system?path=/\",\"column_names\":[\"BackendId\",\"Cluster\",\"IP\",\"HostName\",\"HeartbeatPort\",\"BePort\",\"HttpPort\",\"BrpcPort\",\"LastStartTime\",\"LastHeartbeat\",\"Alive\",\"SystemDecommissioned\",\"ClusterDecommissioned\",\"TabletNum\",\"DataUsedCapacity\",\"AvailCapacity\",\"TotalCapacity\",\"UsedPct\",\"MaxDiskUsedPct\",\"Tag\",\"ErrMsg\",\"Version\",\"Status\"],\"rows\":[{\"HttpPort\":\"8040\",\"Status\":\"{\\\"lastSuccessReportTabletsTime\\\":\\\"N/A\\\",\\\"lastStreamLoadTime\\\":-1}\",\"SystemDecommissioned\":\"false\",\"LastHeartbeat\":\"\\\\N\",\"DataUsedCapacity\":\"0.000 \",\"ErrMsg\":\"\",\"IP\":\"127.0.0.1\",\"UsedPct\":\"0.00 %\",\"__hrefPaths\":[\"/rest/v1/system?path=//backends/10002\"],\"Cluster\":\"default_cluster\",\"Alive\":\"true\",\"MaxDiskUsedPct\":\"0.00 %\",\"BrpcPort\":\"-1\",\"BePort\":\"-1\",\"ClusterDecommissioned\":\"false\",\"AvailCapacity\":\"1.000 B\",\"Ve
rsion\":\"\",\"BackendId\":\"10002\",\"HeartbeatPort\":\"9050\",\"LastStartTime\":\"\\\\N\",\"TabletNum\":\"0\",\"TotalCapacity\":\"0.000 \",\"Tag\":\"{\\\"location\\\" : \\\"default\\\"}\",\"HostName\":\"localhost\"}]}";
Review comment:
Add parseBackend unit test
##########
File path: extension/spark-doris-connector/src/test/java/org/apache/doris/spark/rest/TestRestService.java
##########
@@ -293,4 +294,11 @@ public void testTabletsMapToPartition() throws Exception {
Assert.assertEquals(expected, actual);
}
+
+ @Test
+ public void testParseBackend() throws Exception {
+ String response = "{\"href_columns\":[\"BackendId\"],\"parent_url\":\"/rest/v1/system?path=/\",\"column_names\":[\"BackendId\",\"Cluster\",\"IP\",\"HostName\",\"HeartbeatPort\",\"BePort\",\"HttpPort\",\"BrpcPort\",\"LastStartTime\",\"LastHeartbeat\",\"Alive\",\"SystemDecommissioned\",\"ClusterDecommissioned\",\"TabletNum\",\"DataUsedCapacity\",\"AvailCapacity\",\"TotalCapacity\",\"UsedPct\",\"MaxDiskUsedPct\",\"Tag\",\"ErrMsg\",\"Version\",\"Status\"],\"rows\":[{\"HttpPort\":\"8040\",\"Status\":\"{\\\"lastSuccessReportTabletsTime\\\":\\\"N/A\\\",\\\"lastStreamLoadTime\\\":-1}\",\"SystemDecommissioned\":\"false\",\"LastHeartbeat\":\"\\\\N\",\"DataUsedCapacity\":\"0.000 \",\"ErrMsg\":\"\",\"IP\":\"127.0.0.1\",\"UsedPct\":\"0.00 %\",\"__hrefPaths\":[\"/rest/v1/system?path=//backends/10002\"],\"Cluster\":\"default_cluster\",\"Alive\":\"true\",\"MaxDiskUsedPct\":\"0.00 %\",\"BrpcPort\":\"-1\",\"BePort\":\"-1\",\"ClusterDecommissioned\":\"false\",\"AvailCapacity\":\"1.000 B\",\"Ve
rsion\":\"\",\"BackendId\":\"10002\",\"HeartbeatPort\":\"9050\",\"LastStartTime\":\"\\\\N\",\"TabletNum\":\"0\",\"TotalCapacity\":\"0.000 \",\"Tag\":\"{\\\"location\\\" : \\\"default\\\"}\",\"HostName\":\"localhost\"}]}";
Review comment:
Add a `parseBackend` method unit test
##########
File path: extension/spark-doris-connector/src/test/java/org/apache/doris/spark/rest/TestRestService.java
##########
@@ -293,4 +294,11 @@ public void testTabletsMapToPartition() throws Exception {
Assert.assertEquals(expected, actual);
}
+
+ @Test
+ public void testParseBackend() throws Exception {
+ String response = "{\"href_columns\":[\"BackendId\"],\"parent_url\":\"/rest/v1/system?path=/\",\"column_names\":[\"BackendId\",\"Cluster\",\"IP\",\"HostName\",\"HeartbeatPort\",\"BePort\",\"HttpPort\",\"BrpcPort\",\"LastStartTime\",\"LastHeartbeat\",\"Alive\",\"SystemDecommissioned\",\"ClusterDecommissioned\",\"TabletNum\",\"DataUsedCapacity\",\"AvailCapacity\",\"TotalCapacity\",\"UsedPct\",\"MaxDiskUsedPct\",\"Tag\",\"ErrMsg\",\"Version\",\"Status\"],\"rows\":[{\"HttpPort\":\"8040\",\"Status\":\"{\\\"lastSuccessReportTabletsTime\\\":\\\"N/A\\\",\\\"lastStreamLoadTime\\\":-1}\",\"SystemDecommissioned\":\"false\",\"LastHeartbeat\":\"\\\\N\",\"DataUsedCapacity\":\"0.000 \",\"ErrMsg\":\"\",\"IP\":\"127.0.0.1\",\"UsedPct\":\"0.00 %\",\"__hrefPaths\":[\"/rest/v1/system?path=//backends/10002\"],\"Cluster\":\"default_cluster\",\"Alive\":\"true\",\"MaxDiskUsedPct\":\"0.00 %\",\"BrpcPort\":\"-1\",\"BePort\":\"-1\",\"ClusterDecommissioned\":\"false\",\"AvailCapacity\":\"1.000 B\",\"Ve
rsion\":\"\",\"BackendId\":\"10002\",\"HeartbeatPort\":\"9050\",\"LastStartTime\":\"\\\\N\",\"TabletNum\":\"0\",\"TotalCapacity\":\"0.000 \",\"Tag\":\"{\\\"location\\\" : \\\"default\\\"}\",\"HostName\":\"localhost\"}]}";
Review comment:
Add a `parseBackend` method unit test
##########
File path: extension/spark-doris-connector/src/test/java/org/apache/doris/spark/rest/TestRestService.java
##########
@@ -293,4 +294,23 @@ public void testTabletsMapToPartition() throws Exception {
Assert.assertEquals(expected, actual);
}
+
+ @Test
+ public void testParseBackend() throws Exception {
+ String response = "{\"href_columns\":[\"BackendId\"],\"parent_url\":\"/rest/v1/system?path=/\"," +
Review comment:
Add a parseBackend method unit test
##########
File path: extension/spark-doris-connector/src/test/java/org/apache/doris/spark/rest/TestRestService.java
##########
@@ -293,4 +294,23 @@ public void testTabletsMapToPartition() throws Exception {
Assert.assertEquals(expected, actual);
}
+
+ @Test
+ public void testParseBackend() throws Exception {
+ String response = "{\"href_columns\":[\"BackendId\"],\"parent_url\":\"/rest/v1/system?path=/\"," +
Review comment:
Add a `parseBackend` method unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] chovy-3012 commented on a change in pull request #6994: [Revert] Revert RestService.java
Posted by GitBox <gi...@apache.org>.
chovy-3012 commented on a change in pull request #6994:
URL: https://github.com/apache/incubator-doris/pull/6994#discussion_r740996030
##########
File path: extension/spark-doris-connector/src/test/java/org/apache/doris/spark/rest/TestRestService.java
##########
@@ -293,4 +294,11 @@ public void testTabletsMapToPartition() throws Exception {
Assert.assertEquals(expected, actual);
}
+
+ @Test
+ public void testParseBackend() throws Exception {
+ String response = "{\"href_columns\":[\"BackendId\"],\"parent_url\":\"/rest/v1/system?path=/\",\"column_names\":[\"BackendId\",\"Cluster\",\"IP\",\"HostName\",\"HeartbeatPort\",\"BePort\",\"HttpPort\",\"BrpcPort\",\"LastStartTime\",\"LastHeartbeat\",\"Alive\",\"SystemDecommissioned\",\"ClusterDecommissioned\",\"TabletNum\",\"DataUsedCapacity\",\"AvailCapacity\",\"TotalCapacity\",\"UsedPct\",\"MaxDiskUsedPct\",\"Tag\",\"ErrMsg\",\"Version\",\"Status\"],\"rows\":[{\"HttpPort\":\"8040\",\"Status\":\"{\\\"lastSuccessReportTabletsTime\\\":\\\"N/A\\\",\\\"lastStreamLoadTime\\\":-1}\",\"SystemDecommissioned\":\"false\",\"LastHeartbeat\":\"\\\\N\",\"DataUsedCapacity\":\"0.000 \",\"ErrMsg\":\"\",\"IP\":\"127.0.0.1\",\"UsedPct\":\"0.00 %\",\"__hrefPaths\":[\"/rest/v1/system?path=//backends/10002\"],\"Cluster\":\"default_cluster\",\"Alive\":\"true\",\"MaxDiskUsedPct\":\"0.00 %\",\"BrpcPort\":\"-1\",\"BePort\":\"-1\",\"ClusterDecommissioned\":\"false\",\"AvailCapacity\":\"1.000 B\",\"Ve
rsion\":\"\",\"BackendId\":\"10002\",\"HeartbeatPort\":\"9050\",\"LastStartTime\":\"\\\\N\",\"TabletNum\":\"0\",\"TotalCapacity\":\"0.000 \",\"Tag\":\"{\\\"location\\\" : \\\"default\\\"}\",\"HostName\":\"localhost\"}]}";
Review comment:
Add parseBackend unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] chovy-3012 commented on a change in pull request #6994: [Revert] Revert RestService.java
Posted by GitBox <gi...@apache.org>.
chovy-3012 commented on a change in pull request #6994:
URL: https://github.com/apache/incubator-doris/pull/6994#discussion_r741003996
##########
File path: extension/spark-doris-connector/src/test/java/org/apache/doris/spark/rest/TestRestService.java
##########
@@ -293,4 +294,23 @@ public void testTabletsMapToPartition() throws Exception {
Assert.assertEquals(expected, actual);
}
+
+ @Test
+ public void testParseBackend() throws Exception {
+ String response = "{\"href_columns\":[\"BackendId\"],\"parent_url\":\"/rest/v1/system?path=/\"," +
Review comment:
Add a parseBackend method unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] chovy-3012 commented on a change in pull request #6994: [Revert] Revert RestService.java
Posted by GitBox <gi...@apache.org>.
chovy-3012 commented on a change in pull request #6994:
URL: https://github.com/apache/incubator-doris/pull/6994#discussion_r740996030
##########
File path: extension/spark-doris-connector/src/test/java/org/apache/doris/spark/rest/TestRestService.java
##########
@@ -293,4 +294,11 @@ public void testTabletsMapToPartition() throws Exception {
Assert.assertEquals(expected, actual);
}
+
+ @Test
+ public void testParseBackend() throws Exception {
+ String response = "{\"href_columns\":[\"BackendId\"],\"parent_url\":\"/rest/v1/system?path=/\",\"column_names\":[\"BackendId\",\"Cluster\",\"IP\",\"HostName\",\"HeartbeatPort\",\"BePort\",\"HttpPort\",\"BrpcPort\",\"LastStartTime\",\"LastHeartbeat\",\"Alive\",\"SystemDecommissioned\",\"ClusterDecommissioned\",\"TabletNum\",\"DataUsedCapacity\",\"AvailCapacity\",\"TotalCapacity\",\"UsedPct\",\"MaxDiskUsedPct\",\"Tag\",\"ErrMsg\",\"Version\",\"Status\"],\"rows\":[{\"HttpPort\":\"8040\",\"Status\":\"{\\\"lastSuccessReportTabletsTime\\\":\\\"N/A\\\",\\\"lastStreamLoadTime\\\":-1}\",\"SystemDecommissioned\":\"false\",\"LastHeartbeat\":\"\\\\N\",\"DataUsedCapacity\":\"0.000 \",\"ErrMsg\":\"\",\"IP\":\"127.0.0.1\",\"UsedPct\":\"0.00 %\",\"__hrefPaths\":[\"/rest/v1/system?path=//backends/10002\"],\"Cluster\":\"default_cluster\",\"Alive\":\"true\",\"MaxDiskUsedPct\":\"0.00 %\",\"BrpcPort\":\"-1\",\"BePort\":\"-1\",\"ClusterDecommissioned\":\"false\",\"AvailCapacity\":\"1.000 B\",\"Ve
rsion\":\"\",\"BackendId\":\"10002\",\"HeartbeatPort\":\"9050\",\"LastStartTime\":\"\\\\N\",\"TabletNum\":\"0\",\"TotalCapacity\":\"0.000 \",\"Tag\":\"{\\\"location\\\" : \\\"default\\\"}\",\"HostName\":\"localhost\"}]}";
Review comment:
Add a `parseBackend` method unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Gabriel39 commented on pull request #6994: [Revert] Revert RestService.java
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on pull request #6994:
URL: https://github.com/apache/incubator-doris/pull/6994#issuecomment-958598951
cc @morningman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Gabriel39 commented on pull request #6994: [Revert] Revert RestService.java
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on pull request #6994:
URL: https://github.com/apache/incubator-doris/pull/6994#issuecomment-957254531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] chovy-3012 commented on a change in pull request #6994: [Revert] Revert RestService.java
Posted by GitBox <gi...@apache.org>.
chovy-3012 commented on a change in pull request #6994:
URL: https://github.com/apache/incubator-doris/pull/6994#discussion_r740996030
##########
File path: extension/spark-doris-connector/src/test/java/org/apache/doris/spark/rest/TestRestService.java
##########
@@ -293,4 +294,11 @@ public void testTabletsMapToPartition() throws Exception {
Assert.assertEquals(expected, actual);
}
+
+ @Test
+ public void testParseBackend() throws Exception {
+ String response = "{\"href_columns\":[\"BackendId\"],\"parent_url\":\"/rest/v1/system?path=/\",\"column_names\":[\"BackendId\",\"Cluster\",\"IP\",\"HostName\",\"HeartbeatPort\",\"BePort\",\"HttpPort\",\"BrpcPort\",\"LastStartTime\",\"LastHeartbeat\",\"Alive\",\"SystemDecommissioned\",\"ClusterDecommissioned\",\"TabletNum\",\"DataUsedCapacity\",\"AvailCapacity\",\"TotalCapacity\",\"UsedPct\",\"MaxDiskUsedPct\",\"Tag\",\"ErrMsg\",\"Version\",\"Status\"],\"rows\":[{\"HttpPort\":\"8040\",\"Status\":\"{\\\"lastSuccessReportTabletsTime\\\":\\\"N/A\\\",\\\"lastStreamLoadTime\\\":-1}\",\"SystemDecommissioned\":\"false\",\"LastHeartbeat\":\"\\\\N\",\"DataUsedCapacity\":\"0.000 \",\"ErrMsg\":\"\",\"IP\":\"127.0.0.1\",\"UsedPct\":\"0.00 %\",\"__hrefPaths\":[\"/rest/v1/system?path=//backends/10002\"],\"Cluster\":\"default_cluster\",\"Alive\":\"true\",\"MaxDiskUsedPct\":\"0.00 %\",\"BrpcPort\":\"-1\",\"BePort\":\"-1\",\"ClusterDecommissioned\":\"false\",\"AvailCapacity\":\"1.000 B\",\"Ve
rsion\":\"\",\"BackendId\":\"10002\",\"HeartbeatPort\":\"9050\",\"LastStartTime\":\"\\\\N\",\"TabletNum\":\"0\",\"TotalCapacity\":\"0.000 \",\"Tag\":\"{\\\"location\\\" : \\\"default\\\"}\",\"HostName\":\"localhost\"}]}";
Review comment:
Add a `parseBackend` method unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6994: [Revert] Revert RestService.java
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #6994:
URL: https://github.com/apache/incubator-doris/pull/6994#issuecomment-960440927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Gabriel39 commented on pull request #6994: [Revert] Revert RestService.java
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on pull request #6994:
URL: https://github.com/apache/incubator-doris/pull/6994#issuecomment-957254531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Gabriel39 commented on pull request #6994: [Revert] Revert RestService.java
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on pull request #6994:
URL: https://github.com/apache/incubator-doris/pull/6994#issuecomment-958598951
cc @morningman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Gabriel39 commented on pull request #6994: [Revert] Revert RestService.java
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on pull request #6994:
URL: https://github.com/apache/incubator-doris/pull/6994#issuecomment-957254531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org