You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2012/02/29 17:17:26 UTC

svn commit: r1295173 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DateParser.java

Author: ggregory
Date: Wed Feb 29 16:17:26 2012
New Revision: 1295173

URL: http://svn.apache.org/viewvc?rev=1295173&view=rev
Log:
Apply fix suggested by Benedikt Ritter on the ML: "The problem is, that there is no method with name "getTimeZoneOverridesCalendar()" in DateParser, so that link can't be resolved (I think you already knew that :).
I suppose the comment is meant to refer to getTimeZone() in java.util.Calendar. If so, you can fix that by changing the link to: {@link java.util.Calendar#getTimeZone()}"

Modified:
    commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DateParser.java

Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DateParser.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DateParser.java?rev=1295173&r1=1295172&r2=1295173&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DateParser.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DateParser.java Wed Feb 29 16:17:26 2012
@@ -18,6 +18,7 @@ package org.apache.commons.lang3.time;
 
 import java.text.ParseException;
 import java.text.ParsePosition;
+import java.util.Calendar;
 import java.util.Date;
 import java.util.Locale;
 import java.util.TimeZone;
@@ -67,8 +68,8 @@ public interface DateParser {
      *
      * <p>This zone is always used for <code>Date</code> formatting.
      * If a <code>Calendar</code> is passed in to be formatted, the
-     * time zone on that may be used depending on
-     * {@link #getTimeZoneOverridesCalendar()}.</p>
+     * time zone on that may be used depending on {@link Calendar#getTimeZone()}.
+     * </p>
      * 
      * @return the time zone
      */



Re: svn commit: r1295173 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DateParser.java

Posted by Gary Gregory <ga...@gmail.com>.
On Wed, Feb 29, 2012 at 12:36 PM, Honton, Charles <Charles_Honton@intuit.com
> wrote:

> Sorry about the leftover cruft.  The description should be:
>
> <p>The default {@link TimeZone} used to create a {@Link Date} when the
> {@link TimeZone} is not specified by the format pattern.</p>
>

Now in SVN.

Thank you,
Gary


>
> Chas Honton
>
>
> On 2/29/12 8:55 AM, "sebb" <se...@gmail.com> wrote:
>
> >On 29 February 2012 16:17,  <gg...@apache.org> wrote:
> >> Author: ggregory
> >> Date: Wed Feb 29 16:17:26 2012
> >> New Revision: 1295173
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1295173&view=rev
> >> Log:
> >> Apply fix suggested by Benedikt Ritter on the ML: "The problem is, that
> >>there is no method with name "getTimeZoneOverridesCalendar()" in
> >>DateParser, so that link can't be resolved (I think you already knew
> >>that :).
> >> I suppose the comment is meant to refer to getTimeZone() in
> >>java.util.Calendar. If so, you can fix that by changing the link to:
> >>{@link java.util.Calendar#getTimeZone()}"
> >
> >-1
> >
> >I think that's wrong - see my comment on Dev list thread.
> >
> >> Modified:
> >>
> >>commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/Dat
> >>eParser.java
> >>
> >> Modified:
> >>commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/Dat
> >>eParser.java
> >> URL:
> >>
> http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/
> >>apache/commons/lang3/time/DateParser.java?rev=1295173&r1=1295172&r2=12951
> >>73&view=diff
> >>
> >>=========================================================================
> >>=====
> >> ---
> >>commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/Dat
> >>eParser.java (original)
> >> +++
> >>commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/Dat
> >>eParser.java Wed Feb 29 16:17:26 2012
> >> @@ -18,6 +18,7 @@ package org.apache.commons.lang3.time;
> >>
> >>  import java.text.ParseException;
> >>  import java.text.ParsePosition;
> >> +import java.util.Calendar;
> >>  import java.util.Date;
> >>  import java.util.Locale;
> >>  import java.util.TimeZone;
> >> @@ -67,8 +68,8 @@ public interface DateParser {
> >>      *
> >>      * <p>This zone is always used for <code>Date</code> formatting.
> >>      * If a <code>Calendar</code> is passed in to be formatted, the
> >> -     * time zone on that may be used depending on
> >> -     * {@link #getTimeZoneOverridesCalendar()}.</p>
> >> +     * time zone on that may be used depending on {@link
> >>Calendar#getTimeZone()}.
> >> +     * </p>
> >>      *
> >>      * @return the time zone
> >>      */
> >>
> >>
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >For additional commands, e-mail: dev-help@commons.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: svn commit: r1295173 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DateParser.java

Posted by "Honton, Charles" <Ch...@intuit.com>.
Sorry about the leftover cruft.  The description should be:

<p>The default {@link TimeZone} used to create a {@Link Date} when the
{@link TimeZone} is not specified by the format pattern.</p>

Chas Honton


On 2/29/12 8:55 AM, "sebb" <se...@gmail.com> wrote:

>On 29 February 2012 16:17,  <gg...@apache.org> wrote:
>> Author: ggregory
>> Date: Wed Feb 29 16:17:26 2012
>> New Revision: 1295173
>>
>> URL: http://svn.apache.org/viewvc?rev=1295173&view=rev
>> Log:
>> Apply fix suggested by Benedikt Ritter on the ML: "The problem is, that
>>there is no method with name "getTimeZoneOverridesCalendar()" in
>>DateParser, so that link can't be resolved (I think you already knew
>>that :).
>> I suppose the comment is meant to refer to getTimeZone() in
>>java.util.Calendar. If so, you can fix that by changing the link to:
>>{@link java.util.Calendar#getTimeZone()}"
>
>-1
>
>I think that's wrong - see my comment on Dev list thread.
>
>> Modified:
>>    
>>commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/Dat
>>eParser.java
>>
>> Modified: 
>>commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/Dat
>>eParser.java
>> URL: 
>>http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/
>>apache/commons/lang3/time/DateParser.java?rev=1295173&r1=1295172&r2=12951
>>73&view=diff
>> 
>>=========================================================================
>>=====
>> --- 
>>commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/Dat
>>eParser.java (original)
>> +++ 
>>commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/Dat
>>eParser.java Wed Feb 29 16:17:26 2012
>> @@ -18,6 +18,7 @@ package org.apache.commons.lang3.time;
>>
>>  import java.text.ParseException;
>>  import java.text.ParsePosition;
>> +import java.util.Calendar;
>>  import java.util.Date;
>>  import java.util.Locale;
>>  import java.util.TimeZone;
>> @@ -67,8 +68,8 @@ public interface DateParser {
>>      *
>>      * <p>This zone is always used for <code>Date</code> formatting.
>>      * If a <code>Calendar</code> is passed in to be formatted, the
>> -     * time zone on that may be used depending on
>> -     * {@link #getTimeZoneOverridesCalendar()}.</p>
>> +     * time zone on that may be used depending on {@link
>>Calendar#getTimeZone()}.
>> +     * </p>
>>      *
>>      * @return the time zone
>>      */
>>
>>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>For additional commands, e-mail: dev-help@commons.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r1295173 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DateParser.java

Posted by sebb <se...@gmail.com>.
On 29 February 2012 16:17,  <gg...@apache.org> wrote:
> Author: ggregory
> Date: Wed Feb 29 16:17:26 2012
> New Revision: 1295173
>
> URL: http://svn.apache.org/viewvc?rev=1295173&view=rev
> Log:
> Apply fix suggested by Benedikt Ritter on the ML: "The problem is, that there is no method with name "getTimeZoneOverridesCalendar()" in DateParser, so that link can't be resolved (I think you already knew that :).
> I suppose the comment is meant to refer to getTimeZone() in java.util.Calendar. If so, you can fix that by changing the link to: {@link java.util.Calendar#getTimeZone()}"

-1

I think that's wrong - see my comment on Dev list thread.

> Modified:
>    commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DateParser.java
>
> Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DateParser.java
> URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DateParser.java?rev=1295173&r1=1295172&r2=1295173&view=diff
> ==============================================================================
> --- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DateParser.java (original)
> +++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/DateParser.java Wed Feb 29 16:17:26 2012
> @@ -18,6 +18,7 @@ package org.apache.commons.lang3.time;
>
>  import java.text.ParseException;
>  import java.text.ParsePosition;
> +import java.util.Calendar;
>  import java.util.Date;
>  import java.util.Locale;
>  import java.util.TimeZone;
> @@ -67,8 +68,8 @@ public interface DateParser {
>      *
>      * <p>This zone is always used for <code>Date</code> formatting.
>      * If a <code>Calendar</code> is passed in to be formatted, the
> -     * time zone on that may be used depending on
> -     * {@link #getTimeZoneOverridesCalendar()}.</p>
> +     * time zone on that may be used depending on {@link Calendar#getTimeZone()}.
> +     * </p>
>      *
>      * @return the time zone
>      */
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org