You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by Li Xu <le...@gmail.com> on 2011/11/15 21:37:55 UTC

update orders to load extended javascript features first

Hi, all

I noticed that extended javascript features is always loaded first than
default javascript features.
This is okay for normal case. However if we'd like an extended feature to
overwrite an default feature, this would become a problem.
Is there any objection to update the order to load default feature first?

 protected List<String>
defaultFeatures(@Named("shindig.features.default")String features,

@Named("org.apache.shindig.features-extended")Set<String> extended) {
    /*return ImmutableList.<String>builder()
        .addAll(extended)
        .addAll(Splitter.on(',').split(features))
        .build();*/
    return ImmutableList.<String>builder()
    .addAll(Splitter.on(',').split(features))
    .addAll(extended)
    .build();
  }

thanks,
li

Re: update orders to load extended javascript features first

Posted by Li Xu <le...@gmail.com>.

Thanks, Henry. I submitted the patch for review.
https://reviews.apache.org/r/2851/

thanks,
li

Re: update orders to load extended javascript features first

Posted by Henry Saputra <he...@gmail.com>.

+1

- Henry

On Tue, Nov 15, 2011 at 12:37 PM, Li Xu <le...@gmail.com> wrote:
> Hi, all
>
> I noticed that extended javascript features is always loaded first than
> default javascript features.
> This is okay for normal case. However if we'd like an extended feature to
> overwrite an default feature, this would become a problem.
> Is there any objection to update the order to load default feature first?
>
>  protected List<String>
> defaultFeatures(@Named("shindig.features.default")String features,
>
> @Named("org.apache.shindig.features-extended")Set<String> extended) {
>    /*return ImmutableList.<String>builder()
>        .addAll(extended)
>        .addAll(Splitter.on(',').split(features))
>        .build();*/
>    return ImmutableList.<String>builder()
>    .addAll(Splitter.on(',').split(features))
>    .addAll(extended)
>    .build();
>  }
>
> thanks,
> li
>