You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/03 22:47:48 UTC
[GitHub] [airflow] potiuk opened a new pull request, #28090: Add automated verwion replacement in example dag indexes
potiuk opened a new pull request, #28090:
URL: https://github.com/apache/airflow/pull/28090
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28090: Add automated version replacement in example dag indexes
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28090:
URL: https://github.com/apache/airflow/pull/28090#issuecomment-1336447476
I added pre-commit preventing hard-coded example dags to be part of the documentation and found few more places which i missed thanks to that :).
I also added better description for the commit - describing the context of the change and decribing that the fix really addresses 3 problems:
* historically generated links (past)
* automated conversion of the existing links (present)
* preventing further accidental document commits with hard-coded links via pre-commit (future)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28090: Add automated version replacement in example dag indexes
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28090:
URL: https://github.com/apache/airflow/pull/28090#issuecomment-1336293429
Also including fix to the tool correcting example_dag links
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #28090: Add automated version replacement in example dag indexes
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #28090:
URL: https://github.com/apache/airflow/pull/28090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28090: Add automated version replacement in example dag indexes
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28090:
URL: https://github.com/apache/airflow/pull/28090#issuecomment-1336293636
cc: @Taragolis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28090: Add automated version replacement in example dag indexes
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28090:
URL: https://github.com/apache/airflow/pull/28090#issuecomment-1336398520
Looks like it handles all cases (including references to the example DAGs from random pages like in yandex case (see the links at the bottom of the screen):
<img width="1201" alt="Screenshot 2022-12-04 at 13 11 49" src="https://user-images.githubusercontent.com/595491/205490021-db96934c-c23a-409f-a43a-50cde4b8fe5c.png">
<img width="846" alt="Screenshot 2022-12-04 at 13 11 57" src="https://user-images.githubusercontent.com/595491/205490022-5d71cbcb-396a-4205-959a-22dfa05e9f47.png">
<img width="832" alt="Screenshot 2022-12-04 at 13 18 03" src="https://user-images.githubusercontent.com/595491/205490023-cacedd35-5f2b-4d53-8026-9ee576573d0c.png">
<img width="1447" alt="Screenshot 2022-12-04 at 13 11 16" src="https://user-images.githubusercontent.com/595491/205490019-1ead797f-4724-4e24-847a-781bd0434c1e.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28090: Add automated version replacement in example dag indexes
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28090:
URL: https://github.com/apache/airflow/pull/28090#issuecomment-1336396630
@Taragolis - I already corrected all the historical links in https://github.com/apache/airflow-site/pull/706 - so the current documentation published should already have (I hope all) example_dags links properly linked to the right example versions.
This one should fix generating the documentation in the first place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28090: Add automated version replacement in example dag indexes
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28090:
URL: https://github.com/apache/airflow/pull/28090#issuecomment-1337545897
cc: @Taragolis :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org