You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/05/01 21:34:19 UTC

[GitHub] [arrow-datafusion] alamb opened a new pull request, #6186: minor: remove default match for function signature

alamb opened a new pull request, #6186:
URL: https://github.com/apache/arrow-datafusion/pull/6186

   # Which issue does this PR close?
   
   Related to https://github.com/apache/arrow-datafusion/pull/6149
   
   # Rationale for this change
   
   When adding a new function, it is important to update the metadata appropriately. However, when @izveigor missed one place in https://github.com/apache/arrow-datafusion/pull/6149 the resulting runtime error was quite confusing. It would be much better if the compiler told us the problem.
   
   # What changes are included in this PR?
   
   Replace a default match arm with all explicit patterns for clarity
   
   # Are these changes tested?
   
   Covered by existing tests
   # Are there any user-facing changes?
   
   no
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #6186: minor: remove default match for function signature

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6186:
URL: https://github.com/apache/arrow-datafusion/pull/6186


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org