You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "lanshiqin (via GitHub)" <gi...@apache.org> on 2023/04/18 10:30:37 UTC

[GitHub] [kafka] lanshiqin commented on pull request #13584: MINOR: Add log segment unit tests, If the maximum offset beyond index, appen…

lanshiqin commented on PR #13584:
URL: https://github.com/apache/kafka/pull/13584#issuecomment-1512838660

   Use @ParameterizedTest more test scenarios are covered.
   1. Negative value for largestOffset
   2. Value exceeding the range of integer 
   3. Create a segment with non-zero index so that we can test for https://github.com/apache/kafka/blob/trunk/storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java#L554 condition to be false. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org