You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Gary Bell (JIRA)" <ji...@apache.org> on 2008/10/30 14:59:44 UTC
[jira] Created: (FTPSERVER-208) calling resume() on listener does
has no effect
calling resume() on listener does has no effect
-----------------------------------------------
Key: FTPSERVER-208
URL: https://issues.apache.org/jira/browse/FTPSERVER-208
Project: FtpServer
Issue Type: Bug
Components: Core
Affects Versions: 1.0-M3
Environment: Windows XP, Sun 1.5.0 JVM
Reporter: Gary Bell
Calling resume() method on the default NioListener after it has been suspended has no effect. Attempting to connect to the server results in connection refused messages to the client.
I believe the problem is because the suspend() method does not set the suspended variable to true after the acceptor.unbind() call. This value is checked by the resume() method which only resumes the listener when the value is true.
=== copied from current svn HEAD ===
public synchronized void suspend() {
if (acceptor != null && !suspended) {
acceptor.unbind(address);
}
}
public synchronized void resume() {
if (acceptor != null && suspended) {
try {
acceptor.bind(address);
} catch (IOException e) {
LOG.error("Failed to resume listener", e);
}
}
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FTPSERVER-208) calling resume() on listener does
has no effect
Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niklas Gustavsson closed FTPSERVER-208.
---------------------------------------
Resolution: Fixed
Fix Version/s: 1.0-M4
Assignee: Niklas Gustavsson
Your analysis was correct, and while fixing this I also found another bug (FTPSERVER-210). Both fixed in rev 709409. Also added a test case for both these bugs.
> calling resume() on listener does has no effect
> -----------------------------------------------
>
> Key: FTPSERVER-208
> URL: https://issues.apache.org/jira/browse/FTPSERVER-208
> Project: FtpServer
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0-M3
> Environment: Windows XP, Sun 1.5.0 JVM
> Reporter: Gary Bell
> Assignee: Niklas Gustavsson
> Fix For: 1.0-M4
>
>
> Calling resume() method on the default NioListener after it has been suspended has no effect. Attempting to connect to the server results in connection refused messages to the client.
> I believe the problem is because the suspend() method does not set the suspended variable to true after the acceptor.unbind() call. This value is checked by the resume() method which only resumes the listener when the value is true.
> === copied from current svn HEAD ===
> public synchronized void suspend() {
> if (acceptor != null && !suspended) {
> acceptor.unbind(address);
>
> }
> }
> public synchronized void resume() {
> if (acceptor != null && suspended) {
> try {
> acceptor.bind(address);
> } catch (IOException e) {
> LOG.error("Failed to resume listener", e);
> }
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.