You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2016/02/26 12:57:52 UTC
Review Request 44066: Add pre-upgrade check that warns about
components with VERSION_MISMATCH
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44066/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-15203
https://issues.apache.org/jira/browse/AMBARI-15203
Repository: ambari
Description
-------
Add pre-upgrade check that warns about components with VERSION_MISMATCH
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java ba987aa
ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckGroup.java 0be5be1
ambari-server/src/main/java/org/apache/ambari/server/checks/VersionMismatchCheck.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/checks/VersionMismatchCheckTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/44066/diff/
Testing
-------
Unit tests in progress
Thanks,
Dmitro Lisnichenko
Re: Review Request 44066: Add pre-upgrade check that warns about
components with VERSION_MISMATCH
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44066/
-----------------------------------------------------------
(Updated Feb. 29, 2016, 1:33 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Changes
-------
Fixed comments, added documentation
Bugs: AMBARI-15203
https://issues.apache.org/jira/browse/AMBARI-15203
Repository: ambari
Description
-------
Add pre-upgrade check that warns about components with VERSION_MISMATCH
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java ba987aa
ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckGroup.java 0be5be1
ambari-server/src/main/java/org/apache/ambari/server/checks/VersionMismatchCheck.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/checks/VersionMismatchCheckTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/44066/diff/
Testing
-------
Failed tests:
ComponentResourceProviderTest.testGetResourcesAsAdministrator:183->testGetResources:289 expected:<[tru]e> but was:<[fals]e>
ComponentResourceProviderTest.testGetResourcesAsClusterAdministrator:188->testGetResources:289 expected:<[tru]e> but was:<[fals]e>
ComponentResourceProviderTest.testGetResourcesAsServiceAdministrator:193->testGetResources:289 expected:<[tru]e> but was:<[fals]e>
AmbariLdapDataPopulatorTest.testSynchronizeExistingLdapGroups_removeDuringIteration:325
Expectation failure on verify:
AmbariLdapDataPopulatorTestInstance.getLdapGroupByMemberAttr("group2"): expected: 1, actual: 0
Tests in error:
KerberosCheckerTest.testCheckFailed » Unexpected exception, expected<org.apac...
KerberosCheckerTest.testCheckPassed:62 » ClassCast class sun.security.provider...
Tests run: 3869, Failures: 4, Errors: 2, Skipped: 32
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [2.845s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.856s]
[INFO] Ambari Server ..................................... FAILURE [1:34:28.716s]
[INFO] Ambari Agent ...................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko
Re: Review Request 44066: Add pre-upgrade check that warns about
components with VERSION_MISMATCH
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44066/#review120946
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java (line 228)
<https://reviews.apache.org/r/44066/#comment182477>
Revise to: All components must be reporting the expected version
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java (line 231)
<https://reviews.apache.org/r/44066/#comment182475>
Revise to: "There are components which are not reporting the expected stack version"
ambari-server/src/main/java/org/apache/ambari/server/checks/VersionMismatchCheck.java (line 18)
<https://reviews.apache.org/r/44066/#comment182479>
Documentation.
ambari-server/src/main/java/org/apache/ambari/server/checks/VersionMismatchCheck.java (line 39)
<https://reviews.apache.org/r/44066/#comment182480>
Documentation.
ambari-server/src/main/java/org/apache/ambari/server/checks/VersionMismatchCheck.java (line 46)
<https://reviews.apache.org/r/44066/#comment182481>
Documentation.
ambari-server/src/main/java/org/apache/ambari/server/checks/VersionMismatchCheck.java (line 53)
<https://reviews.apache.org/r/44066/#comment182484>
Documenatation.
- Jonathan Hurley
On Feb. 26, 2016, 10:30 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44066/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 10:30 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-15203
> https://issues.apache.org/jira/browse/AMBARI-15203
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add pre-upgrade check that warns about components with VERSION_MISMATCH
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java ba987aa
> ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckGroup.java 0be5be1
> ambari-server/src/main/java/org/apache/ambari/server/checks/VersionMismatchCheck.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/checks/VersionMismatchCheckTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44066/diff/
>
>
> Testing
> -------
>
> Failed tests:
> ComponentResourceProviderTest.testGetResourcesAsAdministrator:183->testGetResources:289 expected:<[tru]e> but was:<[fals]e>
> ComponentResourceProviderTest.testGetResourcesAsClusterAdministrator:188->testGetResources:289 expected:<[tru]e> but was:<[fals]e>
> ComponentResourceProviderTest.testGetResourcesAsServiceAdministrator:193->testGetResources:289 expected:<[tru]e> but was:<[fals]e>
> AmbariLdapDataPopulatorTest.testSynchronizeExistingLdapGroups_removeDuringIteration:325
> Expectation failure on verify:
> AmbariLdapDataPopulatorTestInstance.getLdapGroupByMemberAttr("group2"): expected: 1, actual: 0
> Tests in error:
> KerberosCheckerTest.testCheckFailed » Unexpected exception, expected<org.apac...
> KerberosCheckerTest.testCheckPassed:62 » ClassCast class sun.security.provider...
>
> Tests run: 3869, Failures: 4, Errors: 2, Skipped: 32
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [2.845s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.856s]
> [INFO] Ambari Server ..................................... FAILURE [1:34:28.716s]
> [INFO] Ambari Agent ...................................... SKIPPED
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 44066: Add pre-upgrade check that warns about
components with VERSION_MISMATCH
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44066/#review120876
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/java/org/apache/ambari/server/checks/VersionMismatchCheck.java (line 65)
<https://reviews.apache.org/r/44066/#comment182402>
FailedOn should be a hostname. The fail message should contain the detail.
- Nate Cole
On Feb. 26, 2016, 10:30 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44066/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 10:30 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-15203
> https://issues.apache.org/jira/browse/AMBARI-15203
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add pre-upgrade check that warns about components with VERSION_MISMATCH
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java ba987aa
> ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckGroup.java 0be5be1
> ambari-server/src/main/java/org/apache/ambari/server/checks/VersionMismatchCheck.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/checks/VersionMismatchCheckTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44066/diff/
>
>
> Testing
> -------
>
> Failed tests:
> ComponentResourceProviderTest.testGetResourcesAsAdministrator:183->testGetResources:289 expected:<[tru]e> but was:<[fals]e>
> ComponentResourceProviderTest.testGetResourcesAsClusterAdministrator:188->testGetResources:289 expected:<[tru]e> but was:<[fals]e>
> ComponentResourceProviderTest.testGetResourcesAsServiceAdministrator:193->testGetResources:289 expected:<[tru]e> but was:<[fals]e>
> AmbariLdapDataPopulatorTest.testSynchronizeExistingLdapGroups_removeDuringIteration:325
> Expectation failure on verify:
> AmbariLdapDataPopulatorTestInstance.getLdapGroupByMemberAttr("group2"): expected: 1, actual: 0
> Tests in error:
> KerberosCheckerTest.testCheckFailed » Unexpected exception, expected<org.apac...
> KerberosCheckerTest.testCheckPassed:62 » ClassCast class sun.security.provider...
>
> Tests run: 3869, Failures: 4, Errors: 2, Skipped: 32
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [2.845s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.856s]
> [INFO] Ambari Server ..................................... FAILURE [1:34:28.716s]
> [INFO] Ambari Agent ...................................... SKIPPED
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 44066: Add pre-upgrade check that warns about
components with VERSION_MISMATCH
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44066/#review120927
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/java/org/apache/ambari/server/checks/VersionMismatchCheck.java (line 17)
<https://reviews.apache.org/r/44066/#comment182456>
Please add a description.
ambari-server/src/test/java/org/apache/ambari/server/checks/VersionMismatchCheckTest.java (line 24)
<https://reviews.apache.org/r/44066/#comment182455>
Please add some javadoc for the description.
- Alejandro Fernandez
On Feb. 26, 2016, 3:30 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44066/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 3:30 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-15203
> https://issues.apache.org/jira/browse/AMBARI-15203
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add pre-upgrade check that warns about components with VERSION_MISMATCH
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java ba987aa
> ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckGroup.java 0be5be1
> ambari-server/src/main/java/org/apache/ambari/server/checks/VersionMismatchCheck.java PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/checks/VersionMismatchCheckTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44066/diff/
>
>
> Testing
> -------
>
> Failed tests:
> ComponentResourceProviderTest.testGetResourcesAsAdministrator:183->testGetResources:289 expected:<[tru]e> but was:<[fals]e>
> ComponentResourceProviderTest.testGetResourcesAsClusterAdministrator:188->testGetResources:289 expected:<[tru]e> but was:<[fals]e>
> ComponentResourceProviderTest.testGetResourcesAsServiceAdministrator:193->testGetResources:289 expected:<[tru]e> but was:<[fals]e>
> AmbariLdapDataPopulatorTest.testSynchronizeExistingLdapGroups_removeDuringIteration:325
> Expectation failure on verify:
> AmbariLdapDataPopulatorTestInstance.getLdapGroupByMemberAttr("group2"): expected: 1, actual: 0
> Tests in error:
> KerberosCheckerTest.testCheckFailed » Unexpected exception, expected<org.apac...
> KerberosCheckerTest.testCheckPassed:62 » ClassCast class sun.security.provider...
>
> Tests run: 3869, Failures: 4, Errors: 2, Skipped: 32
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Views ...................................... SUCCESS [2.845s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.856s]
> [INFO] Ambari Server ..................................... FAILURE [1:34:28.716s]
> [INFO] Ambari Agent ...................................... SKIPPED
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 44066: Add pre-upgrade check that warns about
components with VERSION_MISMATCH
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44066/
-----------------------------------------------------------
(Updated Feb. 26, 2016, 5:30 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-15203
https://issues.apache.org/jira/browse/AMBARI-15203
Repository: ambari
Description
-------
Add pre-upgrade check that warns about components with VERSION_MISMATCH
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java ba987aa
ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckGroup.java 0be5be1
ambari-server/src/main/java/org/apache/ambari/server/checks/VersionMismatchCheck.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/checks/VersionMismatchCheckTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/44066/diff/
Testing (updated)
-------
Failed tests:
ComponentResourceProviderTest.testGetResourcesAsAdministrator:183->testGetResources:289 expected:<[tru]e> but was:<[fals]e>
ComponentResourceProviderTest.testGetResourcesAsClusterAdministrator:188->testGetResources:289 expected:<[tru]e> but was:<[fals]e>
ComponentResourceProviderTest.testGetResourcesAsServiceAdministrator:193->testGetResources:289 expected:<[tru]e> but was:<[fals]e>
AmbariLdapDataPopulatorTest.testSynchronizeExistingLdapGroups_removeDuringIteration:325
Expectation failure on verify:
AmbariLdapDataPopulatorTestInstance.getLdapGroupByMemberAttr("group2"): expected: 1, actual: 0
Tests in error:
KerberosCheckerTest.testCheckFailed » Unexpected exception, expected<org.apac...
KerberosCheckerTest.testCheckPassed:62 » ClassCast class sun.security.provider...
Tests run: 3869, Failures: 4, Errors: 2, Skipped: 32
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Views ...................................... SUCCESS [2.845s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.856s]
[INFO] Ambari Server ..................................... FAILURE [1:34:28.716s]
[INFO] Ambari Agent ...................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko