You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/12/23 00:30:35 UTC
[kudu-CR](branch-1.2.x) KUDU-1812. Redaction support for protobufs
Dan Burkert has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5570
Change subject: KUDU-1812. Redaction support for protobufs
......................................................................
KUDU-1812. Redaction support for protobufs
This adds a new local protobuf option 'kudu.REDACT' which can be used to
mark a field as containing user data and thus needing redaction during
stringification.
New 'DebugString' and 'ShortDebugString' variants are provided which
respect the redaction option and use the KUDU_REDACT macro to implement
it on fields tagged with this option.
This patch includes a test protobuf using this feature and also tags the
relevant fields in our various protobufs. However, it does not yet
change call sites to use the SecureDebugString variants -- that is done
in a follow-on commit.
This commit also does not implement redaction for the JSONWriter-based
stringification. As far as I am aware, we do not use JSON output in any
log messages, and we are not yet aiming to redact /tracing.html output,
etc.
Change-Id: Ie07bfdcbc33d38d55315faae2c4906899a5450fb
Reviewed-on: http://gerrit.cloudera.org:8080/5553
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit cef7b10239a1cf860bfcb526d503b07503442a49)
---
M src/kudu/cfile/CMakeLists.txt
M src/kudu/cfile/cfile.proto
M src/kudu/client/client.proto
M src/kudu/common/CMakeLists.txt
M src/kudu/common/common.proto
M src/kudu/common/wire_protocol.proto
M src/kudu/master/master.proto
M src/kudu/rpc/CMakeLists.txt
M src/kudu/rpc/rpc_header.proto
M src/kudu/tserver/tablet_copy.proto
M src/kudu/tserver/tserver.proto
M src/kudu/util/CMakeLists.txt
M src/kudu/util/pb_util-test.cc
M src/kudu/util/pb_util.cc
M src/kudu/util/pb_util.h
M src/kudu/util/pb_util.proto
A src/kudu/util/pb_util_test.proto
17 files changed, 180 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/5570/1
--
To view, visit http://gerrit.cloudera.org:8080/5570
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie07bfdcbc33d38d55315faae2c4906899a5450fb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.2.x) KUDU-1812. Redaction support for protobufs
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: KUDU-1812. Redaction support for protobufs
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5570
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie07bfdcbc33d38d55315faae2c4906899a5450fb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR](branch-1.2.x) KUDU-1812. Redaction support for protobufs
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: KUDU-1812. Redaction support for protobufs
......................................................................
KUDU-1812. Redaction support for protobufs
This adds a new local protobuf option 'kudu.REDACT' which can be used to
mark a field as containing user data and thus needing redaction during
stringification.
New 'DebugString' and 'ShortDebugString' variants are provided which
respect the redaction option and use the KUDU_REDACT macro to implement
it on fields tagged with this option.
This patch includes a test protobuf using this feature and also tags the
relevant fields in our various protobufs. However, it does not yet
change call sites to use the SecureDebugString variants -- that is done
in a follow-on commit.
This commit also does not implement redaction for the JSONWriter-based
stringification. As far as I am aware, we do not use JSON output in any
log messages, and we are not yet aiming to redact /tracing.html output,
etc.
Change-Id: Ie07bfdcbc33d38d55315faae2c4906899a5450fb
Reviewed-on: http://gerrit.cloudera.org:8080/5553
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit cef7b10239a1cf860bfcb526d503b07503442a49)
Reviewed-on: http://gerrit.cloudera.org:8080/5570
Reviewed-by: Dan Burkert <da...@apache.org>
---
M src/kudu/cfile/CMakeLists.txt
M src/kudu/cfile/cfile.proto
M src/kudu/client/client.proto
M src/kudu/common/CMakeLists.txt
M src/kudu/common/common.proto
M src/kudu/common/wire_protocol.proto
M src/kudu/master/master.proto
M src/kudu/rpc/CMakeLists.txt
M src/kudu/rpc/rpc_header.proto
M src/kudu/tserver/tablet_copy.proto
M src/kudu/tserver/tserver.proto
M src/kudu/util/CMakeLists.txt
M src/kudu/util/pb_util-test.cc
M src/kudu/util/pb_util.cc
M src/kudu/util/pb_util.h
M src/kudu/util/pb_util.proto
A src/kudu/util/pb_util_test.proto
17 files changed, 180 insertions(+), 30 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5570
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie07bfdcbc33d38d55315faae2c4906899a5450fb
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>