[GitHub] [drill] sohami commented on issue #1874: DRILL-7405: Avoiding download of TPC-H data

[GitBox <gi...@apache.org>]

sohami commented on issue #1874: DRILL-7405: Avoiding download of TPC-H data
URL: https://github.com/apache/drill/pull/1874#issuecomment-544024689
 
 
   Looks like these files were packaged as jar in Drill class path as an example data for users to run some exploratory queries. I think putting these files as part of source repo should be fine.
   
   @vvysotskyi : I think your main concern is related to the unit tests data files which are merged with the source files. I guess that was done to keep the test execution time lower otherwise ideally unit tests should use the in-memory data generator for it's use. May be we should come up with some policies which can dictate when is it fine to check in the test data file and when one should use in-memory data generator. 
   Also how does moving data files to a separate git repo will help here ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services