[jira] [Commented] (KYLIN-3603) HBase connection isn't closed in UpdateHTableHostCLI

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-3603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632705#comment-16632705 ] 

ASF GitHub Bot commented on KYLIN-3603:
---------------------------------------

caolijun1166 opened a new pull request #271: KYLIN-3603 Close the HBase connection after used in UpdateHTableHostCLI
URL: https://github.com/apache/kylin/pull/271
 
 
   Close the HBase connection after used in UpdateHTableHostCLI

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> HBase connection isn't closed in UpdateHTableHostCLI
> ----------------------------------------------------
>
>                 Key: KYLIN-3603
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3603
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Lijun Cao
>            Assignee: Lijun Cao
>            Priority: Minor
>             Fix For: v2.6.0
>
>
> The HBase connection is only used in the constructor to get an *_Admin_* , it should be closed after used.
> {code:java}
> public UpdateHTableHostCLI(List<String> htables, String oldHostValue) throws IOException {
>         this.htables = htables;
>         this.oldHostValue = oldHostValue;
>         Connection conn = ConnectionFactory.createConnection(HBaseConfiguration.create());
>         hbaseAdmin = conn.getAdmin();
>         this.kylinConfig = KylinConfig.getInstanceFromEnv();
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)