You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/02/24 21:46:28 UTC

[kudu-CR] [thirdparty] fix building LLVM+IWYU on ARM

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22534


Change subject: [thirdparty] fix building LLVM+IWYU on ARM
......................................................................

[thirdparty] fix building LLVM+IWYU on ARM

There had been an issue with building IWYU in-tree with LLVM for non-X86
platforms that was addressed upstream by [1].  It's necessary to add
that patch into Kudu's 3rd-party to fix building LLVM on ARM after [2].
Without the extra patch for IWYU's top-level CMakeLists.txt, building
Kudu's 3rd-party on ARM produces an error like below after [2]:

The error looked like the following:

  -- IWYU: in-tree configuration
  -- IWYU: configuring for LLVM 11.0.0...
  CMake Error at cmake/modules/LLVM-Config.cmake:274 (message):
    Library 'X86AsmParser' is a direct reference to a target library for an
    omitted target.
  Call Stack (most recent call first):
    cmake/modules/LLVM-Config.cmake:100 (llvm_map_components_to_libnames)
    cmake/modules/LLVM-Config.cmake:93 (explicit_llvm_config)
    cmake/modules/AddLLVM.cmake:867 (llvm_config)
    tools/clang/tools/include-what-you-use/CMakeLists.txt:49 (add_llvm_executable)

This is a follow-up to [2].

[1] https://github.com/include-what-you-use/include-what-you-use/commit/718e69875
[2] https://github.com/apache/kudu/commit/de9a0370e

Change-Id: If24fcf01079918d951278237241edb60610f5927
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/llvm-iwyu-718e69875.patch
2 files changed, 36 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/22534/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If24fcf01079918d951278237241edb60610f5927
Gerrit-Change-Number: 22534
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [thirdparty] fix building LLVM+IWYU on ARM

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22534 )

Change subject: [thirdparty] fix building LLVM+IWYU on ARM
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1107/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If24fcf01079918d951278237241edb60610f5927
Gerrit-Change-Number: 22534
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yan-Daojiang <ya...@163.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 24 Feb 2025 22:42:25 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] fix building LLVM+IWYU on ARM

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22534 )

Change subject: [thirdparty] fix building LLVM+IWYU on ARM
......................................................................

[thirdparty] fix building LLVM+IWYU on ARM

There had been an issue with building IWYU in-tree with LLVM for non-X86
platforms that was addressed upstream by [1].  It's necessary to add
that patch into Kudu's 3rd-party to fix building LLVM on ARM after [2].
Without the extra patch for IWYU's top-level CMakeLists.txt, building
Kudu's 3rd-party on ARM produces an error like below after [2]:

The error looked like the following:

  -- IWYU: in-tree configuration
  -- IWYU: configuring for LLVM 11.0.0...
  CMake Error at cmake/modules/LLVM-Config.cmake:274 (message):
    Library 'X86AsmParser' is a direct reference to a target library for an
    omitted target.
  Call Stack (most recent call first):
    cmake/modules/LLVM-Config.cmake:100 (llvm_map_components_to_libnames)
    cmake/modules/LLVM-Config.cmake:93 (explicit_llvm_config)
    cmake/modules/AddLLVM.cmake:867 (llvm_config)
    tools/clang/tools/include-what-you-use/CMakeLists.txt:49 (add_llvm_executable)

This is a follow-up to [2].

[1] https://github.com/include-what-you-use/include-what-you-use/commit/718e69875
[2] https://github.com/apache/kudu/commit/de9a0370e

Change-Id: If24fcf01079918d951278237241edb60610f5927
Reviewed-on: http://gerrit.cloudera.org:8080/22534
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/llvm-iwyu-718e69875.patch
2 files changed, 36 insertions(+), 1 deletion(-)

Approvals:
  Alexey Serbin: Verified
  Abhishek Chennaka: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/22534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If24fcf01079918d951278237241edb60610f5927
Gerrit-Change-Number: 22534
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yan-Daojiang <ya...@163.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR] [thirdparty] fix building LLVM+IWYU on ARM

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22534 )

Change subject: [thirdparty] fix building LLVM+IWYU on ARM
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1107/


-- 
To view, visit http://gerrit.cloudera.org:8080/22534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If24fcf01079918d951278237241edb60610f5927
Gerrit-Change-Number: 22534
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 24 Feb 2025 21:46:35 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] fix building LLVM+IWYU on ARM

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22534 )

Change subject: [thirdparty] fix building LLVM+IWYU on ARM
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If24fcf01079918d951278237241edb60610f5927
Gerrit-Change-Number: 22534
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yan-Daojiang <ya...@163.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 25 Feb 2025 00:08:50 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] fix building LLVM+IWYU on ARM

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22534 )

Change subject: [thirdparty] fix building LLVM+IWYU on ARM
......................................................................


Patch Set 1: Verified+1

unrelated test failures


-- 
To view, visit http://gerrit.cloudera.org:8080/22534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If24fcf01079918d951278237241edb60610f5927
Gerrit-Change-Number: 22534
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yan-Daojiang <ya...@163.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 24 Feb 2025 22:55:14 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] fix building LLVM+IWYU on ARM

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [thirdparty] fix building LLVM+IWYU on ARM
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/22534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: If24fcf01079918d951278237241edb60610f5927
Gerrit-Change-Number: 22534
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yan-Daojiang <ya...@163.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>