You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jared Stewart <js...@pivotal.io> on 2017/05/24 22:06:44 UTC
Review Request 59544: GEODE-2966: RefactorLauncherLifecycleCommands
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59544/
-----------------------------------------------------------
Review request for geode.
Repository: geode
Description
-------
- Extract several commands into their own classes.
- Extract utility methods into their own classes.
- Rename AbstractCommandsSupport to GfshCommand, and convert it from an abstract class to an interface
Diffs
-----
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java 27bc098d77c05d7385856e6fa4b769a7a2247a0e
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsTest.java 2a1662e318986b1520940403e7c881a2713c8920
geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java ce660578f4ddef1e733562e94f84a944cf1d3427
geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java 43ab546fadb3553cbe440a700d31f65e0500cb66
geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java a6d3064404a247f5d669ea7aff0cdd37e11e4583
geode-core/src/main/java/org/apache/geode/internal/Assert.java 4f54ca464cac82820dbffed7cbdadc3b21d878e7
geode-core/src/main/java/org/apache/geode/internal/process/ProcessStreamReader.java 18fca984b5792f096cc8b1755b09e65efbdd0d05
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/AbstractCommandsSupport.java 26b903b3895f7f01f01684c44cc320129c80f81e
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ClientCommands.java 18940fc0c6c0f36a7dd5cab5723d426d80df3cb9
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConfigCommands.java 6d3f50ff2bcdf9d0450dd40a8defb83c2f2f6e04
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java b8ebc4917d88ce089ec2a19d606e004c1e5c6b33
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommands.java a38e54504e949905f222d9891f624e373219364b
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java 4018beb8dfbd4bb639aec559991452226f15c908
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java 4232d91edc9a74db144d49542d79f7cfd9f4a98b
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DurableClientCommands.java bcbfcf0ca72876dbfb3d41613159aa051726870e
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportImportClusterConfigurationCommands.java ea101826493bfbc9211b4c673c596d7514a7f431
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommand.java b824bc915d453defe1c665eb7811a782f2c72fdf
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/FunctionCommands.java 2007e4af516274ac815cc3b06b9928f1aaed313f
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/GfshHelpCommands.java da13cdfc31cd3e3533c1305394ee1eb28415db5c
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java a4ba64c608f184fb130eb5ca3a05822f6cf82818
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java 74acfd6e03613ac4d0c62fcdd4ea859d1c74d2f2
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MemberCommands.java 415dd691cc6ed14bc67626881eecf65d5e446c99
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java 0d714f4c295e2aded0c0fd28bbf4f72ffcdd14a7
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/PDXCommands.java 0ce8ec272eee9f07a05aa0ac478e136163ee41e6
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java 6208adb63cc29f213c035849c78c3809f61b3f16
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/RegionCommands.java 561d4b8514c5b4500bf870e0b9d0ef3bcdbaf40d
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java ad344ff598db5474846d1b6b334d377e01c5fbd7
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/StatusCommands.java 29627f3b598d698d021fa079c434dc6ef5e03da1
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/WanCommands.java feeb3533e84fafbf22e5f9283690fe2ef0edf27e
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJConsoleCommand.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJVisualVMCommand.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartPulseCommand.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartVsdCommand.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StatusLocatorCommand.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StatusServerCommand.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopLocatorCommand.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopServerCommand.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java cbeee99602d0f0071d3b49fae130bd45a32780dc
geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java 78921c54e3a7e984947018969acb4166dcd5c1ed
geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/MXBeanProvider.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/management/internal/cli/util/HostUtils.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/management/internal/cli/util/JdkTool.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/management/internal/configuration/utils/ClusterConfigurationStatusRetriever.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/AssertJUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/extension/mock/MockExtensionCommands.java 59d8a77b1f3336461258666ec6bb85cb1a5ede21
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/AbstractCommandsSupportJUnitTest.java 7fedb9f8d03d5ddb2f142a3ac877f9aa5a275412
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommandsJUnitTest.java 9aeccad190adb11de2253abfe282fc6cfc2f2e0d
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/IndexCommandsJUnitTest.java e3a644d3bf5c999d225db46bbfc98c4a602e8256
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJConsoleCommandTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/cli/util/HostUtilsTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/cli/util/JdkToolTest.java PRE-CREATION
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java 5e17f6e55e6726f22cc39ddaba1ec608ca5cab9d
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommandsJUnitTest.java 66e15bb25712a82e764453312cb479d4c14b097e
Diff: https://reviews.apache.org/r/59544/diff/1/
Testing
-------
Thanks,
Jared Stewart
Re: Review Request 59544: GEODE-2966:
RefactorLauncherLifecycleCommands
Posted by Ken Howe <kh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59544/#review176009
-----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/internal/process/ProcessStreamReader.java
Lines 236 (patched)
<https://reviews.apache.org/r/59544/#comment249354>
Use SystemUtils.LINE_SEPARATOR to avoid propagating more uses of Geode StringUtils?
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommand.java
Line 35 (original), 19 (patched)
<https://reviews.apache.org/r/59544/#comment249352>
This is now an unused import
- Ken Howe
On May 24, 2017, 10:10 p.m., Jared Stewart wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59544/
> -----------------------------------------------------------
>
> (Updated May 24, 2017, 10:10 p.m.)
>
>
> Review request for geode.
>
>
> Repository: geode
>
>
> Description
> -------
>
> - Extract several commands into their own classes.
> - Extract utility methods into their own classes.
> - Rename AbstractCommandsSupport to GfshCommand, and convert it from an abstract class to an interface
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java 27bc098
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsTest.java 2a1662e
> geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java ce66057
> geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java 43ab546
> geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java a6d3064
> geode-core/src/main/java/org/apache/geode/internal/Assert.java 4f54ca4
> geode-core/src/main/java/org/apache/geode/internal/process/ProcessStreamReader.java 18fca98
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/AbstractCommandsSupport.java 26b903b
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ClientCommands.java 18940fc
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConfigCommands.java 6d3f50f
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java b8ebc49
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommands.java a38e545
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java 4018beb
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java 4232d91
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DurableClientCommands.java bcbfcf0
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportImportClusterConfigurationCommands.java ea10182
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommand.java b824bc9
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/FunctionCommands.java 2007e4a
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/GfshHelpCommands.java da13cdf
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java a4ba64c
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java 74acfd6
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MemberCommands.java 415dd69
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java 0d714f4
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/PDXCommands.java 0ce8ec2
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java 6208adb
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/RegionCommands.java 561d4b8
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java ad344ff
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/StatusCommands.java 29627f3
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/WanCommands.java feeb353
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJConsoleCommand.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJVisualVMCommand.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartPulseCommand.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartVsdCommand.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StatusLocatorCommand.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StatusServerCommand.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopLocatorCommand.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopServerCommand.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java cbeee99
> geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java 78921c5
> geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/MXBeanProvider.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/HostUtils.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/JdkTool.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/configuration/utils/ClusterConfigurationStatusRetriever.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/AssertJUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/extension/mock/MockExtensionCommands.java 59d8a77
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/AbstractCommandsSupportJUnitTest.java 7fedb9f
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommandsJUnitTest.java 9aeccad
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/IndexCommandsJUnitTest.java e3a644d
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJConsoleCommandTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/util/HostUtilsTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/util/JdkToolTest.java PRE-CREATION
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java 5e17f6e
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommandsJUnitTest.java 66e15bb
>
>
> Diff: https://reviews.apache.org/r/59544/diff/2/
>
>
> Testing
> -------
>
> Precheckin is running
>
>
> Thanks,
>
> Jared Stewart
>
>
Re: Review Request 59544: GEODE-2966:
RefactorLauncherLifecycleCommands
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59544/#review176488
-----------------------------------------------------------
Ship it!
Ship It!
- Jinmei Liao
On May 24, 2017, 10:10 p.m., Jared Stewart wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59544/
> -----------------------------------------------------------
>
> (Updated May 24, 2017, 10:10 p.m.)
>
>
> Review request for geode.
>
>
> Repository: geode
>
>
> Description
> -------
>
> - Extract several commands into their own classes.
> - Extract utility methods into their own classes.
> - Rename AbstractCommandsSupport to GfshCommand, and convert it from an abstract class to an interface
>
>
> Diffs
> -----
>
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java 27bc098
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsTest.java 2a1662e
> geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java ce66057
> geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java 43ab546
> geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java a6d3064
> geode-core/src/main/java/org/apache/geode/internal/Assert.java 4f54ca4
> geode-core/src/main/java/org/apache/geode/internal/process/ProcessStreamReader.java 18fca98
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/AbstractCommandsSupport.java 26b903b
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ClientCommands.java 18940fc
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConfigCommands.java 6d3f50f
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java b8ebc49
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommands.java a38e545
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java 4018beb
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java 4232d91
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DurableClientCommands.java bcbfcf0
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportImportClusterConfigurationCommands.java ea10182
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommand.java b824bc9
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/FunctionCommands.java 2007e4a
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/GfshHelpCommands.java da13cdf
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java a4ba64c
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java 74acfd6
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MemberCommands.java 415dd69
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java 0d714f4
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/PDXCommands.java 0ce8ec2
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java 6208adb
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/RegionCommands.java 561d4b8
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java ad344ff
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/StatusCommands.java 29627f3
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/WanCommands.java feeb353
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJConsoleCommand.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJVisualVMCommand.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartPulseCommand.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartVsdCommand.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StatusLocatorCommand.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StatusServerCommand.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopLocatorCommand.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopServerCommand.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java cbeee99
> geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java 78921c5
> geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/MXBeanProvider.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/HostUtils.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/cli/util/JdkTool.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/management/internal/configuration/utils/ClusterConfigurationStatusRetriever.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/AssertJUnitTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/extension/mock/MockExtensionCommands.java 59d8a77
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/AbstractCommandsSupportJUnitTest.java 7fedb9f
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommandsJUnitTest.java 9aeccad
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/IndexCommandsJUnitTest.java e3a644d
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJConsoleCommandTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/util/HostUtilsTest.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/management/internal/cli/util/JdkToolTest.java PRE-CREATION
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java 5e17f6e
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommandsJUnitTest.java 66e15bb
>
>
> Diff: https://reviews.apache.org/r/59544/diff/2/
>
>
> Testing
> -------
>
> Precheckin is running
>
>
> Thanks,
>
> Jared Stewart
>
>
Re: Review Request 59544: GEODE-2966:
RefactorLauncherLifecycleCommands
Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59544/
-----------------------------------------------------------
(Updated May 24, 2017, 10:10 p.m.)
Review request for geode.
Changes
-------
Spotless
Repository: geode
Description
-------
- Extract several commands into their own classes.
- Extract utility methods into their own classes.
- Rename AbstractCommandsSupport to GfshCommand, and convert it from an abstract class to an interface
Diffs (updated)
-----
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java 27bc098
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsTest.java 2a1662e
geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java ce66057
geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java 43ab546
geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java a6d3064
geode-core/src/main/java/org/apache/geode/internal/Assert.java 4f54ca4
geode-core/src/main/java/org/apache/geode/internal/process/ProcessStreamReader.java 18fca98
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/AbstractCommandsSupport.java 26b903b
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ClientCommands.java 18940fc
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConfigCommands.java 6d3f50f
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java b8ebc49
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommands.java a38e545
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java 4018beb
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java 4232d91
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DurableClientCommands.java bcbfcf0
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportImportClusterConfigurationCommands.java ea10182
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommand.java b824bc9
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/FunctionCommands.java 2007e4a
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/GfshHelpCommands.java da13cdf
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java a4ba64c
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java 74acfd6
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MemberCommands.java 415dd69
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java 0d714f4
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/PDXCommands.java 0ce8ec2
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java 6208adb
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/RegionCommands.java 561d4b8
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java ad344ff
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/StatusCommands.java 29627f3
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/WanCommands.java feeb353
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJConsoleCommand.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJVisualVMCommand.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartPulseCommand.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartVsdCommand.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StatusLocatorCommand.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StatusServerCommand.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopLocatorCommand.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopServerCommand.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java cbeee99
geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java 78921c5
geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/MXBeanProvider.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/management/internal/cli/util/HostUtils.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/management/internal/cli/util/JdkTool.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/management/internal/configuration/utils/ClusterConfigurationStatusRetriever.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/AssertJUnitTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/extension/mock/MockExtensionCommands.java 59d8a77
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/AbstractCommandsSupportJUnitTest.java 7fedb9f
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommandsJUnitTest.java 9aeccad
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/IndexCommandsJUnitTest.java e3a644d
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJConsoleCommandTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/cli/util/HostUtilsTest.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/management/internal/cli/util/JdkToolTest.java PRE-CREATION
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java 5e17f6e
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommandsJUnitTest.java 66e15bb
Diff: https://reviews.apache.org/r/59544/diff/2/
Changes: https://reviews.apache.org/r/59544/diff/1-2/
Testing
-------
Precheckin is running
Thanks,
Jared Stewart