You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2015/08/13 19:38:59 UTC
[GitHub] incubator-brooklyn pull request: license automation
GitHub user ahgittin opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/823
license automation
update the LICENSE with add'l reqs, and automate the process
@rdowner does the new format look good to you?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/incubator-brooklyn licensing
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/823.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #823
----
commit 487bb9cdb52ef54fc807ae9b1c00e36f649af5a0
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-08-12T18:20:58Z
can autogenerate LICENSE, and get more required licenses,
with info on running a license-audit in usage/dist/licensing
commit 3fd3901ebee86500951aa0b67dfd2c60691cdb38
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-08-12T18:29:22Z
remove unnecessary dependencies (in database)
commit 32b9579d67fcdc8e469ccfce10a4c9c2296239cc
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-08-13T17:25:18Z
new and improved LICENSE doc, autogenerated as per instructions in usage/dist/licensing
commit 52e4ba7538db3f2fa87f0a566ce483858b500318
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-08-13T17:35:16Z
add license headers - make compliant with RAT check
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: license automation
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/823#discussion_r37166842
--- Diff: software/database/pom.xml ---
@@ -107,18 +107,10 @@
<artifactId>groovy-all</artifactId>
</dependency>
<dependency>
- <groupId>com.beust</groupId>
- <artifactId>jcommander</artifactId>
- </dependency>
- <dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</dependency>
<dependency>
- <groupId>com.google.code.findbugs</groupId>
- <artifactId>jsr305</artifactId>
--- End diff --
I prefer to see explicit dependencies rather than transitive dependencies. It makes intent clearer, it means there's no surprises if the transitive dependencies change, and it reduces the noise from `mvn dependency:analyze`.
In the past I did go through and make all dependencies explicit - it made the initial process of dependency license discovery with `mvn dependency:analyze` much easier back when we were doing due diligence ahead of joining the incubator. I've not been following it up with further checks, though, so it probably has slipped.
Other transitive dependencies supply `@Nullable` however - jclouds has an implementation - so perhaps `DatastoreMixins` is referring to a non-JSR305 `@Nullable`? If so that is where the fix should be made.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: license automation
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/823#issuecomment-131740318
Aside from the change to the root `LICENSE` and the unrelated `pom.xml` changes, I'm happy with this PR. Handling license compliance in a project with as many dependencies as Brooklyn is a pain and adding this automation simplifies part of that process.
I have a good wishlist of what a license-helping tool would do! As I said earlier, established tooling is thin on the ground and I can easily see this and your Maven plugin developing into a comprehensive tool that could be re-used by many projects. The questions is do you want to consider that just now, or stick to the simplest thing that could possible work for Brooklyn :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: license automation
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/823#issuecomment-131729651
@ahgittin sorry I'm a bit late reviewing this. I'm looking through it just now and more comments may follow.
First off there's an issue with the root `LICENSE` file. This file is the LICENSE for the source distribution, and the source distribution does *not* include the big list of dependencies - only a small number of dependencies are directly bundled into the source distribution.
See https://brooklyn.incubator.apache.org/v/latest/dev/code/licensing.html#about-license-and-notice-files for some guidance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: license automation
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/823#issuecomment-131773287
Yes, due to a funny in the way that the Maven resource copier plugin works. By overriding it's configuration we're actually *replacing* it's configuration, so we need to configure both files - otherwise LICENSE gets copied and NOTICE goes missing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: license automation
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/823#discussion_r37169205
--- Diff: usage/dist/licensing/extras.yaml ---
@@ -0,0 +1,179 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+# extras file for org.heneveld.license-audit-maven-plugin
+# supplying info for addl licenses included with brooklyn
--- End diff --
So this file is for supplying information on non-Maven dependencies? If so could you state that here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: license automation
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/823#issuecomment-131878114
Tested and ensured that source, binary-dist, and jsgui and cli Maven artifacts all contain individualised licenses.
The database `pom.xml` change is still there. If you can drop that - then I will be a happy bunny and you can go ahead and merge :rabbit:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: license automation
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/823#issuecomment-131772871
@rdowner do we need the custom NOTICE files in `jsgui` and `cli`? they are the same as the base one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: license automation
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/823#discussion_r37174400
--- Diff: usage/dist/licensing/extras.yaml ---
@@ -0,0 +1,179 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+# extras file for org.heneveld.license-audit-maven-plugin
+# supplying info for addl licenses included with brooklyn
--- End diff --
will do
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: license automation
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/823#issuecomment-131784376
yes - that's important
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: license automation
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/823#discussion_r37174129
--- Diff: software/database/pom.xml ---
@@ -107,18 +107,10 @@
<artifactId>groovy-all</artifactId>
</dependency>
<dependency>
- <groupId>com.beust</groupId>
- <artifactId>jcommander</artifactId>
- </dependency>
- <dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</dependency>
<dependency>
- <groupId>com.google.code.findbugs</groupId>
- <artifactId>jsr305</artifactId>
--- End diff --
i agree, with richard (and maven recommendation) that projects declare their compile-time deps -- will restore. somehow missed the fact this was being pulled in from other projects.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: license automation
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/823#issuecomment-131768439
@rdowner thanks for detailed review. i will:
* sort out the source from binary dist LICENSE files (thanks for detailed notes)
* comment in `extras.yaml`
* restore findbugs
* add TODO about investigating SPDX -- i don't see easy wins but it's certainly more comprehensive than what maven or i have done here
as for making this a comprehensive tool, the best thing i think would be to contribute it to the maven-dependency-plugin. but that would take some major refactoring; i'm content to leave that for the time being. if there is interest in this then maybe.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: license automation
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/823#discussion_r37149217
--- Diff: software/database/pom.xml ---
@@ -107,18 +107,10 @@
<artifactId>groovy-all</artifactId>
</dependency>
<dependency>
- <groupId>com.beust</groupId>
- <artifactId>jcommander</artifactId>
- </dependency>
- <dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</dependency>
<dependency>
- <groupId>com.google.code.findbugs</groupId>
- <artifactId>jsr305</artifactId>
--- End diff --
Why remove this? It's used for `@Nullable`, which is used in `DatastoreMixins` etc. It's also a transitive dependency from brooklyn-api etc.
I believe the convention that @rdowner implemented was that if a package directly uses a class then it includes the dependency as an explicit dependency.
I can't remember whether that is still the convention - I vaguely remember a discussion and some disagreement about it previously. Personally, I have no strong feelings except that we are consistent.
@rdowner can you comment please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: license automation
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/823#issuecomment-131867805
This now generates source licenses differently to that of the binary. The /LICENSE contains a superset of notices put in individual JARs (from `source-inclusion.yaml`). The dist's LICENSE also includes all the maven dependencies.
We don't currently list the files against the licenses they reference; this may be a regression but I think there is enough information that this shouldn't be a problem, and having it automated is going to help prevent drift in future. Note that JAR's and JS file contain license/attribution in most cases (so license/notices may be included twice -- but that's good I think).
@rdowner you happy?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: license automation
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/823#issuecomment-131735347
Could SPDX[1][2] be any use in handling this problem?
The state of license analysis Maven plugins is pretty awful, so writing a new plugin to help with this is a good idea. However it'd be preferable to be standards-based so I'd been keen to know if your Maven plugin could handle SPDX metadata instead of making its own format?
[1]https://spdx.org/about-spdx
[2]https://lwn.net/Articles/644876/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: license automation
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/823#discussion_r37169463
--- Diff: usage/dist/licensing/README.md ---
@@ -0,0 +1,57 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+This uses a special maven plugin to create license and notification information,
+based on metadata in overrides.yaml and extras.yaml.
+
+First install https://github.com/ahgittin/license-audit-maven-plugin
--- End diff --
Any chance of getting this into Maven Central? I'd prefer to avoid instructions like "download this and install it, then..." (although since this plugin is only loosely bound into the project, it's not a big issue.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: license automation
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/823#issuecomment-131880430
well spotted on findbugs -- git messed up, fixed now.
i will merge. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: license automation
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/823#discussion_r37169080
--- Diff: usage/dist/licensing/README.md ---
@@ -0,0 +1,57 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+This uses a special maven plugin to create license and notification information,
+based on metadata in overrides.yaml and extras.yaml.
+
+First install https://github.com/ahgittin/license-audit-maven-plugin
+and then, in the usage/dist/ project of Brooklyn...
+
+
+To see a tree of license info:
+
+ mvn org.heneveld.maven:license-audit-maven-plugin:report \
+ -Dformat=summary \
+ -DlicensesPreferred=ASL2,ASL,EPL1,BSD-2-Clause,BSD-3-Clause,CDDL1.1,CDDL1,CDDL \
+ -DoverridesFile=licensing/overrides.yaml \
+ -DextrasFile=licensing/extras.yaml
+
+
+To create the LICENSE file in the root and in the dist:
+
+ pushd licensing > /dev/null
+ ./make-license.sh > LICENSE.autogenerated || ( echo 'FAILED!!!' && rm LICENSE.autogenerated )
+ cp LICENSE.autogenerated ../../../LICENSE
+ cp LICENSE.autogenerated ../src/main/license/LICENSE
--- End diff --
See my comment on the main PR. This is an issue. The source and binary distributions have *different* `LICENSE` files, because they bundle different dependencies. Each distribution needs to have a `LICENSE` file that is accurate for that distribution, without superfluous entries.
This approach is great for the binary distribution, but the source distribution will need to be handled differently. Given the relatively small number of dependencies bundled into the source distribution, I'm happy for that to be done manually, if that is the simplest approach.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: license automation
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/823#issuecomment-131885141
merged/closed against an out-of-date branch :( -- but i've reverted those and applied the correct ones
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: license automation
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/823#issuecomment-131778677
Sounds perfect :smile:
Will it be easy to add another project like `jsgui` and `cli` - e.g. if a different artifact in our project wants to start bundling a dependency?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: license automation
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/823#discussion_r37174423
--- Diff: usage/dist/licensing/README.md ---
@@ -0,0 +1,57 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+This uses a special maven plugin to create license and notification information,
+based on metadata in overrides.yaml and extras.yaml.
+
+First install https://github.com/ahgittin/license-audit-maven-plugin
--- End diff --
eventually - don't think this is a high priority atm though
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: license automation
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/823#issuecomment-130775111
BTW one reason for adding the preface to LICENSE is that otherwise people will think the doc is the ASL (the first 300 lines look the same!), not the Brooklyn LICENSE
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: license automation
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/823
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: license automation
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/823#issuecomment-131776426
@rdowner thanks - makes sense
so what i think the process should be:
* the script in `dist` will build *four* licenses:
* root source license
* `dist` binary license
* source licenses for `jsgui` and `cli` JARs
* the dist's `overrides.yaml` contains all the metadata for JS (so it just needs to be in one place)
* there will be an `extras.yaml` file for `jsgui` and `cli` listing the deps
* `dist` will not have an `extras.yaml` file but the script will be able to take multiple such (the jsgui and cli ones)
the source build will omit maven dependencies (new `onlyExtras` flag or similar on the `notices` target)
BTW i'm opposed to doing it manually because already we've drifted (e.g. bloodhound is removed)
i'll also update the `licensing.md` with instructions/pointers, and look through your dist's LICENSE (which I hadn't noticed was different) for anything I've left out.
any comments on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---