You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/05/19 01:38:25 UTC

[kudu-CR] [master] add /ipki-ca-cert webserver end-point

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19906


Change subject: [master] add /ipki-ca-cert webserver end-point
......................................................................

[master] add /ipki-ca-cert webserver end-point

This patch introduces a new /ipki-ca-cert end-point for the master's
embedded webserver to provide information on the IPKI CA certificate
used by a Kudu cluster.  This information might be useful in JWT-based
authentication scenarios.  The missing part of importing certificates
into Kudu client's chain of trusted TLS certificates will be addressed
in follow-up patches.

Change-Id: I833d934cc1d916dba243a05aa96926d3b540b70d
---
M src/kudu/integration-tests/security-itest.cc
M src/kudu/master/master_cert_authority.h
M src/kudu/master/master_path_handlers.cc
M src/kudu/master/master_path_handlers.h
M src/kudu/mini-cluster/webui_checker.h
5 files changed, 130 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/19906/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I833d934cc1d916dba243a05aa96926d3b540b70d
Gerrit-Change-Number: 19906
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [master] add /ipki-ca-cert webserver end-point

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Attila Bukor, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19906

to look at the new patch set (#3).

Change subject: [master] add /ipki-ca-cert webserver end-point
......................................................................

[master] add /ipki-ca-cert webserver end-point

This patch introduces a new /ipki-ca-cert end-point for the master's
embedded webserver to provide information on the IPKI CA certificate
used by a Kudu cluster.  This information is useful in JWT-based
authentication scenarios.  The missing part of importing certificates
into Kudu client's chain of trusted TLS certificates will be addressed
in follow-up patches.

Change-Id: I833d934cc1d916dba243a05aa96926d3b540b70d
---
M src/kudu/integration-tests/security-itest.cc
M src/kudu/integration-tests/webserver-crawl-itest.cc
M src/kudu/master/master_cert_authority.h
M src/kudu/master/master_path_handlers.cc
M src/kudu/master/master_path_handlers.h
M src/kudu/mini-cluster/webui_checker.h
6 files changed, 152 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/19906/3
-- 
To view, visit http://gerrit.cloudera.org:8080/19906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I833d934cc1d916dba243a05aa96926d3b540b70d
Gerrit-Change-Number: 19906
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] [master] add /ipki-ca-cert webserver end-point

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [master] add /ipki-ca-cert webserver end-point
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/19906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I833d934cc1d916dba243a05aa96926d3b540b70d
Gerrit-Change-Number: 19906
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] [master] add /ipki-ca-cert webserver end-point

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19906 )

Change subject: [master] add /ipki-ca-cert webserver end-point
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I833d934cc1d916dba243a05aa96926d3b540b70d
Gerrit-Change-Number: 19906
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 May 2023 23:53:21 +0000
Gerrit-HasComments: No

[kudu-CR] [master] add /ipki-ca-cert webserver end-point

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Attila Bukor, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19906

to look at the new patch set (#4).

Change subject: [master] add /ipki-ca-cert webserver end-point
......................................................................

[master] add /ipki-ca-cert webserver end-point

This patch introduces a new /ipki-ca-cert end-point for the master's
embedded webserver to provide information on the IPKI CA certificate
used by a Kudu cluster.  This information is useful in JWT-based
authentication scenarios.  The missing part of importing certificates
into Kudu client's chain of trusted TLS certificates will be addressed
in follow-up patches.

Change-Id: I833d934cc1d916dba243a05aa96926d3b540b70d
---
M src/kudu/integration-tests/security-itest.cc
M src/kudu/integration-tests/webserver-crawl-itest.cc
M src/kudu/master/master_cert_authority.h
M src/kudu/master/master_path_handlers.cc
M src/kudu/master/master_path_handlers.h
M src/kudu/mini-cluster/webui_checker.h
6 files changed, 153 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/19906/4
-- 
To view, visit http://gerrit.cloudera.org:8080/19906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I833d934cc1d916dba243a05aa96926d3b540b70d
Gerrit-Change-Number: 19906
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] [master] add /ipki-ca-cert webserver end-point

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19906 )

Change subject: [master] add /ipki-ca-cert webserver end-point
......................................................................

[master] add /ipki-ca-cert webserver end-point

This patch introduces a new /ipki-ca-cert end-point for the master's
embedded webserver to provide information on the IPKI CA certificate
used by a Kudu cluster.  This information is useful in JWT-based
authentication scenarios.  The missing part of importing certificates
into Kudu client's chain of trusted TLS certificates will be addressed
in follow-up patches.

Change-Id: I833d934cc1d916dba243a05aa96926d3b540b70d
Reviewed-on: http://gerrit.cloudera.org:8080/19906
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/integration-tests/security-itest.cc
M src/kudu/integration-tests/webserver-crawl-itest.cc
M src/kudu/master/master_cert_authority.h
M src/kudu/master/master_path_handlers.cc
M src/kudu/master/master_path_handlers.h
M src/kudu/mini-cluster/webui_checker.h
6 files changed, 153 insertions(+), 8 deletions(-)

Approvals:
  Alexey Serbin: Verified
  Abhishek Chennaka: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/19906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I833d934cc1d916dba243a05aa96926d3b540b70d
Gerrit-Change-Number: 19906
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] [master] add /ipki-ca-cert webserver end-point

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Attila Bukor, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19906

to look at the new patch set (#2).

Change subject: [master] add /ipki-ca-cert webserver end-point
......................................................................

[master] add /ipki-ca-cert webserver end-point

This patch introduces a new /ipki-ca-cert end-point for the master's
embedded webserver to provide information on the IPKI CA certificate
used by a Kudu cluster.  This information might be useful in JWT-based
authentication scenarios.  The missing part of importing certificates
into Kudu client's chain of trusted TLS certificates will be addressed
in follow-up patches.

Change-Id: I833d934cc1d916dba243a05aa96926d3b540b70d
---
M src/kudu/integration-tests/security-itest.cc
M src/kudu/master/master_cert_authority.h
M src/kudu/master/master_path_handlers.cc
M src/kudu/master/master_path_handlers.h
M src/kudu/mini-cluster/webui_checker.h
5 files changed, 141 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/19906/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I833d934cc1d916dba243a05aa96926d3b540b70d
Gerrit-Change-Number: 19906
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>

[kudu-CR] [master] add /ipki-ca-cert webserver end-point

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19906 )

Change subject: [master] add /ipki-ca-cert webserver end-point
......................................................................


Patch Set 5: Verified+1

unrelated test failure in DeleteTabletITest.TestLeaderElectionDuringDeleteTablet (TSAN)


-- 
To view, visit http://gerrit.cloudera.org:8080/19906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I833d934cc1d916dba243a05aa96926d3b540b70d
Gerrit-Change-Number: 19906
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 May 2023 16:38:27 +0000
Gerrit-HasComments: No