[GitHub] [incubator-ratis] szetszwo commented on pull request #237: [WIP]RATIS-1083. Create a transaction once the stream data is replicated to all servers

[GitBox <gi...@apache.org>]

szetszwo commented on pull request #237:
URL: https://github.com/apache/incubator-ratis/pull/237#issuecomment-718452423


   The original design is to make sure that close is applied in every server before sending start-transaction.  You are suggesting whether we could optimise it by not combining close and start-transaction.
   
   I think the optimisation may not be significant because it is a stream.
   - Original design: When we send close, we do not have to wait for the last write-ack in the stream.  We will wait for the close-ack and then send start-transaction.
   - New design: We wait for the write-ack and then send close.
   
   In both cases, we have to wait for one ack.  So the optimisation seems minor.
   
   If we implement the new design, we need to handle the case that some server fails (or is very slow) to close after received start-transaction.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org