You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "luwei16 (via GitHub)" <gi...@apache.org> on 2024/01/12 10:37:11 UTC
[PR] [fix](schema cache) adjust the destruction order of _tablet_schema_cache and storage engine [doris]
luwei16 opened a new pull request, #29923:
URL: https://github.com/apache/doris/pull/29923
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](schema cache) adjust the destruction order of tablet_schema_cache and storage engine [doris]
Posted by "luwei16 (via GitHub)" <gi...@apache.org>.
luwei16 commented on PR #29923:
URL: https://github.com/apache/doris/pull/29923#issuecomment-1888847373
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](schema cache) adjust the destruction order of tablet_schema_cache and storage engine [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29923:
URL: https://github.com/apache/doris/pull/29923#issuecomment-1888896662
<details>
<summary>TPC-H: <b>Total hot run time: 38558 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6a531b4d47efef304a4983d643a7505ce7d0facd, data reload: false
------ Round 1 ----------------------------------
q1 17988 5007 4942 4942
q2 2025 136 132 132
q3 10709 1101 1173 1101
q4 10249 811 881 811
q5 7797 3150 3135 3135
q6 200 125 129 125
q7 884 533 488 488
q8 9252 1941 1974 1941
q9 7305 6438 6443 6438
q10 8229 3103 3025 3025
q11 422 224 219 219
q12 370 196 200 196
q13 18124 3439 3436 3436
q14 239 212 212 212
q15 554 514 514 514
q16 432 382 390 382
q17 941 517 557 517
q18 7207 6705 6672 6672
q19 1610 1338 1430 1338
q20 579 297 305 297
q21 2788 2334 2439 2334
q22 349 309 303 303
Total cold run time: 108253 ms
Total hot run time: 38558 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4948 4937 4980 4937
q2 310 205 200 200
q3 3341 3297 3300 3297
q4 2230 2257 2242 2242
q5 5793 5777 5789 5777
q6 195 120 125 120
q7 2310 1834 1868 1834
q8 3428 3523 3553 3523
q9 8858 8811 8799 8799
q10 3753 3791 3818 3791
q11 547 431 420 420
q12 779 602 609 602
q13 8279 3234 3223 3223
q14 288 267 266 266
q15 568 515 512 512
q16 503 462 448 448
q17 2043 1994 2013 1994
q18 8758 8335 8253 8253
q19 1630 1624 1623 1623
q20 2168 1912 1942 1912
q21 6134 5706 5722 5706
q22 551 455 490 455
Total cold run time: 67414 ms
Total hot run time: 59934 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](schema cache) adjust the destruction order of tablet_schema_cache and storage engine [doris]
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on PR #29923:
URL: https://github.com/apache/doris/pull/29923#issuecomment-1890310032
Please add comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](schema cache) adjust the destruction order of tablet_schema_cache and storage engine [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #29923:
URL: https://github.com/apache/doris/pull/29923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](schema cache) adjust the destruction order of tablet_schema_cache and storage engine [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29923:
URL: https://github.com/apache/doris/pull/29923#issuecomment-1889103922
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](schema cache) adjust the destruction order of tablet_schema_cache and storage engine [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29923:
URL: https://github.com/apache/doris/pull/29923#issuecomment-1889104007
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](schema cache) adjust the destruction order of tablet_schema_cache and storage engine [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29923:
URL: https://github.com/apache/doris/pull/29923#issuecomment-1888897230
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.03 seconds
stream load tsv: 563 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 22.1 seconds inserted 10000000 Rows, about 452K ops/s
storage size: 17183905499 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](schema cache) adjust the destruction order of tablet_schema_cache and storage engine [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29923:
URL: https://github.com/apache/doris/pull/29923#issuecomment-1888921684
<details>
<summary>ClickBench: <b>Total hot run time: 30.16 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6a531b4d47efef304a4983d643a7505ce7d0facd, data reload: false
query1 0.06 0.05 0.05
query2 0.06 0.02 0.02
query3 0.25 0.11 0.11
query4 1.73 0.12 0.10
query5 0.51 0.51 0.51
query6 1.41 0.64 0.65
query7 0.02 0.02 0.01
query8 0.05 0.02 0.02
query9 0.56 0.52 0.49
query10 0.53 0.53 0.54
query11 0.13 0.08 0.09
query12 0.11 0.10 0.09
query13 0.61 0.59 0.60
query14 0.80 0.79 0.79
query15 0.82 0.80 0.80
query16 0.34 0.34 0.36
query17 0.97 0.98 0.96
query18 0.25 0.24 0.25
query19 1.83 1.76 1.79
query20 0.02 0.01 0.01
query21 15.40 0.59 0.60
query22 2.77 2.64 1.46
query23 17.04 0.88 0.87
query24 16.18 0.58 0.60
query25 2.16 0.15 0.14
query26 0.14 0.13 0.13
query27 0.15 0.14 0.15
query28 7.24 0.85 0.83
query29 12.57 3.34 3.17
query30 0.56 0.46 0.47
query31 2.79 0.37 0.37
query32 3.32 0.48 0.48
query33 3.22 3.21 3.21
query34 15.75 4.15 4.16
query35 4.18 4.16 4.16
query36 1.11 1.03 1.05
query37 0.07 0.05 0.05
query38 0.04 0.02 0.03
query39 0.03 0.02 0.01
query40 0.16 0.14 0.13
query41 0.07 0.02 0.01
query42 0.02 0.01 0.02
query43 0.03 0.02 0.02
Total cold run time: 116.06 s
Total hot run time: 30.16 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](schema cache) adjust the destruction order of tablet_schema_cache and storage engine [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29923:
URL: https://github.com/apache/doris/pull/29923#issuecomment-1888858915
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](schema cache) adjust the destruction order of tablet_schema_cache and storage engine [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29923:
URL: https://github.com/apache/doris/pull/29923#issuecomment-1888913786
<details>
<summary>TPC-DS: <b>Total hot run time: 177769 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6a531b4d47efef304a4983d643a7505ce7d0facd, data reload: false
query1 931 332 326 326
query2 6737 1848 1918 1848
query3 6695 210 204 204
query4 26026 22066 22031 22031
query5 8100 589 568 568
query6 275 193 188 188
query7 4602 279 273 273
query8 228 198 202 198
query9 9255 2734 2735 2734
query10 621 239 238 238
query11 16136 15421 15336 15336
query12 130 76 70 70
query13 1704 373 389 373
query14 12085 7181 7182 7181
query15 273 195 188 188
query16 5794 257 242 242
query17 1901 484 478 478
query18 1960 268 264 264
query19 281 147 145 145
query20 80 73 71 71
query21 192 129 131 129
query22 5025 4842 4791 4791
query23 31608 30902 30828 30828
query24 12233 2819 2844 2819
query25 553 330 317 317
query26 1841 151 150 150
query27 2803 276 276 276
query28 7044 1878 1857 1857
query29 2079 700 688 688
query30 278 138 138 138
query31 959 748 752 748
query32 98 58 60 58
query33 721 261 234 234
query34 1076 463 465 463
query35 913 724 747 724
query36 1319 1248 1234 1234
query37 189 73 69 69
query38 3385 3276 3248 3248
query39 1329 1284 1282 1282
query40 326 94 94 94
query41 46 34 35 34
query42 108 93 98 93
query43 524 496 509 496
query44 1106 702 716 702
query45 208 178 179 178
query46 1054 665 649 649
query47 1632 1549 1585 1549
query48 394 327 312 312
query49 1280 312 315 312
query50 711 316 324 316
query51 5304 5241 5226 5226
query52 97 91 95 91
query53 360 295 276 276
query54 912 455 452 452
query55 89 89 85 85
query56 214 190 198 190
query57 1011 929 950 929
query58 222 189 188 188
query59 2694 2611 2575 2575
query60 251 199 213 199
query61 83 82 79 79
query62 656 415 399 399
query63 306 299 270 270
query64 5773 1693 1653 1653
query65 3327 3255 3239 3239
query66 1305 339 324 324
query67 15614 15427 15044 15044
query68 12804 525 529 525
query69 703 370 385 370
query70 1679 1517 1529 1517
query71 560 260 235 235
query72 4927 2782 2812 2782
query73 3088 323 324 323
query74 7026 6333 6528 6333
query75 5533 2355 2290 2290
query76 6409 885 1117 885
query77 767 279 287 279
query78 10207 8499 8527 8499
query79 1050 506 491 491
query80 514 339 348 339
query81 426 204 205 204
query82 207 91 83 83
query83 181 123 119 119
query84 287 72 75 72
query85 794 333 332 332
query86 376 398 353 353
query87 3607 3380 3360 3360
query88 3012 2227 2212 2212
query89 455 367 393 367
query90 1935 206 192 192
query91 161 124 141 124
query92 62 54 53 53
query93 1315 444 445 444
query94 1287 182 179 179
query95 525 469 467 467
query96 619 319 310 310
query97 4257 4148 4221 4148
query98 198 189 188 188
query99 1007 731 743 731
Total cold run time: 299044 ms
Total hot run time: 177769 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](schema cache) adjust the destruction order of tablet_schema_cache and storage engine [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29923:
URL: https://github.com/apache/doris/pull/29923#issuecomment-1888897759
TeamCity be ut coverage result:
Function Coverage: 36.70% (8647/23562)
Line Coverage: 28.71% (70398/245222)
Region Coverage: 27.63% (36392/131709)
Branch Coverage: 24.34% (18611/76460)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6a531b4d47efef304a4983d643a7505ce7d0facd_6a531b4d47efef304a4983d643a7505ce7d0facd/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org