You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/19 07:34:13 UTC

[GitHub] [flink] PatrickRen commented on pull request #17401: [FLINK-24409][connectors] Fix metrics errors with topics names with periods

PatrickRen commented on pull request #17401:
URL: https://github.com/apache/flink/pull/17401#issuecomment-946442553


   Sorry for my late response! @jherico Here's my implementation of the test case that might be helpful. Feel free to cherry-pick it or implement your own. 
   
   https://github.com/PatrickRen/flink/commit/7e7f0d4e9e79e132965df517c7eae53bdf26ab9c
   
   Another choice is to use parameterized test in JUnit 5 for testing `pendingRecords` with different topic names including with special characters, but first you need to migrate `KafkaPartitionSplitReaderTest` to JUnit 5 style. Here's my implementation: 
   
   https://github.com/PatrickRen/flink/commit/e17ac779ae7b228681ba1aae2944e13a287469ae


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org