[GitHub] [incubator-dubbo] kezhenxu94 opened pull request #3131: style: using computeIfAbsent instead of checking manually

["kezhenxu94 (GitHub)" <gi...@apache.org>]

## What is the purpose of the change

This patch uses `Map#computeIfAbsent` to compute a value for a key instead of checking and putting explicitly.

## Brief changelog

XXXXX

## Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3131 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] khanimteyaz commented on pull request #3131: style: using computeIfAbsent instead of checking manually

["khanimteyaz (GitHub)" <gi...@apache.org>]

After looking at you reply I refesh my understanding, string concatination has better performance then String.format. . Only one point where String.format could be good chouce, if we want to throws localize message from resource bundle. But I think in this case it does not apply, so what I am on with you on this. No need of change for this. 
Thanks for helping out to refresh my understanding 😄 

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3131 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] ralf0131 commented on pull request #3131: style: using computeIfAbsent instead of checking manually

["ralf0131 (GitHub)" <gi...@apache.org>]

Why do we need a try-catch block here, isn't it caught by the outer try-catch block?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3131 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] kezhenxu94 closed pull request #3131: style: using computeIfAbsent instead of checking manually

["kezhenxu94 (GitHub)" <gi...@apache.org>]

[ pull request closed by kezhenxu94 ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3131 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] kezhenxu94 commented on pull request #3131: style: using computeIfAbsent instead of checking manually

["kezhenxu94 (GitHub)" <gi...@apache.org>]

I don't think it's not very worthwhile because we are using Java 8 features, and in Java 8 the string concatenation is optimized in compile time, isn't it?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3131 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] khanimteyaz commented on pull request #3131: style: using computeIfAbsent instead of checking manually

["khanimteyaz (GitHub)" <gi...@apache.org>]

can we use this instead of string concatination.
`throw new IllegalStateException(String.format("Extension instance(name: %s,class: %s could not be instantiated: %s",name,type,t.getMessage),t);`

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3131 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] kezhenxu94 commented on pull request #3131: style: using computeIfAbsent instead of checking manually

["kezhenxu94 (GitHub)" <gi...@apache.org>]

It is in the lambda block so we have to catch the exception within the lambda

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3131 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] khanimteyaz commented on pull request #3131: style: using computeIfAbsent instead of checking manually

["khanimteyaz (GitHub)" <gi...@apache.org>]

After looking at your reply I refesh my understanding, string concatination has better performance then String.format. . Only one point where String.format could be good choice, if we want localize message from resource bundle. But I think in this case it does not apply, so I am with you on this. No need of change here. 
Thanks for helping out to refresh my understanding 😄 

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3131 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org