You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/11/01 20:02:57 UTC
[kudu-CR] compaction policy: improve tests
Hello zhen.zhang, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8443
to review the following change.
Change subject: compaction_policy: improve tests
......................................................................
compaction_policy: improve tests
Adds tests cases for some more time-series-like layouts of rowsets.
Change-Id: Iaf19d382c916a807f9af3fa34da43e651a566663
---
M src/kudu/tablet/compaction_policy-test.cc
1 file changed, 82 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/8443/1
--
To view, visit http://gerrit.cloudera.org:8080/8443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaf19d382c916a807f9af3fa34da43e651a566663
Gerrit-Change-Number: 8443
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: zhen.zhang <zh...@xiaomi.com>
[kudu-CR] compaction policy: improve tests
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8443 )
Change subject: compaction_policy: improve tests
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8443/1/src/kudu/tablet/compaction_policy-test.cc
File src/kudu/tablet/compaction_policy-test.cc:
http://gerrit.cloudera.org:8080/#/c/8443/1/src/kudu/tablet/compaction_policy-test.cc@90
PS1, Line 90: if (!AllowSlowTests()) {
How long does this test take to run? If <5s, I'd say run it always.
Same goes for TestTinyOverlapRowsets.
http://gerrit.cloudera.org:8080/#/c/8443/1/src/kudu/tablet/compaction_policy-test.cc@103
PS1, Line 103: ASSERT_EQ(quality, 0);
Assert picked.empty()? Or is it not guaranteed?
Same for the other new tests.
--
To view, visit http://gerrit.cloudera.org:8080/8443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf19d382c916a807f9af3fa34da43e651a566663
Gerrit-Change-Number: 8443
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: zhen.zhang <zh...@xiaomi.com>
Gerrit-Comment-Date: Wed, 01 Nov 2017 20:40:30 +0000
Gerrit-HasComments: Yes
[kudu-CR] compaction policy: improve tests
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8443 )
Change subject: compaction_policy: improve tests
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8443/1/src/kudu/tablet/compaction_policy-test.cc
File src/kudu/tablet/compaction_policy-test.cc:
http://gerrit.cloudera.org:8080/#/c/8443/1/src/kudu/tablet/compaction_policy-test.cc@90
PS1, Line 90: if (!AllowSlowTests()) {
> How long does this test take to run? If <5s, I'd say run it always.
In release builds, they take about 5-6 seconds prior to the optimizations and 0.4sec after.
In DEBUG they take about 45 seconds prior to optimizations, about 5 seconds after. So it seemed long enough that it should be callled "slow", at least prior to optimizations.
--
To view, visit http://gerrit.cloudera.org:8080/8443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf19d382c916a807f9af3fa34da43e651a566663
Gerrit-Change-Number: 8443
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: zhen.zhang <zh...@xiaomi.com>
Gerrit-Comment-Date: Wed, 01 Nov 2017 20:46:40 +0000
Gerrit-HasComments: Yes
[kudu-CR] compaction policy: improve tests
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, zhen.zhang, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8443
to look at the new patch set (#2).
Change subject: compaction_policy: improve tests
......................................................................
compaction_policy: improve tests
Adds tests cases for some more time-series-like layouts of rowsets.
Change-Id: Iaf19d382c916a807f9af3fa34da43e651a566663
---
M src/kudu/tablet/compaction_policy-test.cc
1 file changed, 87 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/8443/2
--
To view, visit http://gerrit.cloudera.org:8080/8443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaf19d382c916a807f9af3fa34da43e651a566663
Gerrit-Change-Number: 8443
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: zhen.zhang <zh...@xiaomi.com>
[kudu-CR] compaction policy: improve tests
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8443 )
Change subject: compaction_policy: improve tests
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf19d382c916a807f9af3fa34da43e651a566663
Gerrit-Change-Number: 8443
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: zhen.zhang <zh...@xiaomi.com>
Gerrit-Comment-Date: Wed, 01 Nov 2017 22:28:01 +0000
Gerrit-HasComments: No
[kudu-CR] compaction policy: improve tests
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8443 )
Change subject: compaction_policy: improve tests
......................................................................
compaction_policy: improve tests
Adds tests cases for some more time-series-like layouts of rowsets.
Change-Id: Iaf19d382c916a807f9af3fa34da43e651a566663
Reviewed-on: http://gerrit.cloudera.org:8080/8443
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/tablet/compaction_policy-test.cc
1 file changed, 87 insertions(+), 14 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8443
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf19d382c916a807f9af3fa34da43e651a566663
Gerrit-Change-Number: 8443
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: zhen.zhang <zh...@xiaomi.com>