[GitHub] [spark] Yikun commented on a change in pull request #31823: [SPARK-34630][PYTHON][SQL] Added typehint for pyspark.sql.Column.contains

[GitBox <gi...@apache.org>]

Yikun commented on a change in pull request #31823:
URL: https://github.com/apache/spark/pull/31823#discussion_r610719541



##########
File path: python/pyspark/sql/column.pyi
##########
@@ -115,3 +115,4 @@ class Column:
     def over(self, window: WindowSpec) -> Column: ...
     def __nonzero__(self) -> None: ...
     def __bool__(self) -> None: ...
+    def contains(self, item: Union[str, Column]) -> Column: ...

Review comment:
       The above typehint in version.pyi is ok to some reference like `pyspark.verion.__version`, but doesn't work on some reference like `pyspark.__version`, such like https://github.com/apache/spark/blob/c06758834e6192b1888b4a885c612a151588b390/python/pyspark/pandas/spark/accessors.py#L884
   
   I submit a PR: https://github.com/apache/spark/pull/32110




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org