[GitHub] [skywalking-docker] kezhenxu94 commented on a change in pull request #24: Merge Docker images for ES 6 / 7 into one

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #24:
URL: https://github.com/apache/skywalking-docker/pull/24#discussion_r703498788



##########
File path: base/Dockerfile
##########
@@ -13,22 +13,14 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-ARG tag
 
 FROM adoptopenjdk/openjdk11:alpine AS base
 ARG version
 RUN echo "Building Apache SkyWalking ${version}"
 ENV SKYWALKING_VERSION=${version}
-
-FROM base AS es6
-RUN echo "This is the stage that build the es6 image"
 ENV SKYWALKING_TGZ=apache-skywalking-apm-${SKYWALKING_VERSION}.tar.gz
 
-FROM base AS es7
-RUN echo "This is the stage that build the es7 image"
-ENV SKYWALKING_TGZ=apache-skywalking-apm-es7-${SKYWALKING_VERSION}.tar.gz
-
-FROM ${tag} AS build
+FROM base AS build

Review comment:
       That another thing I want to ask, why don't we put these docker files in their corresponding repo so that they can evolve with the codebase instead of using manual `archive` here. Also they can be tested if they are in the corresponding repo (like oap in apache/skywalking and java agent in apache/skywalking-java) in the CI an PR process 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org