[GitHub] [incubator-pinot] xiangfu0 commented on a change in pull request #6964: fixed GenericRow compare for different _fieldToValueMap size

[GitBox <gi...@apache.org>]

xiangfu0 commented on a change in pull request #6964:
URL: https://github.com/apache/incubator-pinot/pull/6964#discussion_r644320872



##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/GenericRow.java
##########
@@ -217,65 +217,11 @@ public boolean equals(Object obj) {
     }
     if (obj instanceof GenericRow) {
       GenericRow that = (GenericRow) obj;
-      if (!_nullValueFields.containsAll(that._nullValueFields) || !that._nullValueFields

Review comment:
       make sense




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org