You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/03/03 18:12:34 UTC
[GitHub] [lucene-solr] ctargett opened a new pull request #2447: SOLR-15212: Update Ref Guide URLs for new Solr TLP
ctargett opened a new pull request #2447:
URL: https://github.com/apache/lucene-solr/pull/2447
Updates most URLs in the Ref Guide header and text to `solr.apache.org`.
There are a few cases of the old URL left in the text, but they are part of code snippets that reflect what's in config files shipped with Solr. I thought those should stay as is until a general code sweep happens to update the old URLs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] janhoy commented on a change in pull request #2447: SOLR-15212: Update Ref Guide URLs for new Solr TLP
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #2447:
URL: https://github.com/apache/lucene-solr/pull/2447#discussion_r586836655
##########
File path: solr/solr-ref-guide/build.gradle
##########
@@ -120,15 +120,15 @@ ext {
path: 'html-site',
desc: 'HTML Site for publishing to the Solr website',
props: [
- htmlSolrJavadocs: "https://lucene.apache.org/solr/${solrGuideVersionPath}_0/",
+ htmlSolrJavadocs: "https://solr.apache.org/${solrGuideVersionPath}_0/",
Review comment:
I just thought we could advertise the /docs/ path as the one people should use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #2447: SOLR-15212: Update Ref Guide URLs for new Solr TLP
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on a change in pull request #2447:
URL: https://github.com/apache/lucene-solr/pull/2447#discussion_r586733109
##########
File path: solr/solr-ref-guide/build.gradle
##########
@@ -120,15 +120,15 @@ ext {
path: 'html-site',
desc: 'HTML Site for publishing to the Solr website',
props: [
- htmlSolrJavadocs: "https://lucene.apache.org/solr/${solrGuideVersionPath}_0/",
+ htmlSolrJavadocs: "https://solr.apache.org/${solrGuideVersionPath}_0/",
Review comment:
I believe Jan meant that the path of the javadocs should be prefixed with `/docs/`, i.e. "https://solr.apache.org/docs/${solrGuideVersionPath}_0/"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] ctargett closed pull request #2447: SOLR-15212: Update Ref Guide URLs for new Solr TLP
Posted by GitBox <gi...@apache.org>.
ctargett closed pull request #2447:
URL: https://github.com/apache/lucene-solr/pull/2447
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] ctargett commented on pull request #2447: SOLR-15212: Update Ref Guide URLs for new Solr TLP
Posted by GitBox <gi...@apache.org>.
ctargett commented on pull request #2447:
URL: https://github.com/apache/lucene-solr/pull/2447#issuecomment-789973767
> Is `{solr-javadocs}/core/org/apache/solr/handler/component/SuggestComponent.html` the right syntax? Guess this is not jinja syntax but something else...
This is how all the other javadocs links are constructed (see something like `implicit-requesthandlers.adoc`) - this one I found because the URL was hardcoded and not using an attribute.
The syntax here is an asciidoctor attribute `{solr-javadocs}` followed by the path, so not jinja or anything like that. In `_config.yml_template` the asciidoctor `{solr-javadocs}` attribute is mapped to `${htmlSolrJavadocs}`, which you can see in the changes to `build.gradle` as mapped to the URL with more attribute-based substitution inserting the version to the URL path.
In full disclosure I'm not able to fully test the mapping since there is no 9_0_0 published javadocs yet to redirect to. I'm planning on making sure it still works when I backport to branch_8x and it's probably something that we should check again for the 9.0 release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] ctargett commented on a change in pull request #2447: SOLR-15212: Update Ref Guide URLs for new Solr TLP
Posted by GitBox <gi...@apache.org>.
ctargett commented on a change in pull request #2447:
URL: https://github.com/apache/lucene-solr/pull/2447#discussion_r586743840
##########
File path: solr/solr-ref-guide/build.gradle
##########
@@ -120,15 +120,15 @@ ext {
path: 'html-site',
desc: 'HTML Site for publishing to the Solr website',
props: [
- htmlSolrJavadocs: "https://lucene.apache.org/solr/${solrGuideVersionPath}_0/",
+ htmlSolrJavadocs: "https://solr.apache.org/${solrGuideVersionPath}_0/",
Review comment:
Oh, okay, I see what you're saying. The example I have is the redirect Jan is talking about. But I don't see why it matters? There's already a redirect so let it redirect?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] ctargett commented on pull request #2447: SOLR-15212: Update Ref Guide URLs for new Solr TLP
Posted by GitBox <gi...@apache.org>.
ctargett commented on pull request #2447:
URL: https://github.com/apache/lucene-solr/pull/2447#issuecomment-801305264
Moving PR to new `solr` repo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] ctargett commented on a change in pull request #2447: SOLR-15212: Update Ref Guide URLs for new Solr TLP
Posted by GitBox <gi...@apache.org>.
ctargett commented on a change in pull request #2447:
URL: https://github.com/apache/lucene-solr/pull/2447#discussion_r586686161
##########
File path: solr/solr-ref-guide/build.gradle
##########
@@ -120,15 +120,15 @@ ext {
path: 'html-site',
desc: 'HTML Site for publishing to the Solr website',
props: [
- htmlSolrJavadocs: "https://lucene.apache.org/solr/${solrGuideVersionPath}_0/",
+ htmlSolrJavadocs: "https://solr.apache.org/${solrGuideVersionPath}_0/",
Review comment:
The Ref Guide only builds on minor releases (X_Y), not patch releases (X_Y_Z) so we only ever need to link to javadocs for 8_7_0, 8_8_0, etc. I think that's what you meant?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] ctargett commented on a change in pull request #2447: SOLR-15212: Update Ref Guide URLs for new Solr TLP
Posted by GitBox <gi...@apache.org>.
ctargett commented on a change in pull request #2447:
URL: https://github.com/apache/lucene-solr/pull/2447#discussion_r586739977
##########
File path: solr/solr-ref-guide/build.gradle
##########
@@ -120,15 +120,15 @@ ext {
path: 'html-site',
desc: 'HTML Site for publishing to the Solr website',
props: [
- htmlSolrJavadocs: "https://lucene.apache.org/solr/${solrGuideVersionPath}_0/",
+ htmlSolrJavadocs: "https://solr.apache.org/${solrGuideVersionPath}_0/",
Review comment:
The `docs` is added automatically as far as I can tell. The attributes in the `.adoc` are used to construct a URL in the HTML file, which in this example becomes:
`https://solr.apache.org/9_0_0//core/org/apache/solr/handler/component/SuggestComponent.html`
when one clicks on it and it goes through the javadocs redirect it comes out as:
`https://solr.apache.org/docs/9_0_0/core/org/apache/solr/handler/component/SuggestComponent.html`
_edit_: bad copy paste
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] ctargett commented on a change in pull request #2447: SOLR-15212: Update Ref Guide URLs for new Solr TLP
Posted by GitBox <gi...@apache.org>.
ctargett commented on a change in pull request #2447:
URL: https://github.com/apache/lucene-solr/pull/2447#discussion_r586739977
##########
File path: solr/solr-ref-guide/build.gradle
##########
@@ -120,15 +120,15 @@ ext {
path: 'html-site',
desc: 'HTML Site for publishing to the Solr website',
props: [
- htmlSolrJavadocs: "https://lucene.apache.org/solr/${solrGuideVersionPath}_0/",
+ htmlSolrJavadocs: "https://solr.apache.org/${solrGuideVersionPath}_0/",
Review comment:
The `docs` is added automatically as far as I can tell. The attributes in the `.adoc` are used to construct a URL in the HTML file, which in this example becomes:
`https://solr.apache.org/9_0_0//core/org/apache/solr/handler/component/SuggestComponent.html`
when one clicks on it and it goes through the javadocs redirect it comes out as:
`https://solr.apache.org/docs/9_0_0/core/org/apache/solr/handler/admin/ShowFileRequestHandler.html`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] janhoy commented on a change in pull request #2447: SOLR-15212: Update Ref Guide URLs for new Solr TLP
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #2447:
URL: https://github.com/apache/lucene-solr/pull/2447#discussion_r586675497
##########
File path: solr/solr-ref-guide/build.gradle
##########
@@ -120,15 +120,15 @@ ext {
path: 'html-site',
desc: 'HTML Site for publishing to the Solr website',
props: [
- htmlSolrJavadocs: "https://lucene.apache.org/solr/${solrGuideVersionPath}_0/",
+ htmlSolrJavadocs: "https://solr.apache.org/${solrGuideVersionPath}_0/",
Review comment:
Actually I chose `/docs/X_Y_Z` as the javadoc root. But due to `.htaccess` rule, `/X_Y_Z` also works, but is redirected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org